MIME-Version: 1.0
References: 
 <CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com>
In-Reply-To: 
 <CA+3i_M98-XjE-_fw0p+8xOnw64y2_YLtJfcwvCfsVMn-z2ZjGg@mail.gmail.com>
From: Nisha Moond <nisha.moond412@gmail.com>
Date: Mon, 27 Apr 2026 13:58:58 +0530
Message-ID: 
 <CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4=fNYPrdw@mail.gmail.com>
Subject: Re: [PATCH] Fix Int32GetDatum used for bool column in CREATE
 SUBSCRIPTION
To: Lakshmi N <lakshmin.jhs@gmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABdArM4nF-QTeOsGt40NAngeeH7yJ4RVtMU4hWjVM4%3DfNYPrdw%40mail.gmail.com>
Precedence: bulk

On Mon, Apr 27, 2026 at 11:03=E2=80=AFAM Lakshmi N <lakshmin.jhs@gmail.com>=
 wrote:
>
> Hi hackers,
>
> In CreateSubscription(), the subretentionactive catalog column (declared =
as
> bool in pg_subscription.h) is populated using Int32GetDatum() instead of
> BoolGetDatum():
>
> This writes 4 bytes into a 1-byte bool Datum. It is inconsistent with the
> ALTER SUBSCRIPTION path which correctly uses BoolGetDatum().
>
> The attached patch fixes this to use BoolGetDatum(), matching both the
> catalog definition and the ALTER path.
>

+1
This looks like an oversight in commit a850be2.

--
Thanks,
Nisha