Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7oDR-005iLv-1D for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 05:34:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w7oDP-00F3BL-2f for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2026 05:34:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w7oDP-00F3BB-1m for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 05:34:07 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w7oDO-000000025V5-1Rb1 for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2026 05:34:07 +0000 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-5a2853b1f8cso6427466e87.3 for ; Tue, 31 Mar 2026 22:34:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1775021644; cv=none; d=google.com; s=arc-20240605; b=lQujsSMHmz7EhpriVLjbVo2kWkuB/KusAwL0SFWAJ3ae8Zrcon+ozy4PP2ipadeSLo FSt4Ss3p8C0dfXubiWTNTgqkdqkhE/E+RKIU9EptbBF2WT9MSZRK1qgA0b2HXRLMnSFH MMhoM4gPbDuI170k7T3A5PRmGMPucOR1IZDMcHQIhGOYqRD2+r3pbPU0FGlzxxxauqeL eG5SO9CFniQRfaYa9sAdDs8AiJvVo5NGMdUVbPB4z9Meg3saE1SvoVUoPSXKZ8xaTm9c wkq7GjdJ24hUX54uwEI8LrjH2JNMb9G+fGmSEGAKUPXxltA8r8LA1QMvN/eyP8vYjYyp Lv6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Y9RS6O7Hmi5ThMalmBuorHk8a2IWY9NyNT54jEmmcBE=; fh=rtH1bL2BcZa+EbGOzcccfj7VquEXQBXg6ZYRr8RnN0o=; b=CWq2S8ygyXuaZFk3n7SyxesbQALezbZpaQS3umDJR4Kff8lY709TRYdX/YaN/8oiQX etgzsMTJ/xFUiCOsZhNSgjZf/CPJpFryj2VIFKzqhzmnzXGYlp+Zn4kL9O9RypuXJSHb HM/Gg6F9GY0vlQbRXqFuhYWkY21xGlhSryWBjUpIld2KmlOX9NrQ4itlpoY3+9uHODsg +Ykmdb+HHkL7LVNVO2GdK6qCLVc6LwIveB+k0dtkNNMC63kbBYG1WVURjRLo0a15uXAN HbmHYTPk4RwXIaFpQRaS3AZ484RSPYL1AvNYUCEfNcQkIP4lf5MwMlI/OjerEK7Q8ae0 epzg==; darn=lists.postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775021644; x=1775626444; darn=lists.postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y9RS6O7Hmi5ThMalmBuorHk8a2IWY9NyNT54jEmmcBE=; b=F5eXShoIwKoQLavqdmpZfjgsm3FQzdsf5WFSZuVrpmTQQFSKdeGh9bSVSKo6jw0Ghk yrSw9i4W3uuvxJ+d2UoNnoW791eDFQVWqBfF8wnheKBReCEnCCCOIaYenZ51mN+wVayp lD1i/kibQZrbP095FTOhpcj7PbWlWoCihlaGk22RyywV9yNmIyHx1Ku1VMmgF9FTUMqZ XkRNaiaHIiGX3i5+c2ad7vKmfc9In2FoGjqza1qCMWZVE5w1GDtJdrew+DRj9//v1soW stoYgeOuaqv9gpM2VNeSyuk6xthCGZmvQ4Bap79NJSrBSk1nwza6T0CgnLBnYaqoGPXj 9pVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775021644; x=1775626444; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Y9RS6O7Hmi5ThMalmBuorHk8a2IWY9NyNT54jEmmcBE=; b=aYFqlS35OGNGmDzp/PaKnQ6dICNP8A6L03Xx0eaE+tJx/jRqkZKKRqLoG2Obu8MzJL /HcSlxpVoXLUBpYZ4p7u/PU55RT7wZ89aeYLZT31+i6kwn25GcU8zPRQuXycgPjXwVi6 zRCk4FV/EM1/Sa3l/BJEuU3QQfJT9XSV8nI3Nce0qaJMSaf302XXnM0Glie76RWuVuJb ouG0cM/CI7flfcuiJNBSumqfnv6Hry0gd22PxAPXNTxSyLEOPSm8F4MHEccKpl7z7lNk GyNCmw10tm0/DrNNqbWf1Ekr+LW8xN3cdiw5WevrbFYntRcuPXPI7CmNHFqXL1hNX6HE UrJw== X-Forwarded-Encrypted: i=1; AJvYcCWo558anPoyFpzAGvXcS1hLZ2SwzgcHQndNQpHXEG9Ri6eo/v7nl7j6hrYkixBOf3q+BQYG0L1IJxdDGwPO@lists.postgresql.org X-Gm-Message-State: AOJu0YxiupKmMl50XpxmU9LY0GZUj7dpEJon0h+lWbEmHFuQ3AnMuqMA szBhN6OcDeqHPQuZsGqlOE1bRdYHqggWXJZf/RkMCFOZKehyOBYchwjqON/2F1IyOsKconCWMmC DA87xNkSRvRLwfvwQHidbI2QzOnIW2A== X-Gm-Gg: ATEYQzwR++FYMkLyaVmeAKM9giT4bF3JSDx9mShwuLMj++KrghRhjruD8JdCoSBWV4z NIcNiDq1sW9JEX/Lj9nvlrpr5FtG85M5sBDyt7TO0hmG1MISkGOFwMnkj4afEi2mGgTz6nobDom w8I/1/r2HDrr2V3YqVaOB1bITE1AG3Lb//qliQFRYW1m75VhAz5DydNdKHDpsBOQf4orcvr8ivw rRkSZj4nAzMI4rpCKocLySipO2nqQNi7uGdh38uLjDyD5ucfXnS1zWKB590Vve6qSWmTPMnMJwx /rAEkN3zTNpGnA== X-Received: by 2002:a05:6512:b08:b0:5a2:9cb4:9729 with SMTP id 2adb3069b0e04-5a2c1ee2f50mr837106e87.2.1775021643577; Tue, 31 Mar 2026 22:34:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nisha Moond Date: Wed, 1 Apr 2026 11:03:51 +0530 X-Gm-Features: AQROBzAkaHhyqxFoygcN5s7Z_RjFGd3zFsl2O5TYZ59rtfItDUK0yCf243uKV8A Message-ID: Subject: Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion? To: "Zhijie Hou (Fujitsu)" Cc: shveta malik , Fujii Masao , Amit Kapila , PostgreSQL Hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Mar 31, 2026 at 3:56=E2=80=AFPM Zhijie Hou (Fujitsu) wrote: > > On Tuesday, March 31, 2026 2:02 PM Nisha Moond = wrote: > > > > > > Please find the updated patch (v6) attached. > > Thanks for updating the patch. One minor comment: > > I think we could avoid interrupting and reporting an ERROR when > IsSyncingReplicationSlots() returns false to avoid reporting ERROR unnece= ssarily > when the slotsync has already finished. > Thanks for the review. Fixed above in v7. -- Thanks, Nisha