MIME-Version: 1.0
References: 
 <CABdArM4uA=6nA0BunJwudiEoY1BcWUS_oj_2pkEq_d-YdiBJhw@mail.gmail.com>
 <CAHGQGwEOvk0ioxT+eGX-6vHO=2kQRXwKcbOku0qW2cEZ0DnJiQ@mail.gmail.com>
 <CAA4eK1KbUpkEq5Pv0_ORLqxea-Gzi=PJjvVS4T-r+WTuKDGQMA@mail.gmail.com>
 <CAHGQGwFyY_JDkM3twz-dS8wQgzd7_n6oayQk27Oqz1f7LTWEzw@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwFyY_JDkM3twz-dS8wQgzd7_n6oayQk27Oqz1f7LTWEzw@mail.gmail.com>
From: Nisha Moond <nisha.moond412@gmail.com>
Date: Thu, 4 Jun 2026 11:09:27 +0530
Message-ID: 
 <CABdArM5tnrvRogzmjh+duuXPgMFGKYVdYJkdEEiqT22wsFcD2g@mail.gmail.com>
Subject: Re: Fix column privileges for pg_subscription.subwalrcvtimeout
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CABdArM5tnrvRogzmjh%2BduuXPgMFGKYVdYJkdEEiqT22wsFcD2g%40mail.gmail.com>
Precedence: bulk

On Thu, Jun 4, 2026 at 7:35=E2=80=AFAM Fujii Masao <masao.fujii@gmail.com> =
wrote:
>
> On Tue, Jun 2, 2026 at 11:56=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.=
com> wrote:
> > > BTW, should we add a regression test for column privileges on pg_subs=
cription
> > > to help catch similar issues in the future?
> > >
> >
> > +1. It makes sense because I noticed that patch authors previously
> > also omitted this part though in most cases those are caught in
> > review.
>
> Agreed. I've added the regression test to the patch.
> Attached is the updated version.
>

Thank you, Fujii-san, for the updated patch. I tested both the success
and failure cases with the SQL query, and it worked as expected.

The patch LGTM.

--
Thanks,
Nisha