Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSeje-002qv3-1i for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Dec 2025 17:09:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vSejc-000abF-0k for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Dec 2025 17:09:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vSejb-000ab7-2r for pgsql-hackers@lists.postgresql.org; Mon, 08 Dec 2025 17:09:16 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vSejY-003mwB-29 for pgsql-hackers@lists.postgresql.org; Mon, 08 Dec 2025 17:09:14 +0000 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-64175dfc338so8011012a12.0 for ; Mon, 08 Dec 2025 09:09:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1765213752; x=1765818552; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6lpvb7KIoyfr+j16GwDv7t4rfJyBssFb8srb5U40kcI=; b=YV6JwDbnULIVmJOAlKizKCIcNsfPGF+xpGbQfbQ8hyzIawavLycRSwGYXEXECDuvBr 3zxJYfSNn/hciytkCQwTtdFlSYdcermd/mLq4ZIdoY6LO0bszsSXZJ/d1TmGfxH/+INN 4JCNJT3rDAx/Vm8qXvcSVNVbSZdDyihg6+glE8okL9yE+MjaNESXHUIPaxi4DMWKTW1k POKYFxXSw8l5YUwkwrT0d9My2zn4xcM37d/N4H6/kI2kqvsknyJEzB+44UNin9alHLu5 xUBcYX8+Ye4mkcB8srCYh4077iwVv1pujojGnGKGQJOnK6UKvZPdcTtl2tyhn6tCI4+s l+aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765213752; x=1765818552; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6lpvb7KIoyfr+j16GwDv7t4rfJyBssFb8srb5U40kcI=; b=U2IFU5c6femEiDNatMixoUBtOZ0fqj28TokP8D+VVnTFHmMF2YCYQvu+IxKyG/uKNq zQv8L4iYAnocjiAVWGiQu5hbDkKBKCYMZa4Z80H7V2u8mupB4ShA0xQyak3lRvhe2HOU 6mVycYrz8aDx9dtpECp4LhcN58m8AkZW6XEBZNvIC6jyd6N5X7oKYTV8D4DULqQo0kmr I/mKZOv/1poagl4nyalZoq9WtUIp3hf5KITzpzQCRGEbtXU0yeZAQ3wKBXYnDWXpclL3 mK3FXUh/Ccg0dRM81GPfGMJQlUrQAbRGaZoys8ozsasA3DKGZQvub8fHR+meVoZuuNo0 +4vg== X-Forwarded-Encrypted: i=1; AJvYcCVLUtCukPUKO62R+jk16V9IEy2TyoL7uYXcjb1ViNYfSeGKp+yvmyLY+RebOKQlvYg8Jgne8oijfE7W85Ee@lists.postgresql.org X-Gm-Message-State: AOJu0YyxmkguJr7GJkH90M+Dt6qkTUSy753/yLJU8BCNask74Nu5LZ5K NG7SsY8ZkDY8gbOFFWXvjNZTSq6n2vnigpUpF0/9czsXB7NeMjA8UyyfeN1XQWuvM+uTGqeqxOq jFse1ZdcMfrxBth+Z+eayonuNo8z6/HA3I2iJ/irr X-Gm-Gg: ASbGncsfa+FivU2qVM8cEs4sz4/ZVRq0VOQfqBUpzxF5IxxU+VfeIMWFkn2zxKdWIjf 18jWra1KsMzzm3svBorTg5ueCGdyTARt4xzr57uv9KzQw7rIXuldpbqCAhE40z4wgDdgLnsYC4m 1wEBMblooEkKAOb18oNNMyft9LxWFUBGtFTIFT4LUM6jbXptrkUMD4zkTF9ctMDssjH/9RxyuAm zf9N5GXFdTaYfPj8b5ZalFZ3jQnxx8EfH4D5jFWBGP6OOJDOoJVHX2qlmhcU861nzEg4DAm X-Google-Smtp-Source: AGHT+IGIs3M3kWPpg73H5IbOlWBFUrhlyfkW1NjUa9uUi9epFO7RhWZNcR4mJ92ZKCd8OLe05Lu4v2tuUCwK59T0Vj4= X-Received: by 2002:a05:6402:2755:b0:641:3d64:b120 with SMTP id 4fb4d7f45d1cf-6491a432356mr7376159a12.18.1765213751677; Mon, 08 Dec 2025 09:09:11 -0800 (PST) MIME-Version: 1.0 References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net> <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net> <20250824010811.4d.nmisch@google.com> <82eb35b8-7f07-493b-b689-0934919e1dc3@dunslane.net> <17555e46-4fb2-4265-90e0-95cb8ed584a6@dunslane.net> In-Reply-To: From: tushar Date: Mon, 8 Dec 2025 22:39:00 +0530 X-Gm-Features: AQt7F2qM0gjQ2ecLOUIb5pqLMwP1hvBZfbAVj1p0G2CoIcQ5HcEK48aUkAioITQ Message-ID: Subject: Re: Non-text mode for pg_dumpall To: Mahendra Singh Thalor Cc: Vaibhav Dalvi , pgsql-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="0000000000009f273a064573daea" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000009f273a064573daea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 8, 2025 at 12:14=E2=80=AFPM Mahendra Singh Thalor wrote: > > I tried to fix these issues in the attached patch. > > Here, I am attaching an updated patch for the review and testing. > Thanks Mahendra, I am not able to apply the patche against the latest sources, seems like you need to rebase it [edb@1a1c15437e7c pg]$ git apply /tmp/v11_08122025-Non-text-modes-for-pg_dumpall-correspondingly-change.patc= h error: patch failed: src/bin/pg_dump/pg_dumpall.c:419 error: src/bin/pg_dump/pg_dumpall.c: patch does not apply error: patch failed: src/bin/pg_dump/pg_restore.c:409 error: src/bin/pg_dump/pg_restore.c: patch does not apply [edb@1a1c15437e7c pg]$ regards, --0000000000009f273a064573daea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Dec 8, = 2025 at 12:14=E2=80=AFPM Mahendra Singh Thalor <mahi6run@gmail.com> wrote:

I tried to fix these issues in the attached patch.

Here, I am attaching an updated patch for the review and testing.

Thanks Mahendra, I am not able to apply the patc= he against the latest sources, seems like you need to rebase it
=
[edb@1a1c15437e7c pg]$ git apply /tmp/v11_08122025-Non-text-= modes-for-pg_dumpall-correspondingly-change.patch
error: patch failed: = src/bin/pg_dump/pg_dumpall.c:419
error: src/bin/pg_dump/pg_dumpall.c: pa= tch does not apply
error: patch failed: src/bin/pg_dump/pg_restore.c:409=
error: src/bin/pg_dump/pg_restore.c: patch does not apply
[edb@1a1c1= 5437e7c pg]$=C2=A0

regards,
--0000000000009f273a064573daea--