MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net>
 <fd25e8b7-9538-4e44-90e5-8a357ac03eff@dunslane.net>
 <20250824010811.4d.nmisch@google.com>
 <82eb35b8-7f07-493b-b689-0934919e1dc3@dunslane.net>
 <CAKYtNAr+OMjcGKwd+AgWA+s=8EWGtg5PkVV3O7X6d3eCv=MUeQ@mail.gmail.com>
 <CAKYtNApzLLeCqt5fHDzZOTnzCdCnBt3Y_fytFmJ0LMNHDPY-yA@mail.gmail.com>
 <CAKYtNArSYJdjez541C0qPZ9R3_yzPDpScAd=-RU4kPRCJh4viQ@mail.gmail.com>
 <CAKYtNArGUTzrfTBxpftL_yAgkKE+hcDgXVfQvjB2HFO9rGhE5g@mail.gmail.com>
 <CA+vB=AEQc3Xqz+KMh35Zsa-SsRP-n=HXGT4RwwNou4-__Prx+A@mail.gmail.com>
 <CAKYtNAqJqDmKcqCzpHg2SO=2MTxvE7rOWCACsoWsO7520tUWKw@mail.gmail.com>
 <CA+vB=AE9ypeQV-hhXscJ6T75BrAFfZh56GX_eM=eVG2n1o_Beg@mail.gmail.com>
 <CA+vB=AGsn4eUxsbLk_oy=iKzd8D_1Ne375XH-2u6Zncu72Q01Q@mail.gmail.com>
 <CAKYtNAqQ5LHWNWyaeVOJaS=2xDJovfv9GShTBzf8_5s=jH7wsg@mail.gmail.com>
 <CAKYtNAoSTBqR24cn3XDOnwk2DCL+nAUkjpB5Xkz1H74rDqa-aQ@mail.gmail.com>
 <17555e46-4fb2-4265-90e0-95cb8ed584a6@dunslane.net>
 <CAKYtNAoz9JZC+-Uo4QsA1O0PkEehxhTFy1y3HJjqzv6jwrXvCQ@mail.gmail.com>
 <CA+vB=AETksQZpjyBosrZv6N5A6DjaCtMQop3+MB8GDj0XnYoxQ@mail.gmail.com>
 <CAKYtNAoEUvYEG207zaGY0pEh6TB2sk6hpuz9LdG-fYEC=e2CgQ@mail.gmail.com>
 <CAKYtNAppx6y7M+9Fb5+TtTNhRS6onZo9kHeQS6yQF7PiK6qnEA@mail.gmail.com>
 <CAC6VRoZie9-iC9gWcJs3QGx=2_tA34fMBmj7Ck0VAP2JpDJGug@mail.gmail.com>
In-Reply-To: 
 <CAC6VRoZie9-iC9gWcJs3QGx=2_tA34fMBmj7Ck0VAP2JpDJGug@mail.gmail.com>
From: tushar <tushar.ahuja@enterprisedb.com>
Date: Mon, 1 Dec 2025 22:47:17 +0530
Message-ID: 
 <CAC6VRoZHZWzHZ0Oh++WW=9Q83co4AyG6u4+7HVi1gJiuv1CZ2g@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000006b4d8c0644e72745"
Archived-At: 
 <https://www.postgresql.org/message-id/CAC6VRoZHZWzHZ0Oh%2B%2BWW%3D9Q83co4AyG6u4%2B7HVi1gJiuv1CZ2g%40mail.gmail.com>
Precedence: bulk

--0000000000006b4d8c0644e72745
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 1, 2025 at 6:36=E2=80=AFPM tushar <tushar.ahuja@enterprisedb.co=
m> wrote:

>
>
> On Thu, Nov 27, 2025 at 2:49=E2=80=AFPM Mahendra Singh Thalor <mahi6run@g=
mail.com>
> wrote:
>
>>
>> Fixed. Here, I am attaching an updated patch for the review and testing.
>>
>
> Thanks Mahendra, please refer this scenario where restoring the
> dump(database contain tablespace) throwing an error
>
> *Steps to reproduce *
> initdb (./initdb -D data) , start the server ( ./pg_ctl -D data start) ,
> connect to psql terminal ( ./psql postgres)
> create a directory ( \! mkdir /tmp/abc) , create a tablespace ( create
> tablespace a location '/tmp/abc'); )
> create a table ( create table t(n int) tablespace a; ) , insert data (
> insert into t values ('a');  )
> perform pg_dumpall with option -c  ( ./pg_dumpall -Fc -f my.d)
> try to perform pg_restore with option --no-tablespaces  ( ./pg_restore
> --no-tablespaces -Fc my.d  -d postgres -C)
> Getting this error :
> "
> pg_restore: error: could not execute query: ERROR:  role "edb" already
> exists
> Command was: CREATE ROLE edb;
> ALTER ROLE edb WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN
> REPLICATION BYPASSRLS;
>
> pg_restore: error: could not execute query: ERROR:  directory
> "/tmp/abc/PG_19_202511281" already in use as a tablespace
> Command was: CREATE TABLESPACE a OWNER edb LOCATION '/tmp/abc';
>
> pg_restore: warning: errors ignored on restore: 2
> "
>
>
I have observed that when combining the --globals-only option with certain
other switches during a pg_restore - operation fails silently.
The attempted restore does not execute, but no error message or warning is
displayed unless the --verbose option is also used.

--this will just run without any message but objects also not going to
create
./pg_restore -Fc ok31. -C -d postgres  -t mytable  --globals-only
./pg_restore -Fc ok31. -C -d postgres  -no-tablespace     --globals-only
./pg_restore -Fc ok31. -C -d postgres  -no-data  --globals-only

with --verbose
[edb@1a1c15437e7c bin]$ ./pg_restore -Fc ok31. -C -d postgres  -t myable
--globals-only -v
pg_restore: connecting to database for restore
pg_restore: executing SELECT pg_catalog.set_config('search_path', '',
false);
pg_restore: implied no-schema restore
pg_restore: database restoring skipped because option -g/--globals-only was
specified

we should probably add some message there.

regards,

--0000000000006b4d8c0644e72745
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Dec 1, =
2025 at 6:36=E2=80=AFPM tushar &lt;<a href=3D"mailto:tushar.ahuja@enterpris=
edb.com">tushar.ahuja@enterprisedb.com</a>&gt; wrote:<br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br=
></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr"=
>On Thu, Nov 27, 2025 at 2:49=E2=80=AFPM Mahendra Singh Thalor &lt;<a href=
=3D"mailto:mahi6run@gmail.com" target=3D"_blank">mahi6run@gmail.com</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Fixed. Here, I am attaching an updated patch for the review and testing.<br=
></blockquote><div><br></div><div>Thanks Mahendra, please refer this scenar=
io where restoring the dump(database contain tablespace) throwing an error=
=C2=A0</div><div><br></div><div><b>Steps to reproduce=C2=A0</b></div><div>i=
nitdb (./initdb -D data) , start the server ( ./pg_ctl -D data start) , con=
nect to psql terminal ( ./psql postgres)</div><div>create a directory ( \! =
mkdir /tmp/abc) , create a tablespace ( create tablespace a location &#39;/=
tmp/abc&#39;); )=C2=A0</div><div>create a table ( create table t(n int) tab=
lespace a; ) , insert data ( insert into t values (&#39;a&#39;);=C2=A0 )=C2=
=A0</div><div>perform=C2=A0pg_dumpall with option -c=C2=A0 (=C2=A0./pg_dump=
all -Fc -f my.d)</div><div>try to perform pg_restore with option --no-table=
spaces=C2=A0 (=C2=A0./pg_restore --no-tablespaces -Fc my.d =C2=A0-d postgre=
s -C)=C2=A0</div><div>Getting=C2=A0this error :</div><div>&quot;</div><div>=
pg_restore: error: could not execute query: ERROR: =C2=A0role &quot;edb&quo=
t; already exists<br>Command was: CREATE ROLE edb;<br>ALTER ROLE edb WITH S=
UPERUSER INHERIT CREATEROLE CREATEDB LOGIN REPLICATION BYPASSRLS;<br><br>pg=
_restore: error: could not execute query: ERROR: =C2=A0directory &quot;/tmp=
/abc/PG_19_202511281&quot; already in use as a tablespace<br>Command was: C=
REATE TABLESPACE a OWNER edb LOCATION &#39;/tmp/abc&#39;;<br><br>pg_restore=
: warning: errors ignored on restore: 2</div><div>&quot;</div><div><br></di=
v></div></div></blockquote><div>=C2=A0</div><div>I have observed that when =
combining the --globals-only option with certain other switches during a pg=
_restore - operation fails silently.</div><div>The attempted restore does n=
ot execute, but no error message or warning is displayed unless the --verbo=
se option is also used.</div><div><br></div><div>--this will just run witho=
ut any message but objects also not going to create=C2=A0=C2=A0</div><div>.=
/pg_restore -Fc ok31. -C -d postgres =C2=A0-t mytable=C2=A0 --globals-only=
=C2=A0</div><div><div>./pg_restore -Fc ok31. -C -d postgres =C2=A0-no-table=
space =C2=A0 =C2=A0 --globals-only</div><div>./pg_restore -Fc ok31. -C -d p=
ostgres =C2=A0-no-data =C2=A0--globals-only</div></div><div><br></div><div>=
with --verbose</div><div>[edb@1a1c15437e7c bin]$ ./pg_restore -Fc ok31. -C =
-d postgres =C2=A0-t myable=C2=A0 --globals-only -v<br>pg_restore: connecti=
ng to database for restore<br>pg_restore: executing SELECT pg_catalog.set_c=
onfig(&#39;search_path&#39;, &#39;&#39;, false);<br>pg_restore: implied no-=
schema restore<br>pg_restore: database restoring skipped because option -g/=
--globals-only was specified<br></div><div><br></div><div>we should probabl=
y add some message there.=C2=A0</div><div><br></div><div>regards,</div></di=
v></div>

--0000000000006b4d8c0644e72745--