MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <2bed001a-462c-42da-9a6b-3c7884502932@dunslane.net>
 <fd25e8b7-9538-4e44-90e5-8a357ac03eff@dunslane.net>
 <20250824010811.4d.nmisch@google.com>
 <82eb35b8-7f07-493b-b689-0934919e1dc3@dunslane.net>
 <CAKYtNAr+OMjcGKwd+AgWA+s=8EWGtg5PkVV3O7X6d3eCv=MUeQ@mail.gmail.com>
 <CAKYtNApzLLeCqt5fHDzZOTnzCdCnBt3Y_fytFmJ0LMNHDPY-yA@mail.gmail.com>
 <CAKYtNArSYJdjez541C0qPZ9R3_yzPDpScAd=-RU4kPRCJh4viQ@mail.gmail.com>
 <CAKYtNArGUTzrfTBxpftL_yAgkKE+hcDgXVfQvjB2HFO9rGhE5g@mail.gmail.com>
 <CA+vB=AEQc3Xqz+KMh35Zsa-SsRP-n=HXGT4RwwNou4-__Prx+A@mail.gmail.com>
 <CAKYtNAqJqDmKcqCzpHg2SO=2MTxvE7rOWCACsoWsO7520tUWKw@mail.gmail.com>
 <CA+vB=AE9ypeQV-hhXscJ6T75BrAFfZh56GX_eM=eVG2n1o_Beg@mail.gmail.com>
 <CA+vB=AGsn4eUxsbLk_oy=iKzd8D_1Ne375XH-2u6Zncu72Q01Q@mail.gmail.com>
 <CAKYtNAqQ5LHWNWyaeVOJaS=2xDJovfv9GShTBzf8_5s=jH7wsg@mail.gmail.com>
 <CAKYtNAoSTBqR24cn3XDOnwk2DCL+nAUkjpB5Xkz1H74rDqa-aQ@mail.gmail.com>
 <17555e46-4fb2-4265-90e0-95cb8ed584a6@dunslane.net>
 <CAKYtNAoz9JZC+-Uo4QsA1O0PkEehxhTFy1y3HJjqzv6jwrXvCQ@mail.gmail.com>
 <CA+vB=AETksQZpjyBosrZv6N5A6DjaCtMQop3+MB8GDj0XnYoxQ@mail.gmail.com>
 <CAKYtNAoEUvYEG207zaGY0pEh6TB2sk6hpuz9LdG-fYEC=e2CgQ@mail.gmail.com>
 <CAKYtNAppx6y7M+9Fb5+TtTNhRS6onZo9kHeQS6yQF7PiK6qnEA@mail.gmail.com>
In-Reply-To: 
 <CAKYtNAppx6y7M+9Fb5+TtTNhRS6onZo9kHeQS6yQF7PiK6qnEA@mail.gmail.com>
From: tushar <tushar.ahuja@enterprisedb.com>
Date: Mon, 1 Dec 2025 18:36:48 +0530
Message-ID: 
 <CAC6VRoZie9-iC9gWcJs3QGx=2_tA34fMBmj7Ck0VAP2JpDJGug@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="0000000000009c16550644e3a7b9"
Archived-At: 
 <https://www.postgresql.org/message-id/CAC6VRoZie9-iC9gWcJs3QGx%3D2_tA34fMBmj7Ck0VAP2JpDJGug%40mail.gmail.com>
Precedence: bulk

--0000000000009c16550644e3a7b9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 27, 2025 at 2:49=E2=80=AFPM Mahendra Singh Thalor <mahi6run@gma=
il.com>
wrote:

>
> Fixed. Here, I am attaching an updated patch for the review and testing.
>

Thanks Mahendra, please refer this scenario where restoring the
dump(database contain tablespace) throwing an error

*Steps to reproduce *
initdb (./initdb -D data) , start the server ( ./pg_ctl -D data start) ,
connect to psql terminal ( ./psql postgres)
create a directory ( \! mkdir /tmp/abc) , create a tablespace ( create
tablespace a location '/tmp/abc'); )
create a table ( create table t(n int) tablespace a; ) , insert data (
insert into t values ('a');  )
perform pg_dumpall with option -c  ( ./pg_dumpall -Fc -f my.d)
try to perform pg_restore with option --no-tablespaces  ( ./pg_restore
--no-tablespaces -Fc my.d  -d postgres -C)
Getting this error :
"
pg_restore: error: could not execute query: ERROR:  role "edb" already
exists
Command was: CREATE ROLE edb;
ALTER ROLE edb WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN REPLICATION
BYPASSRLS;

pg_restore: error: could not execute query: ERROR:  directory
"/tmp/abc/PG_19_202511281" already in use as a tablespace
Command was: CREATE TABLESPACE a OWNER edb LOCATION '/tmp/abc';

pg_restore: warning: errors ignored on restore: 2
"

regards,
Tushar
https://www.enterprisedb.com/

--0000000000009c16550644e3a7b9
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Nov 27,=
 2025 at 2:49=E2=80=AFPM Mahendra Singh Thalor &lt;<a href=3D"mailto:mahi6r=
un@gmail.com">mahi6run@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex"><br>
Fixed. Here, I am attaching an updated patch for the review and testing.<br=
></blockquote><div><br></div><div>Thanks Mahendra, please refer this scenar=
io where restoring the dump(database contain tablespace) throwing an error=
=C2=A0</div><div><br></div><div><b>Steps to reproduce=C2=A0</b></div><div>i=
nitdb (./initdb -D data) , start the server ( ./pg_ctl -D data start) , con=
nect to psql terminal ( ./psql postgres)</div><div>create a directory ( \! =
mkdir /tmp/abc) , create a tablespace ( create tablespace a location &#39;/=
tmp/abc&#39;); )=C2=A0</div><div>create a table ( create table t(n int) tab=
lespace a; ) , insert data ( insert into t values (&#39;a&#39;);=C2=A0 )=C2=
=A0</div><div>perform=C2=A0pg_dumpall with option -c=C2=A0 (=C2=A0./pg_dump=
all -Fc -f my.d)</div><div>try to perform pg_restore with option --no-table=
spaces=C2=A0 (=C2=A0./pg_restore --no-tablespaces -Fc my.d =C2=A0-d postgre=
s -C)=C2=A0</div><div>Getting=C2=A0this error :</div><div>&quot;</div><div>=
pg_restore: error: could not execute query: ERROR: =C2=A0role &quot;edb&quo=
t; already exists<br>Command was: CREATE ROLE edb;<br>ALTER ROLE edb WITH S=
UPERUSER INHERIT CREATEROLE CREATEDB LOGIN REPLICATION BYPASSRLS;<br><br>pg=
_restore: error: could not execute query: ERROR: =C2=A0directory &quot;/tmp=
/abc/PG_19_202511281&quot; already in use as a tablespace<br>Command was: C=
REATE TABLESPACE a OWNER edb LOCATION &#39;/tmp/abc&#39;;<br><br>pg_restore=
: warning: errors ignored on restore: 2</div><div>&quot;</div><div><br></di=
v><div>regards,</div><div>Tushar=C2=A0</div><div><a href=3D"https://www.ent=
erprisedb.com/">https://www.enterprisedb.com/</a></div></div></div>

--0000000000009c16550644e3a7b9--