MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <CAKYtNAoz-Sz2X1ipkQ5x1Sh08AMyy1kDRGfeRW3P1W-QoN+WOg@mail.gmail.com>
 <CAC6VRoZU2L2GX7+bXpsZ6bo+NuxBOe1dTGDPzKobUL4KVdm46A@mail.gmail.com>
 <CAKYtNApq+6Riz26So1nmXkRpL_7o868+r6i=wxQ+AgGQ4oSLig@mail.gmail.com>
 <CAC6VRoZbP=-=a+a78RoWcs2L4=4VEDZqJMg+7SyUAcSHATyDAQ@mail.gmail.com>
 <CAC6VRoY-1WC_O5UDwKzNc18LXLwjuTFb+qMNY3gaF3cCov6M6g@mail.gmail.com>
 <CAKYtNArc3j8Akb+nB1QyJLKic7ej7vKZqKnv_mbB+iQAJRzLnA@mail.gmail.com>
 <CAC6VRoat6NPcS6vfGrPrwaQB3G1JHLSqDeAkf1AJ7npWrwhnUQ@mail.gmail.com>
 <CAKYtNAp=TFEZWQbTRZso3kNaD9BH=-JPNQ30mT60cJN_04hEog@mail.gmail.com>
 <4022765f-38ee-48a3-b246-615b3f8e1c23@dunslane.net> <CAKYtNAq73_UeL4-0wgu9rawctHdS2zhpzWtqVuOChCS3M+2Ymg@mail.gmail.com>
 <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com>
 <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net> <CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
 <CAKYtNAqxjQMLVPfz6XESqszhxZKgigi7UEBzBhz_Wj_Bnasdag@mail.gmail.com> <7faf3a59-cfe1-45cb-a972-55e05560b414@dunslane.net>
In-Reply-To: <7faf3a59-cfe1-45cb-a972-55e05560b414@dunslane.net>
From: jian he <jian.universality@gmail.com>
Date: Tue, 24 Feb 2026 15:21:50 +0800
Message-ID: <CACJufxE-zJiBAaZABtJBJr8FZdj=xP5adf_excmu9S6Op=KpLA@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, tushar <tushar.ahuja@enterprisedb.com>, 
	Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000dce5dc064b8cbf31"
Archived-At: <https://www.postgresql.org/message-id/CACJufxE-zJiBAaZABtJBJr8FZdj%3DxP5adf_excmu9S6Op%3DKpLA%40mail.gmail.com>
Precedence: bulk

--000000000000dce5dc064b8cbf31
Content-Type: text/plain; charset="UTF-8"

Hi.

For v19, the commit message
"""
pg_restore is extended to handle these pg_dumpall archives, restoring
globals and then each database. The --globals-only and --no-globals
options control which parts are restored.
"""
There is no --no-globals option.

In file src/bin/pg_dump/pg_dumpall.c, no need
``
static pg_compress_specification compression_spec = {0};
``
Since compression_spec is only used in an IF branch, we can declare it locally.


The options below are not supported for pg_restore non-text restore,
we can document this.
    <option>-a/--data-only</option>,
    <option>-l/--list</option>,
    <option>-L/--use-list</option>,
    <option>--statistics-only</option>,
    <option>--strict-names</option>,
    <option>--no-schema</option>.


--
jian
https://www.enterprisedb.com/

--000000000000dce5dc064b8cbf31
Content-Type: application/octet-stream; 
	name="v19-0001-misc-change-for-v19.no-cfbot"
Content-Disposition: attachment; 
	filename="v19-0001-misc-change-for-v19.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mm0a1mnz0>
X-Attachment-Id: f_mm0a1mnz0

RnJvbSA1NDYxNTIwZGVkZDEyNDA3NmY2ZTkzNzIxNDlkZTBmYzhkY2FjZGE0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFR1ZSwgMjQgRmViIDIwMjYgMTU6MTk6NDEgKzA4MDAKU3ViamVjdDogW1BBVENIIHYx
OSAxLzFdIG1pc2MgY2hhbmdlIGZvciB2MTkKCi0tLQogZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0
b3JlLnNnbWwgfCAxMCArKysrKysrKysrCiBzcmMvYmluL3BnX2R1bXAvcGdfZHVtcGFsbC5jICAg
ICB8ICA2ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVzdG9yZS5zZ21sIGIv
ZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKaW5kZXggZmY1MGZjMjM1MzkuLjQ3YWQy
NjYzMGViIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcmVmL3BnX3Jlc3RvcmUuc2dtbAorKysg
Yi9kb2Mvc3JjL3NnbWwvcmVmL3BnX3Jlc3RvcmUuc2dtbApAQCAtNjksNiArNjksMTYgQEAgUG9z
dGdyZVNRTCBkb2N1bWVudGF0aW9uCiAgICA8YXBwbGljYXRpb24+cGdfZHVtcDwvYXBwbGljYXRp
b24+IG9wdGlvbnMuCiAgIDwvcGFyYT4KIAorICAgPHBhcmE+CisgICAgUmVzdG9yaW5nIGZyb20g
YW4gYXJjaGl2ZSBjcmVhdGVkIGJ5IDxhcHBsaWNhdGlvbj5wZ19kdW1wYWxsPC9hcHBsaWNhdGlv
bj4gZG9lcyBub3Qgc3VwcG9ydCB0aGUgZm9sbG93aW5nIG9wdGlvbnM6CisgICAgPG9wdGlvbj4t
YS8tLWRhdGEtb25seTwvb3B0aW9uPiwKKyAgICA8b3B0aW9uPi1sLy0tbGlzdDwvb3B0aW9uPiwK
KyAgICA8b3B0aW9uPi1MLy0tdXNlLWxpc3Q8L29wdGlvbj4sCisgICAgPG9wdGlvbj4tLXN0YXRp
c3RpY3Mtb25seTwvb3B0aW9uPiwKKyAgICA8b3B0aW9uPi0tc3RyaWN0LW5hbWVzPC9vcHRpb24+
LAorICAgIDxvcHRpb24+LS1uby1zY2hlbWE8L29wdGlvbj4uCisgICA8L3BhcmE+CisKICAgPHBh
cmE+CiAgICBBIG5vbi1wbGFpbi10ZXh0IGFyY2hpdmUgbWFkZSB1c2luZyA8YXBwbGljYXRpb24+
cGdfZHVtcGFsbDwvYXBwbGljYXRpb24+CiAgICBpcyBhIGRpcmVjdG9yeSBjb250YWluaW5nIGEg
PGZpbGVuYW1lPnRvYy5nbG88L2ZpbGVuYW1lPiBmaWxlIHdpdGggZ2xvYmFsCmRpZmYgLS1naXQg
YS9zcmMvYmluL3BnX2R1bXAvcGdfZHVtcGFsbC5jIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBh
bGwuYwppbmRleCA5MmQxMjE0YjQyMS4uYmRiZTUyY2ZlM2MgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4v
cGdfZHVtcC9wZ19kdW1wYWxsLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBhbGwuYwpA
QCAtMTM1LDcgKzEzNSw2IEBAIHN0YXRpYyBTaW1wbGVTdHJpbmdMaXN0IGRhdGFiYXNlX2V4Y2x1
ZGVfbmFtZXMgPSB7TlVMTCwgTlVMTH07CiAKIHN0YXRpYyBjaGFyICpyZXN0cmljdF9rZXk7CiBz
dGF0aWMgQXJjaGl2ZSAqZm91dCA9IE5VTEw7Ci1zdGF0aWMgcGdfY29tcHJlc3Nfc3BlY2lmaWNh
dGlvbiBjb21wcmVzc2lvbl9zcGVjID0gezB9Owogc3RhdGljIGludAlkdW1wSWRWYWwgPSAwOwog
c3RhdGljIEFyY2hpdmVGb3JtYXQgYXJjaER1bXBGb3JtYXQgPSBhcmNoTnVsbDsKIHN0YXRpYyBj
b25zdCBDYXRhbG9nSWQgbmlsQ2F0YWxvZ0lkID0gezAsIDB9OwpAQCAtNjU2LDYgKzY1NSw3IEBA
IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKIAkJUFFFeHBCdWZmZXIgcXJ5ID0gY3JlYXRl
UFFFeHBCdWZmZXIoKTsKIAkJY2hhcgkJZ2xvYmFsX3BhdGhbTUFYUEdQQVRIXTsKIAkJY29uc3Qg
Y2hhciAqZW5jbmFtZTsKKwkJcGdfY29tcHJlc3Nfc3BlY2lmaWNhdGlvbiBjb21wcmVzc2lvbl9z
cGVjID0gezB9OwogCiAJCS8qCiAJCSAqIENoZWNrIHRoYXQgbm8gZ2xvYmFsIG9iamVjdCBuYW1l
cyBjb250YWluIG5ld2xpbmVzIG9yIGNhcnJpYWdlCkBAIC0xMTk0LDcgKzExOTQsOSBAQCBkdW1w
Um9sZXMoUEdjb25uICpjb25uKQogCQlpZiAoYXJjaER1bXBGb3JtYXQgPT0gYXJjaE51bGwpCiAJ
CXsKIAkJCWZwcmludGYoT1BGLCAiJXMiLCBidWYtPmRhdGEpOwotCQkJZnByaW50ZihPUEYsICIl
cyIsIGNvbW1lbnRfYnVmLT5kYXRhKTsKKworCQkJaWYgKGNvbW1lbnRfYnVmLT5kYXRhWzBdICE9
ICdcMCcpCisJCQkJZnByaW50ZihPUEYsICIlcyIsIGNvbW1lbnRfYnVmLT5kYXRhKTsKIAogCQkJ
aWYgKHNlY2xhYmVsX2J1Zi0+ZGF0YVswXSAhPSAnXDAnKQogCQkJCWZwcmludGYoT1BGLCAiJXMi
LCBzZWNsYWJlbF9idWYtPmRhdGEpOwotLSAKMi4zNC4xCgo=
--000000000000dce5dc064b8cbf31--