MIME-Version: 1.0
References: <E74C57FA-1DD0-4C8E-8FB1-538034752592@gmail.com>
 <CACJufxGRkCSqqRwd+3MMVFbosKXHv=Jc+KyGK+NM3YAHN7eu+g@mail.gmail.com>
 <DCE683F9-CEBF-4EDE-81D1-5E59CCD5CF82@gmail.com>
 <cb4a41fd-67e8-47ed-bcff-d0549dce3f02@app.fastmail.com>
 <33E9C4C2-B6A8-4FCC-BEEA-461EA5FB98C8@gmail.com>
 <CACJufxGxY=1mxcNz8-bjp6R+ZoCRE3O7DYt2ZqObv-Le+aMOqw@mail.gmail.com>
 <7F0EA98A-6DBC-436A-8FF4-4A511A05ABE6@gmail.com>
 <CACJufxFwJH5K1jgL1ryckYX8gxp1sfqz_2ypey1sYtWZ5u45oQ@mail.gmail.com>
 <ahgAsvfSt3kbw88l@alvherre.pgsql>
 <7B7172F4-DB02-4259-997B-6AEF5ADF7FCE@gmail.com>
 <CACJufxHbVuY683j3DHEU4LSswo8DTzLJbTvhv2Uj6gqN8pJs7Q@mail.gmail.com>
 <14E223D8-8425-446A-A36C-6B62BC334656@gmail.com>
 <9A3D388C-1DF4-4C43-9AB6-83529A8F48C8@gmail.com>
 <CACJufxGgSKFGWja=JPv3-zq3whON5cESLp7Z5=OsYvZOaRGnGw@mail.gmail.com>
 <E6956B70-35FF-474D-9F53-FC6E1BD8D9C0@gmail.com>
 <CAN4CZFOOhDAWdnY1OXB1wfG_=C4g_dw0gC2HCApz_3F7EFpqJA@mail.gmail.com>
 <92CAD935-5ECE-46D8-B7D7-D8E3C991CC10@gmail.com>
 <CAN4CZFNjnR-7hPBO=v=9h4CdDogUueYoPqpPvR9k3X5Z9-=+TA@mail.gmail.com>
 <684DCC2F-5982-4A5D-93F9-BD640B58B4BB@gmail.com>
 <CAN4CZFPkeF+=sk9KxxncuzGb-Q2NsMG4zoUgff-TiHeEdzwU+w@mail.gmail.com>
 <AF248D33-FFE4-480F-A543-DD31621A5AD7@gmail.com>
In-Reply-To: <AF248D33-FFE4-480F-A543-DD31621A5AD7@gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Mon, 8 Jun 2026 18:28:55 +0800
Message-ID: 
 <CACJufxE2B6nrfV9inubVifY-8Y6hObBAtyXHEAtPLA6JATXjgA@mail.gmail.com>
Subject: Re: Fix bug of CHECK constraint enforceability recursion
To: Chao Li <li.evan.chao@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000083d2480653bb7c7a"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxE2B6nrfV9inubVifY-8Y6hObBAtyXHEAtPLA6JATXjgA%40mail.gmail.com>
Precedence: bulk

--00000000000083d2480653bb7c7a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 6, 2026 at 11:06=E2=80=AFAM Chao Li <li.evan.chao@gmail.com> wr=
ote:
>
> PFA v8: 0001 and 0003 unchanged. 0002  addressed Zsolt=E2=80=99s comment.
>

drop table root_t cascade;
create table root_t (a int constraint c check (a > 0) enforced);
create table p2 (a int constraint c check (a > 0) enforced);
create table d () inherits (root_t, p2);
create table e () inherits (d);
CREATE OR REPLACE PROCEDURE create_table(i int) AS $$
DECLARE
  r int;
  query text;
BEGIN
    FOR i IN 20..$1 LOOP
        query :=3D 'create table f' || i || '() inherits (e)';
        raise notice 'query: %', query;
        EXECUTE query;
    END LOOP;
END; $$ LANGUAGE plpgsql;

call create_table(1000);
alter table root_t alter constraint c not enforced;

ATCheckCheckConstrHasEnforcedParent invoked 996070 times
ATCheckCheckConstrHasEnforcedParent will call itself, so I think we
need check_stack_depth() on it.

I also made a minor refactoring to reduce unnecessary work in
ATCheckCheckConstrHasEnforcedParent().
A single call to table_open(parentoid, ...) is enough.

Keep errmsg() messages on a single line to improve grepability.


--
jian
https://www.enterprisedb.com/

--00000000000083d2480653bb7c7a
Content-Type: application/octet-stream;
	name="v8-0001-Minor-refactoring-for-v8.nocfbot"
Content-Disposition: attachment;
	filename="v8-0001-Minor-refactoring-for-v8.nocfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mq52hpb80>
X-Attachment-Id: f_mq52hpb80

RnJvbSA3YzliOWQyNjIxOTFhMjY2NzAyMzA1OTJjY2ViOGM2YzE3ZGQ1Nzc1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IE1vbiwgOCBKdW4gMjAyNiAxODoyMjo1NSArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjgg
MS8xXSBNaW5vciByZWZhY3RvcmluZyBmb3Igdjg6CgoqIEF2b2lkIHNvbWUgdW5uZWNlc3Nhcnkg
d29yayBpbiBBVENoZWNrQ2hlY2tDb25zdHJIYXNFbmZvcmNlZFBhcmVudCgpLgoqIEFkZCBjaGVj
a19zdGFja19kZXB0aCgpIHRvIEFUQ2hlY2tDaGVja0NvbnN0ckhhc0VuZm9yY2VkUGFyZW50KCks
IHNpbmNlIGl0J3MgcmVjdXJzaXZlLgoqIEtlZXAgZXJybXNnKCkgbWVzc2FnZXMgb24gYSBzaW5n
bGUgbGluZSB0byBpbXByb3ZlIGdyZXBhYmlsaXR5LgotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRz
L3RhYmxlY21kcy5jIHwgMTUgKysrKysrKy0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNl
cnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1h
bmRzL3RhYmxlY21kcy5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXgg
MzVhZmZmMzlkYTkuLmRhMjhlMGY4Y2I0IDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5k
cy90YWJsZWNtZHMuYworKysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYwpAQCAt
MTI3MjcsOCArMTI3MjcsNyBAQCBBVEV4ZWNBbHRlckNoZWNrQ29uc3RyRW5mb3JjZWFiaWxpdHko
TGlzdCAqKndxdWV1ZSwgQVRBbHRlckNvbnN0cmFpbnQgKmNtZGNvbiwKIAkJaWYgKCFyZWN1cnNp
bmcpCiAJCQllcmVwb3J0KEVSUk9SLAogCQkJCQllcnJjb2RlKEVSUkNPREVfSU5WQUxJRF9PQkpF
Q1RfREVGSU5JVElPTiksCi0JCQkJCWVycm1zZygiY2Fubm90IG1hcmsgaW5oZXJpdGVkIGNvbnN0
cmFpbnQgXCIlc1wiIGFzIE5PVCBFTkZPUkNFRCBiZWNhdXNlICIKLQkJCQkJCSAgICJtYXRjaGlu
ZyBjb25zdHJhaW50IG9uIHBhcmVudCB0YWJsZSBcIiVzXCIgaXMgRU5GT1JDRUQiLAorCQkJCQll
cnJtc2coImNhbm5vdCBtYXJrIGluaGVyaXRlZCBjb25zdHJhaW50IFwiJXNcIiBhcyBOT1QgRU5G
T1JDRUQgYmVjYXVzZSBtYXRjaGluZyBjb25zdHJhaW50IG9uIHBhcmVudCB0YWJsZSBcIiVzXCIg
aXMgRU5GT1JDRUQiLAogCQkJCQkJICAgTmFtZVN0cihjdXJyY29uLT5jb25uYW1lKSwKIAkJCQkJ
CSAgIGdldF9yZWxfbmFtZShlbmZvcmNlZF9wYXJlbnRvaWQpKSk7CiAKQEAgLTEyOTI5LDYgKzEy
OTI4LDggQEAgQVRDaGVja0NoZWNrQ29uc3RySGFzRW5mb3JjZWRQYXJlbnQoUmVsYXRpb24gY29u
cmVsLCBSZWxhdGlvbiByZWwsCiAJY3VycmNvbiA9IChGb3JtX3BnX2NvbnN0cmFpbnQpIEdFVFNU
UlVDVChjb250dXBsZSk7CiAJQXNzZXJ0KGN1cnJjb24tPmNvbnR5cGUgPT0gQ09OU1RSQUlOVF9D
SEVDSyk7CiAKKwljaGVja19zdGFja19kZXB0aCgpOworCiAJaWYgKGN1cnJjb24tPmNvbmluaGNv
dW50IDw9IDApCiAJCXJldHVybiBmYWxzZTsKIApAQCAtMTI5NDcsOCArMTI5NDgsMTAgQEAgQVRD
aGVja0NoZWNrQ29uc3RySGFzRW5mb3JjZWRQYXJlbnQoUmVsYXRpb24gY29ucmVsLCBSZWxhdGlv
biByZWwsCiAJCVN5c1NjYW5EZXNjIHBzY2FuOwogCQlTY2FuS2V5RGF0YSBwa2V5WzNdOwogCQlI
ZWFwVHVwbGUJcGFyZW50dHVwOworCQlSZWxhdGlvbglwYXJlbnRyZWw7CiAKIAkJcGFyZW50b2lk
ID0gKChGb3JtX3BnX2luaGVyaXRzKSBHRVRTVFJVQ1QoaW5oZXJpdHNUdXBsZSkpLT5pbmhwYXJl
bnQ7CisJCXBhcmVudHJlbCA9IHRhYmxlX29wZW4ocGFyZW50b2lkLCBBY2Nlc3NTaGFyZUxvY2sp
OwogCiAJCVNjYW5LZXlJbml0KCZwa2V5WzBdLAogCQkJCQlBbnVtX3BnX2NvbnN0cmFpbnRfY29u
cmVsaWQsCkBAIC0xMjk5MSwzMSArMTI5OTQsMjcgQEAgQVRDaGVja0NoZWNrQ29uc3RySGFzRW5m
b3JjZWRQYXJlbnQoUmVsYXRpb24gY29ucmVsLCBSZWxhdGlvbiByZWwsCiAJCQkJaWYgKCFyZWwt
PnJkX3JlbC0+cmVsaXNwYXJ0aXRpb24gJiYKIAkJCQkJbGlzdF9tZW1iZXJfb2lkKGNoYW5naW5n
X2NvbmlkcywgcGFyZW50Y29uLT5vaWQpKQogCQkJCXsKLQkJCQkJUmVsYXRpb24JcGFyZW50cmVs
OwogCQkJCQlPaWQJCQlwYXJlbnRfZW5mb3JjZWRfcGFyZW50b2lkID0gSW52YWxpZE9pZDsKIAot
CQkJCQlwYXJlbnRyZWwgPSB0YWJsZV9vcGVuKHBhcmVudG9pZCwgTm9Mb2NrKTsKLQogCQkJCQlp
ZiAoIUFUQ2hlY2tDaGVja0NvbnN0ckhhc0VuZm9yY2VkUGFyZW50KGNvbnJlbCwKIAkJCQkJCQkJ
CQkJCQkJCSBwYXJlbnRyZWwsCiAJCQkJCQkJCQkJCQkJCQkgcGFyZW50dHVwLAogCQkJCQkJCQkJ
CQkJCQkJIGNoYW5naW5nX2NvbmlkcywKIAkJCQkJCQkJCQkJCQkJCSAmcGFyZW50X2VuZm9yY2Vk
X3BhcmVudG9pZCkpCiAJCQkJCXsKLQkJCQkJCXRhYmxlX2Nsb3NlKHBhcmVudHJlbCwgTm9Mb2Nr
KTsKIAkJCQkJCWNvbnRpbnVlOwogCQkJCQl9Ci0KLQkJCQkJdGFibGVfY2xvc2UocGFyZW50cmVs
LCBOb0xvY2spOwogCQkJCX0KIAogCQkJCSplbmZvcmNlZF9wYXJlbnRvaWQgPSBwYXJlbnRvaWQ7
CiAJCQkJc3lzdGFibGVfZW5kc2Nhbihwc2Nhbik7CiAJCQkJc3lzdGFibGVfZW5kc2NhbihzY2Fu
KTsKIAkJCQl0YWJsZV9jbG9zZShpbmhyZWwsIEFjY2Vzc1NoYXJlTG9jayk7CisJCQkJdGFibGVf
Y2xvc2UocGFyZW50cmVsLCBBY2Nlc3NTaGFyZUxvY2spOwogCQkJCXJldHVybiB0cnVlOwogCQkJ
fQogCQl9CisJCXRhYmxlX2Nsb3NlKHBhcmVudHJlbCwgQWNjZXNzU2hhcmVMb2NrKTsKIAogCQlz
eXN0YWJsZV9lbmRzY2FuKHBzY2FuKTsKIAl9Ci0tIAoyLjM0LjEKCg==
--00000000000083d2480653bb7c7a--