Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFP8s-0053qB-0o for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Apr 2026 04:24:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFP8r-00BfXH-1N for pgsql-hackers@arkaria.postgresql.org; Wed, 22 Apr 2026 04:24:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFP8r-00BfX0-0P for pgsql-hackers@lists.postgresql.org; Wed, 22 Apr 2026 04:24:49 +0000 Received: from mail-vs1-xe32.google.com ([2607:f8b0:4864:20::e32]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wFP8o-00000002PiB-3hbE for pgsql-hackers@postgresql.org; Wed, 22 Apr 2026 04:24:48 +0000 Received: by mail-vs1-xe32.google.com with SMTP id ada2fe7eead31-60fa13bde2dso3255583137.3 for ; Tue, 21 Apr 2026 21:24:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776831885; cv=none; d=google.com; s=arc-20240605; b=CSyr2QmEisrYSKH6i78ESVWd25EoEWGc8LU6nilOVlNQEn1jZm9uxfCbj/RjkGKndT K3HjMVCUwrkFJwJubjIn+EI4UkigfRXbtLK4kS8kUmPs6svwykGC6t/9PPn5x0AE8Csu vJOcqEfWBYXDcVRwFIjLtyRty07WB918gEMtLX7g/GSovts6JmEpQoV3syT+/QXozuYn 0KP0a4sPGInFr7OP4sNCxamo6tYV5JtN5+ndO5jHkXWbTchiusYo8N3cqcKS8esBlodV +FelLTHw+14wPKKcerkuJTFHqmzOq/bPP6HzY8NoxDZyr7VNP6XVIXORfjVD/4soj1sT Kwvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=7X9VbZ7ixqc/EOyWiMGyjQIApRP8KFvw553Pdjq73t8=; fh=vxkMwWiAl1nlnTiTXkTy0NAPor0uv3c7QOjkh32KRdQ=; b=gaiu7NyDRi9J0r+M9Fa8zs/nzGNT1CEcaWgpBMxW9wU2KodyAPoCIMOu3xqj0YGmvS M8VWuSa3xBLy3NDYRsksbSbLUgRGPcWqKBMiQBHiRy6wg74St8fpC076NYL4Q1xbG03W a1Fu+iWTOuhKwv3DTqPcoVI5hHdfktrE+wows2yDEB/Xgcsb9DKS7ZJsviIoyjX25B9V c3iTgrfIrjH7yWg/ahktnVysvR3LJg/rN9ITaPgrl1mYije7lPPZYhY7wZUUkyzvuJFL wESUfKNC9SHRjOH5CkLiI8tJlWjhgHO9Uz7C+YJcISUm4agzUU5kCooGVSo0/d1pbN85 r/TQ==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776831885; x=1777436685; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7X9VbZ7ixqc/EOyWiMGyjQIApRP8KFvw553Pdjq73t8=; b=c8rvXQNxpn2v0PdqrlwVmlqsdBSyCIXoNUZ/JjKM2y1eXVMyttyzuzDIjCjPiszndA FmpLfCXe5Bcfab/PvNJS96pA90flyAzHv6eaqzbvTaI6Q5SViXQn+qUDgZofkIqFzb3u /UrBPWg1WetF16UEqYbUWP5YQxP2tYEl1UtdHa25rxNuSJbvyLoJj39gRLhBXOmnVsna d6Kt3P59KjWCNqOqmhNsdL5YVoDFP4HrETxs30SkpxYk/f92eRVE95fwVYIxk8A7spst TOZ0zCSCHHMuAvmjAq7fhi+ESQDw0pTTy/Gg/Tk2EF/j63rvfkkGQrqoZJ0bAjCeidr9 Zoew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776831885; x=1777436685; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7X9VbZ7ixqc/EOyWiMGyjQIApRP8KFvw553Pdjq73t8=; b=EKLnvNLveIDRwf3qjkFhT2KbHlsrv2hbbCfVfhO9GGr0cpHg4Wej+vhON8713/hhTj 1TXbQ495MxiVdQ0xviHHMlipKU23dluNFMNWfcyuozXQNb75KDe5/HVWzB+6ts2OFcUM Ebzrs5VnxHXu2vnlia0xrYY8jEZYlUmWY6wXaR/eCb7qKiWHNp6Q7PovnUaslzSnYJXW RXDdzt0IKOixKi3R4hS9xzssYj0EhZQaFsEc0seX23bMkHjOGc5qXn0hjCNw/U2uYGTR RyyoOE4Z9eqF5ck4+PrbTxdTP+4Yy/ScNvIOaDpx/ra0101H5WPLakflU3JT+Csz/VcS Z21A== X-Forwarded-Encrypted: i=1; AFNElJ+jH2U5RiTbL8PLTKx5RkRfDsQJzLvz7P3lg8MSADx/KSlsPa6Rf6ZYFeswqmfKteHIfW4hyD7k5EsZSEvb@postgresql.org X-Gm-Message-State: AOJu0YyOm8X6O0W7kIEBiPoHdAW5zSEugj8MYMlPzeALszhO9dEvSs33 8bL6SrXRfIQFZf0F4Bvz7c6PxZi8BMWSeJcMeIveB7g/HYnnlHSLJDYqGHEtYUh+nTrsuZpeWjU eSvd0kxgMByqZyw5OiHETpbVQzQuyBaiRgTPADTc= X-Gm-Gg: AeBDievM7J6KUIVEpqw51HvYP3+c3N+hxO5o9XmU5S2oj3bZwylHgXiHCGCqy7HuxQc u5y0QtHXGO8t2I5oDkBvtJPDOkRF97/y90wlnygwJmAhJ0PbyVjXOS6Nk4cdpSKLZDV+xFne2Ub Gea+rvT9015dfD1BKNGtA/OeBSgJx8x10aCar8INeH4yfjJSaTY+mrM+XEmWRoZNb0wvAEgG62d Px2O/dW/SAlYlDCTSJHLoXPrhzn9LUG8v9Yjp/iOTmeOHtiRMrCb51P0qL+gG6/adkqpBr4JKjv vBQeFdT6aG+MFO0ZUzm84rdJh9ExdexMXrLIx0GIsRaWxV8hd0KrpJQqTz5uuw+NFivS+mFNDEL 4Lwxkvu7EuUYzSBoG9zm3j6SWnYL7qwMoUhbLt/4+WXrMxFnrGSW4Zq4TKJ+O5jcXSpJaK3PIYx 6jA+7f0uf7J2/D7TxMdj0uLgcl7F3W+OjZ X-Received: by 2002:a05:6102:441d:b0:611:6fef:905 with SMTP id ada2fe7eead31-616f750858emr10439189137.20.1776831885070; Tue, 21 Apr 2026 21:24:45 -0700 (PDT) MIME-Version: 1.0 References: <4bbd4e09-dc4a-400d-ae7a-7bea030acc39@yeah.net> In-Reply-To: <4bbd4e09-dc4a-400d-ae7a-7bea030acc39@yeah.net> From: jian he Date: Wed, 22 Apr 2026 12:24:08 +0800 X-Gm-Features: AQROBzAJkmkjUlTWm7DFuBRTDsO61Gov_sgmP3_9dHHgqcnw5MxUBQyods1rIWY Message-ID: Subject: Re: [PATCH] Remove dead code in ExecForPortionOfLeftovers() To: Quan Zongliang Cc: Aleksander Alekseev , PostgreSQL Development Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Apr 22, 2026 at 11:58=E2=80=AFAM Quan Zongliang wrote: > > > On 4/21/26 8:22 PM, Aleksander Alekseev wrote: > > Hi, > > > > While reading 8e72d914c528 I noticed that > > ForPortionOfState.fp_leftoverstypcache is not used for anything. I > > suggest removing it, as attached. > > > > Agree. > It indeed did not make any reference anywhere. > I raised this issue at [1]. But apparently, it's actually being used for fixing a bug at [2]. [1]: https://www.postgresql.org/message-id/CACJufxHYntqy2fo9CFWDDrqKjcMK8DG= RM3kse4YnXYnPYq2Hiw%40mail.gmail.com [2]: https://www.postgresql.org/message-id/CA%2BrenyU5%3Dmihx6O8%2BERBmarZc= uV1QiWB3X5bZhdptWoRM9G-Aw%40mail.gmail.com