MIME-Version: 1.0
References: <CAFj8pRCveWPR06bbad9GnMb0Kcr6jnXPttv9XOaOB+oFCD1Tsg@mail.gmail.com>
In-Reply-To: <CAFj8pRCveWPR06bbad9GnMb0Kcr6jnXPttv9XOaOB+oFCD1Tsg@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Thu, 1 Jan 2026 18:05:12 +0800
Message-ID: <CACJufxEOQ+2=L3aLBzW6A4vu75gN7vKw07+QgU_398Avqb5KTg@mail.gmail.com>
Subject: Re: not fully correct error message
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CACJufxEOQ%2B2%3DL3aLBzW6A4vu75gN7vKw07%2BQgU_398Avqb5KTg%40mail.gmail.com>
Precedence: bulk

On Thu, Jan 1, 2026 at 3:10=E2=80=AFPM Pavel Stehule <pavel.stehule@gmail.c=
om> wrote:
>
> Hi
>
> I tested one use case, and maybe I found little bit possible error messag=
e
>
> create procedure test()
> as $$
> begin
>   vacuum;
> end;
> $$ language plpgsql;
>
> (2026-01-01 08:04:05) postgres=3D# call test();
> ERROR:  25001: VACUUM cannot be executed from a function
> CONTEXT:  SQL statement "vacuum"
> PL/pgSQL function test() line 3 at SQL statement
> LOCATION:  PreventInTransactionBlock, xact.c:3695
> (2026-01-01 08:09:18) postgres=3D#
>
> should be "VACUUM cannot be executed from a function or a procedure" inst=
ead ?
>

hi.
"VACUUM cannot be executed from a function or a procedure"
looks good to me.

similarly, in ExecWaitStmt we have:
        ereport(ERROR,
                errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
                errmsg("WAIT FOR must be only called without an active
or registered snapshot"),
                errdetail("WAIT FOR cannot be executed from a function
or a procedure or within a transaction with an isolation level higher
than READ COMMITTED."));

PreventInTransactionBlock is used in so many places, but this error message=
:
``
(errmsg("%s cannot be executed from a function", stmtType)));
``
only appears once in the regress tests.
maybe we can add some dummy tests for it.