MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql> <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
 <CACJufxGcZ1rK94cgfdc9McCD7W-83PT9_cx5VoFeC-HVc10Wzg@mail.gmail.com>
 <CAKYtNAqd4k+4+XANxjDc35i+WPme476DkP7msjYpX85F+4UsUg@mail.gmail.com>
 <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
 <CACJufxEtDgADBXQhX5cp3mJtNVMy+j+Jdovuk3PWe5qJ0sE3Ag@mail.gmail.com>
 <CAKYtNArwUxqR=LkQY1PT7tw+raMhf53oafo4WmSHGPHiER9d=A@mail.gmail.com>
 <CACJufxHUDGWe=2ZukvMfuwEcSK8CsVYm=9+rtPnrW7CRCfoCsw@mail.gmail.com>
 <CACJufxGOy1kAot+SAD9siKB797rj9K-bqeZOrS4fDYFFLo31bA@mail.gmail.com>
 <CAKYtNApE=x0sZxU3c9KqsYRU3dCztcfhQ+CDWhzgtH83HQUkuA@mail.gmail.com>
 <CACJufxHNNjAhVYJQS8x5U-9Fqsj6+tzG4uCivk2XTAOPTmstTA@mail.gmail.com>
 <CACJufxFJ9yJ=+WAHpXbDxf077Xw3O+ZziTwS55+ZK5APJ+6mUg@mail.gmail.com>
 <CACJufxEA-Q2hatN_BLcNrgfo8-4-m102gDdwVp0NTbuM2zyeDA@mail.gmail.com>
 <CAKYtNAqWjU6-J=VA-9-CVDLh7nX_Y_MgdSgyLFb6yYyZ1NYsyg@mail.gmail.com>
 <CACJufxEFxaiqytZRpL0Xbj8_XEtTm8-A2FE6u_9vigGO3z5oZQ@mail.gmail.com>
 <CAKYtNAr732dgvu43vLRBnDK=dPBVWAFBKaCp0982kwp0Yn8DOA@mail.gmail.com> <CACJufxGwXjG80LZ4miX+dXaT+3z5Kf1Mf0P_7FnR+641oqfUyg@mail.gmail.com>
In-Reply-To: <CACJufxGwXjG80LZ4miX+dXaT+3z5Kf1Mf0P_7FnR+641oqfUyg@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Sun, 26 Jan 2025 22:46:45 +0800
Message-ID: <CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Guillaume Lelarge <guillaume@lelarge.info>, 
	Nathan Bossart <nathandbossart@gmail.com>, Magnus Hagander <magnus@hagander.net>, 
	Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>
Content-Type: multipart/mixed; boundary="00000000000094f20d062c9d0997"
Archived-At: <https://www.postgresql.org/message-id/CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ%40mail.gmail.com>
Precedence: bulk

--00000000000094f20d062c9d0997
Content-Type: text/plain; charset="UTF-8"

hi.
attached patching trying to refactor ReadOneStatement
for properly handling the single and double quotes.
the commit message also has some tests on it.

it is based on your
v11_pg_dumpall-with-directory-tar-custom-format-21-jan.patch.

--00000000000094f20d062c9d0997
Content-Type: application/octet-stream; 
	name="v11-0001-refactoring-ReadOneStatement.no-cfbot"
Content-Disposition: attachment; 
	filename="v11-0001-refactoring-ReadOneStatement.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_m6dqcvnh0>
X-Attachment-Id: f_m6dqcvnh0

RnJvbSAxMWMxZjM4NDEzNDE1ZjU4MmMwNTk2ZmY3NDVlNGNiZmIxODQ4MTI2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFN1biwgMjYgSmFuIDIwMjUgMjI6MzY6MjggKzA4MDAKU3ViamVjdDogW1BBVENIIHYx
MSAxLzFdIHJlZmFjdG9yaW5nIFJlYWRPbmVTdGF0ZW1lbnQgZXNjYXBlIHNpbmdsZSBxdW90ZSBh
bmQKIGRvdWJsZSBxdW90ZSBmb3IgUmVhZE9uZVN0YXRlbWVudC4KCnRoZSBmb2xsb3dpbmcgYXJl
IHNvbWUgdGVzdHMgdG8gcHJvdmUgaXQgYWNjdXJhdGUuCgpjcmVhdGUgcm9sZSB5Owpjb21tZW50
IG9uIHJvbGUgeSBpcyAkJDsiJyQkOwpjcmVhdGUgcm9sZSAiJyI7CmNyZWF0ZSByb2xlICInJzsi
OwpjcmVhdGUgcm9sZSAiJzs7Oyc7IjsKY3JlYXRlIHJvbGUgejsKY29tbWVudCBvbiByb2xlIHog
aXMgJCQiIjsnOyQkOwoKY3JlYXRlIHJvbGUgIjsKJzsKOwoiOwpjcmVhdGUgcm9sZSAiOyI7CmNv
bW1lbnQgb24gcm9sZSAiOyIgaXMgJCQ7Iic7JywiLCcgJCQ7CmNvbW1lbnQgb24gcm9sZSAiOyIg
aXMgJCQ7Iic7JywiLCcKCiQkOwoKY3JlYXRlIHJvbGUgIgoKIjsKY29tbWVudCBvbiByb2xlIHog
aXMgJCQ7Iic7JywiLCcnOzsnIiI7JCQ7Ci0tLQogc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUu
YyB8IDQ5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLQogMSBmaWxlIGNoYW5n
ZWQsIDQxIGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Jp
bi9wZ19kdW1wL3BnX3Jlc3RvcmUuYyBiL3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMKaW5k
ZXggNzlmNjEzOTVhZS4uNjUwMjllY2I3NiAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ19kdW1wL3Bn
X3Jlc3RvcmUuYworKysgYi9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCkBAIC03NjQsNiAr
NzY0LDEwIEBAIHN0YXRpYyBpbnQKIFJlYWRPbmVTdGF0ZW1lbnQoU3RyaW5nSW5mbyBpbkJ1Ziwg
RklMRSAqcGZpbGUpCiB7CiAJaW50CQkJYzsgLyogY2hhcmFjdGVyIHJlYWQgZnJvbSBnZXRjKCkg
Ki8KKwlpbnQJCQltOworCisJU3RyaW5nSW5mb0RhdGEJcTsKKwlpbml0U3RyaW5nSW5mbygmcSk7
CiAKIAlyZXNldFN0cmluZ0luZm8oaW5CdWYpOwogCkBAIC03NzIsMTYgKzc3Niw0NCBAQCBSZWFk
T25lU3RhdGVtZW50KFN0cmluZ0luZm8gaW5CdWYsIEZJTEUgKnBmaWxlKQogCSAqLwogCXdoaWxl
ICgoYyA9IGZnZXRjKHBmaWxlKSkgIT0gRU9GKQogCXsKLQkJYXBwZW5kU3RyaW5nSW5mb0NoYXIo
aW5CdWYsIChjaGFyKSBjKTsKKwkJaWYgKGMgIT0gJ1wnJyAmJiBjICE9ICciJyAmJiBjICE9ICdc
bicgJiYgYyAhPSAnOycpCisJCXsKKwkJCWFwcGVuZFN0cmluZ0luZm9DaGFyKGluQnVmLCAoY2hh
cikgYyk7CisJCQl3aGlsZSAoKGMgPSBmZ2V0YyhwZmlsZSkpICE9IEVPRikKKwkJCXsKKwkJCQlp
ZiAoYyAhPSAnXCcnICYmIGMgIT0gJyInICYmIGMgIT0gJzsnICYmIGMgIT0gJ1xuJykKKwkJCQkJ
YXBwZW5kU3RyaW5nSW5mb0NoYXIoaW5CdWYsIChjaGFyKSBjKTsKKwkJCQllbHNlCisJCQkJCWJy
ZWFrOworCQkJfQorCQl9CisKKwkJaWYgKGMgPT0gJ1wnJyB8fCBjID09ICciJykKKwkJeworCQkJ
YXBwZW5kU3RyaW5nSW5mb0NoYXIoJnEsIChjaGFyKSBjKTsKKwkJCW0gPSBjOworCisJCQl3aGls
ZSAoKGMgPSBmZ2V0YyhwZmlsZSkpICE9IEVPRikKKwkJCXsKKwkJCQlhcHBlbmRTdHJpbmdJbmZv
Q2hhcigmcSwgKGNoYXIpIGMpOworCisJCQkJaWYoIGMgPT0gbSkKKwkJCQl7CisJCQkJCWFwcGVu
ZFN0cmluZ0luZm9TdHJpbmcoaW5CdWYsIHEuZGF0YSk7CisJCQkJCXJlc2V0U3RyaW5nSW5mbygm
cSk7CisJCQkJCWJyZWFrOworCQkJCX0KKwkJCX0KKwkJfQorCisJCWlmIChjID09ICc7JykKKwkJ
eworCQkJYXBwZW5kU3RyaW5nSW5mb0NoYXIoaW5CdWYsIChjaGFyKSBjKTsKKwkJCWJyZWFrOwor
CQl9CiAKIAkJaWYgKGMgPT0gJ1xuJykKLQkJewotCQkJaWYoaW5CdWYtPmxlbiA+IDEgJiYKLQkJ
CQkJaW5CdWYtPmRhdGFbaW5CdWYtPmxlbiAtIDJdID09ICc7JykKLQkJCQlicmVhazsKLQkJCWVs
c2UKLQkJCQljb250aW51ZTsKLQkJfQorCQkJYXBwZW5kU3RyaW5nSW5mb0NoYXIoaW5CdWYsIChj
aGFyKSBjKTsKIAl9CiAKIAkvKiBObyBpbnB1dCBiZWZvcmUgRU9GIHNpZ25hbCBtZWFucyB0aW1l
IHRvIHF1aXQuICovCkBAIC0xMTEzLDYgKzExNDUsNyBAQCBleGVjdXRlX2dsb2JhbF9zcWxfY29t
bWFuZHMoUEdjb25uICpjb25uLCBjb25zdCBjaGFyICpkdW1wZGlycGF0aCwgY29uc3QgY2hhciAq
bwogCS8qIFByb2Nlc3MgZmlsZSB0aWxsIEVPRiBhbmQgZXhlY3V0ZSBzcWwgc3RhdGVtZW50cyAq
LwogCXdoaWxlIChSZWFkT25lU3RhdGVtZW50KCZzcWxzdGF0ZW1lbnQsIHBmaWxlKSAhPSBFT0Yp
CiAJeworCQlwZ19sb2dfaW5mbygiZXhlY3V0aW5nICVzIiwgc3Fsc3RhdGVtZW50LmRhdGEpOwog
CQlyZXN1bHQgPSBQUWV4ZWMoY29ubiwgc3Fsc3RhdGVtZW50LmRhdGEpOwogCiAJCXN3aXRjaCAo
UFFyZXN1bHRTdGF0dXMocmVzdWx0KSkKLS0gCjIuMzQuMQoK
--00000000000094f20d062c9d0997--