MIME-Version: 1.0
References: <20260427.174220.1939160662649810289.ishii@postgresql.org>
 <CAAAe_zBdwAUDNs_WFdLkFF=ewhkDkv-AqizVEVzhsfremGFb4w@mail.gmail.com>
 <20260502.140304.670813149418899420.ishii@postgresql.org>
 <20260505.090124.365339750969814137.ishii@postgresql.org>
In-Reply-To: <20260505.090124.365339750969814137.ishii@postgresql.org>
From: jian he <jian.universality@gmail.com>
Date: Tue, 5 May 2026 11:53:07 +0800
Message-ID: 
 <CACJufxEWL_ZnC-bs_yrg-Ys6ZUD3Ut_p1Ebj0bAcbzj67+HDAQ@mail.gmail.com>
Subject: Re: Row pattern recognition
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: assam258@gmail.com, zsolt.parragi@percona.com, sjjang112233@gmail.com,
	vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com,
	david.g.johnston@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com,
	pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxEWL_ZnC-bs_yrg-Ys6ZUD3Ut_p1Ebj0bAcbzj67%2BHDAQ%40mail.gmail.com>
Precedence: bulk

On Tue, May 5, 2026 at 8:02=E2=80=AFAM Tatsuo Ishii <ishii@postgresql.org> =
wrote:
>
> > Attached is the v47 patches for Row pattern recognition (SQL/RPR).
>

Hi
The patchset is too big, I only downloaded v47-0001...
Just a quick skim of the code on my end.
I noticed two code style issues, currently we don't have a code style
reference in the manual.

1. We need to add trailing commas to enum definitions. See
https://git.postgresql.org/cgit/postgresql.git/commit/?id=3D611806cd726fc92=
989ac918eac48fd8d684869c7

2.
+ | '{' ',' Iconst '}' Op
+ {
+ if (strcmp($5, "?") !=3D 0)
+ ereport(ERROR,
+ (errcode(ERRCODE_SYNTAX_ERROR),
+ errmsg("invalid token after range quantifier"),
+ errhint("Only \"?\" is allowed after {n,} or {,m} to make it reluctant.")=
,
+ parser_errposition(@5)));
+ if ($3 <=3D 0 || $3 >=3D INT_MAX)
+ ereport(ERROR,
+ errcode(ERRCODE_SYNTAX_ERROR),
+ errmsg("quantifier bound must be between 1 and %d", INT_MAX - 1),
+ parser_errposition(@3));
+ $$ =3D (Node *) makeRPRQuantifier(0, $3, @5, @1, yyscanner);

+ (errcode(ERRCODE_SYNTAX_ERROR),
The leading parenthesis is optional and can be removed, fewer
parentheses are always better.
See related discussion:
https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsql

Since v47-0001 introduces many ereport(ERROR) messages, it makes sense
to move the related regression tests from the other patch into
v47-0001, IMHO.


--
jian
https://www.enterprisedb.com/