MIME-Version: 1.0
References: <aibTqHShlL-DFSbG@alvherre.pgsql>
 <240CAFC9-8053-4660-A1D5-0CB2610AB257@gmail.com>
In-Reply-To: <240CAFC9-8053-4660-A1D5-0CB2610AB257@gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 17 Jun 2026 11:27:31 +0800
Message-ID: 
 <CACJufxEXyn_0RGBmULM4QQykSCh9wxXF-6wNnHo1pNefacPSag@mail.gmail.com>
Subject: Re: Fix bug of CHECK constraint enforceability recursion
To: Chao Li <li.evan.chao@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Zsolt Parragi <zsolt.parragi@percona.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000f117db06546aa501"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxEXyn_0RGBmULM4QQykSCh9wxXF-6wNnHo1pNefacPSag%40mail.gmail.com>
Precedence: bulk

--000000000000f117db06546aa501
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 9, 2026 at 8:32=E2=80=AFAM Chao Li <li.evan.chao@gmail.com> wro=
te:
>
> In v10, I split the =E2=80=9Cbecause=E2=80=9D part to a errdetail, also m=
oved out NOT ENFORCED out of the translate message.
>

ATCheckCheckConstrHasEnforcedParent
``````
            if (constraints_equivalent(parenttup, contuple,
                                       RelationGetDescr(conrel)))
            {
``````
The above IF condition is basically always true (see
MergeConstraintsIntoExisting), unless an inherited check constraint
has a
different definition, which should not happen.
So I did a quick refactor here, which also drops the nesting level down by =
one.

Other than that, v10 looks good to me.


--
jian
https://www.enterprisedb.com/

--000000000000f117db06546aa501
Content-Type: application/octet-stream;
	name="v10-0001-misc-refactor-ATCheckCheckConstrHasEnforcedParent.nocfbot"
Content-Disposition: attachment;
	filename="v10-0001-misc-refactor-ATCheckCheckConstrHasEnforcedParent.nocfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mqhif5gq0>
X-Attachment-Id: f_mqhif5gq0

RnJvbSA3N2ZhMzA1OWU2ZDZmZTU1MGQ1N2VmMDY3ZDBmZDc1MjczMTcxMDI5IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFdlZCwgMTcgSnVuIDIwMjYgMTE6MjI6MzcgKzA4MDAKU3ViamVjdDogW1BBVENIIHYx
MCAxLzFdIG1pc2MgcmVmYWN0b3IgQVRDaGVja0NoZWNrQ29uc3RySGFzRW5mb3JjZWRQYXJlbnQK
Ci0tLQogc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMgfCA2NCArKysrKysrKysrKysr
KysrLS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDMx
IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21k
cy5jIGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggOTFiMTYzZTVmOWMu
LjU5OWY3N2E3NzIwIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMu
YworKysgYi9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYwpAQCAtMTI5NTcsNDEgKzEy
OTU3LDQzIEBAIEFUQ2hlY2tDaGVja0NvbnN0ckhhc0VuZm9yY2VkUGFyZW50KFJlbGF0aW9uIGNv
bnJlbCwgUmVsYXRpb24gcmVsLAogCQkJCSFwYXJlbnRjb24tPmNvbmVuZm9yY2VkKQogCQkJCWNv
bnRpbnVlOwogCi0JCQlpZiAoY29uc3RyYWludHNfZXF1aXZhbGVudChwYXJlbnR0dXAsIGNvbnR1
cGxlLAotCQkJCQkJCQkJICAgUmVsYXRpb25HZXREZXNjcihjb25yZWwpKSkKKwkJCWlmICghY29u
c3RyYWludHNfZXF1aXZhbGVudChwYXJlbnR0dXAsIGNvbnR1cGxlLAorCQkJCQkJCQkJCVJlbGF0
aW9uR2V0RGVzY3IoY29ucmVsKSkpCisJCQkJZWxvZyhFUlJPUiwgImNoaWxkIHRhYmxlIFwiJXNc
IiBoYXMgZGlmZmVyZW50IGRlZmluaXRpb24gZm9yIGNoZWNrIGNvbnN0cmFpbnQgXCIlc1wiIiwK
KwkJCQkJIFJlbGF0aW9uR2V0UmVsYXRpb25OYW1lKHJlbCksCisJCQkJCSBOYW1lU3RyKHBhcmVu
dGNvbi0+Y29ubmFtZSkpOworCisJCQkvKgorCQkJICogQSBwYXJlbnQgbGlzdGVkIGluIGNoYW5n
aW5nX2NvbmlkcyBpcyBiZWluZyBjaGFuZ2VkIGJ5IHRoZSBzYW1lCisJCQkgKiBBTFRFUiwgYnV0
IGl0IG1heSBub3QgaGF2ZSBiZWVuIHVwZGF0ZWQgeWV0LiAgRm9yIHJlZ3VsYXIKKwkJCSAqIGlu
aGVyaXRhbmNlLCByZWN1cnNlIHVwd2FyZCB0byBjaGVjayB3aGV0aGVyIGFuIGVxdWl2YWxlbnQK
KwkJCSAqIGVuZm9yY2VkIHBhcmVudCBvdXRzaWRlIHRoZSBBTFRFUiB3aWxsIG1ha2UgaXQgcmVt
YWluIGVuZm9yY2VkLgorCQkJICogUGFydGl0aW9ucyBjYW5ub3QgaGF2ZSBtdWx0aXBsZSBwYXJl
bnRzLCBzbyB0aGV5IGRvIG5vdCBuZWVkCisJCQkgKiB0aGlzIGNoZWNrLgorCQkJICovCisJCQlp
ZiAoIXJlbC0+cmRfcmVsLT5yZWxpc3BhcnRpdGlvbiAmJgorCQkJCWxpc3RfbWVtYmVyX29pZChj
aGFuZ2luZ19jb25pZHMsIHBhcmVudGNvbi0+b2lkKSkKIAkJCXsKLQkJCQkvKgotCQkJCSAqIEEg
cGFyZW50IGxpc3RlZCBpbiBjaGFuZ2luZ19jb25pZHMgaXMgYmVpbmcgY2hhbmdlZCBieSB0aGUK
LQkJCQkgKiBzYW1lIEFMVEVSLCBidXQgaXQgbWF5IG5vdCBoYXZlIGJlZW4gdXBkYXRlZCB5ZXQu
ICBGb3IKLQkJCQkgKiByZWd1bGFyIGluaGVyaXRhbmNlLCByZWN1cnNlIHVwd2FyZCB0byBjaGVj
ayB3aGV0aGVyIGFuCi0JCQkJICogZXF1aXZhbGVudCBlbmZvcmNlZCBwYXJlbnQgb3V0c2lkZSB0
aGUgQUxURVIgd2lsbCBtYWtlIGl0Ci0JCQkJICogcmVtYWluIGVuZm9yY2VkLiAgUGFydGl0aW9u
cyBjYW5ub3QgaGF2ZSBtdWx0aXBsZSBwYXJlbnRzLAotCQkJCSAqIHNvIHRoZXkgZG8gbm90IG5l
ZWQgdGhpcyBjaGVjay4KLQkJCQkgKi8KLQkJCQlpZiAoIXJlbC0+cmRfcmVsLT5yZWxpc3BhcnRp
dGlvbiAmJgotCQkJCQlsaXN0X21lbWJlcl9vaWQoY2hhbmdpbmdfY29uaWRzLCBwYXJlbnRjb24t
Pm9pZCkpCi0JCQkJewotCQkJCQlPaWQJCQlwYXJlbnRfZW5mb3JjZWRfcGFyZW50b2lkID0gSW52
YWxpZE9pZDsKKwkJCQlPaWQJCQlwYXJlbnRfZW5mb3JjZWRfcGFyZW50b2lkID0gSW52YWxpZE9p
ZDsKIAotCQkJCQlpZiAocGFyZW50cmVsID09IE5VTEwpCi0JCQkJCQlwYXJlbnRyZWwgPSB0YWJs
ZV9vcGVuKHBhcmVudG9pZCwgTm9Mb2NrKTsKKwkJCQlpZiAocGFyZW50cmVsID09IE5VTEwpCisJ
CQkJCXBhcmVudHJlbCA9IHRhYmxlX29wZW4ocGFyZW50b2lkLCBOb0xvY2spOwogCi0JCQkJCWlm
ICghQVRDaGVja0NoZWNrQ29uc3RySGFzRW5mb3JjZWRQYXJlbnQoY29ucmVsLAotCQkJCQkJCQkJ
CQkJCQkJIHBhcmVudHJlbCwKLQkJCQkJCQkJCQkJCQkJCSBwYXJlbnR0dXAsCi0JCQkJCQkJCQkJ
CQkJCQkgY2hhbmdpbmdfY29uaWRzLAotCQkJCQkJCQkJCQkJCQkJICZwYXJlbnRfZW5mb3JjZWRf
cGFyZW50b2lkKSkKLQkJCQkJCWNvbnRpbnVlOwotCQkJCX0KLQotCQkJCSplbmZvcmNlZF9wYXJl
bnRvaWQgPSBwYXJlbnRvaWQ7Ci0JCQkJaWYgKHBhcmVudHJlbCAhPSBOVUxMKQotCQkJCQl0YWJs
ZV9jbG9zZShwYXJlbnRyZWwsIE5vTG9jayk7Ci0JCQkJc3lzdGFibGVfZW5kc2Nhbihwc2Nhbik7
Ci0JCQkJc3lzdGFibGVfZW5kc2NhbihzY2FuKTsKLQkJCQl0YWJsZV9jbG9zZShpbmhyZWwsIEFj
Y2Vzc1NoYXJlTG9jayk7Ci0JCQkJcmV0dXJuIHRydWU7CisJCQkJaWYgKCFBVENoZWNrQ2hlY2tD
b25zdHJIYXNFbmZvcmNlZFBhcmVudChjb25yZWwsCisJCQkJCQkJCQkJCQkJCSBwYXJlbnRyZWws
CisJCQkJCQkJCQkJCQkJCSBwYXJlbnR0dXAsCisJCQkJCQkJCQkJCQkJCSBjaGFuZ2luZ19jb25p
ZHMsCisJCQkJCQkJCQkJCQkJCSAmcGFyZW50X2VuZm9yY2VkX3BhcmVudG9pZCkpCisJCQkJCWNv
bnRpbnVlOwogCQkJfQorCisJCQkqZW5mb3JjZWRfcGFyZW50b2lkID0gcGFyZW50b2lkOworCQkJ
aWYgKHBhcmVudHJlbCAhPSBOVUxMKQorCQkJCXRhYmxlX2Nsb3NlKHBhcmVudHJlbCwgTm9Mb2Nr
KTsKKwkJCXN5c3RhYmxlX2VuZHNjYW4ocHNjYW4pOworCQkJc3lzdGFibGVfZW5kc2NhbihzY2Fu
KTsKKwkJCXRhYmxlX2Nsb3NlKGluaHJlbCwgQWNjZXNzU2hhcmVMb2NrKTsKKwkJCXJldHVybiB0
cnVlOwogCQl9CiAKIAkJaWYgKHBhcmVudHJlbCAhPSBOVUxMKQotLSAKMi4zNC4xCgo=
--000000000000f117db06546aa501--