MIME-Version: 1.0
References: 
 <CAHg+QDcd=t69gLf9yQexO07EJ2mx0Z70NFHo6h94X1EDA=hM0g@mail.gmail.com>
 <CACJufxGreOtA-S-qeHyS5iSSsj5zZX0W3Rf8FxbyL+SVXFjLYw@mail.gmail.com>
 <CAHg+QDeGLfz8YSCChjqrxaVSrz9AnMA0NrmsNogLqeGgCt7-wg@mail.gmail.com>
 <CA+renyWD+XXifwswE74vhjooqbiVKu4qVhLvpMcUQBzrjVjT7A@mail.gmail.com>
 <CACJufxHYntqy2fo9CFWDDrqKjcMK8DGRM3kse4YnXYnPYq2Hiw@mail.gmail.com>
 <CA+renyVp4rgj8x0ERXRkZp223eyBZ_XZr2RVCXvjzKBhTtS6Yw@mail.gmail.com>
In-Reply-To: 
 <CA+renyVp4rgj8x0ERXRkZp223eyBZ_XZr2RVCXvjzKBhTtS6Yw@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Tue, 21 Apr 2026 11:57:59 +0800
Message-ID: 
 <CACJufxEkomKYmWgqXJmQr_qS+z=BZ3w801eh7Z7ekh-3oHXxHQ@mail.gmail.com>
Subject: Re: FOR PORTION OF does not recompute GENERATED STORED columns that
 depend on the range column
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000008467f064ff06ed2"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxEkomKYmWgqXJmQr_qS%2Bz%3DBZ3w801eh7Z7ekh-3oHXxHQ%40mail.gmail.com>
Precedence: bulk

--00000000000008467f064ff06ed2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 20, 2026 at 4:10=E2=80=AFAM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> v5 attached.
>
v5 will cause a segfault.

+ /*
+ * For UPDATE ... FOR PORTION OF, the range column is being modified
+ * (narrowed via intersection), but it is not included in updatedCols
+ * because the user does not need UPDATE permission on it. Now manualy
+ * add it to updatedCols. Since ri_forPortionOf->fp_rangeAttno is already
+ * mapped for the child partition, we have to add it after the mapping jus=
t
+ * above. Also that makes it unsafe to mutate perminfo. XXX: Always add th=
e
+ * unmapped attno instead (before mapping), and mutate perminfo, to avoid
+ * repeated allocations?
+ */
+ if (relinfo->ri_forPortionOf)
+ {
+ AttrNumber rangeAttno =3D relinfo->ri_forPortionOf->fp_rangeAttno;
+
+ if (!bms_is_member(rangeAttno - FirstLowInvalidHeapAttributeNumber,
+   updatedCols))
+ {
+ MemoryContext oldContext;
+
+ oldContext =3D MemoryContextSwitchTo(estate->es_query_cxt);
+
+ updatedCols =3D
+ bms_add_member(updatedCols,
+   rangeAttno - FirstLowInvalidHeapAttributeNumber);
+
+ MemoryContextSwitchTo(oldContext);
+ }
+ }
+
+ return updatedCols;

+ updatedCols =3D
+ bms_add_member(updatedCols,
+   rangeAttno - FirstLowInvalidHeapAttributeNumber);

Here, use "perminfo->updatedCols" not "updatedCols", otherwise segfault.
The attached diff based on v5, fixes this issue.

+ALTER TABLE temporal_partitioned_3 ADD COLUMN range_len int GENERATED
ALWAYS AS (upper(valid_at) - lower(valid_at)) STORED;
Slightly refactoring the tests will allow for easier comparison of
range_len values.


--
jian
https://www.enterprisedb.com/

--00000000000008467f064ff06ed2
Content-Type: application/octet-stream;
	name="v6-0001-misc-fix-based-on-v5.no-cfbot"
Content-Disposition: attachment;
	filename="v6-0001-misc-fix-based-on-v5.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mo83fhp60>
X-Attachment-Id: f_mo83fhp60

RnJvbSA3MDUyMjY5OGYzNTdlY2MxNGUxODc3YzQzNDY1ZTYzMDhkNDZiZGQwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFR1ZSwgMjEgQXByIDIwMjYgMTE6NTM6MzIgKzA4MDAKU3ViamVjdDogW1BBVENIIHY2
IDEvMV0gbWlzYyBmaXggYmFzZWQgb24gdjUKCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVz
L20vQ0FIZytRRGNkPXQ2OWdMZjl5UWV4TzA3RUoybXgwWjcwTkZIbzZoOTRYMUVEQT1oTTBnQG1h
aWwuZ21haWwuY29tCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vQ0FIZytRRGNzWHNV
VmFaK0p3TTAyeURSUUVpPWNMX3JUSF9ST0xEWWdPeDAwNHNRdTdBQG1haWwuZ21haWwuY29tCi0t
LQogc3JjL2JhY2tlbmQvZXhlY3V0b3IvZXhlY1V0aWxzLmMgICAgICAgICAgICAgfCAzNSArKysr
KysrKysrKysrKystLS0tCiBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2Zvcl9wb3J0aW9uX29m
Lm91dCB8IDM2ICsrKysrKysrKystLS0tLS0tLS0tCiBzcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3Jf
cG9ydGlvbl9vZi5zcWwgICAgICB8ICAyICstCiAzIGZpbGVzIGNoYW5nZWQsIDQ4IGluc2VydGlv
bnMoKyksIDI1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2V4ZWN1dG9y
L2V4ZWNVdGlscy5jIGIvc3JjL2JhY2tlbmQvZXhlY3V0b3IvZXhlY1V0aWxzLmMKaW5kZXggMjlh
OGQzYWJhNzQuLmZiNjk4MzJkYmViIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9leGVjdXRvci9l
eGVjVXRpbHMuYworKysgYi9zcmMvYmFja2VuZC9leGVjdXRvci9leGVjVXRpbHMuYwpAQCAtMTQw
OSw3ICsxNDA5LDYgQEAgQml0bWFwc2V0ICoKIEV4ZWNHZXRVcGRhdGVkQ29scyhSZXN1bHRSZWxJ
bmZvICpyZWxpbmZvLCBFU3RhdGUgKmVzdGF0ZSkKIHsKIAlSVEVQZXJtaXNzaW9uSW5mbyAqcGVy
bWluZm8gPSBHZXRSZXN1bHRSVEVQZXJtaXNzaW9uSW5mbyhyZWxpbmZvLCBlc3RhdGUpOwotCUJp
dG1hcHNldCAqdXBkYXRlZENvbHMgPSBwZXJtaW5mby0+dXBkYXRlZENvbHM7CiAKIAlpZiAocGVy
bWluZm8gPT0gTlVMTCkKIAkJcmV0dXJuIE5VTEw7CkBAIC0xNDIwLDcgKzE0MTksMzEgQEAgRXhl
Y0dldFVwZGF0ZWRDb2xzKFJlc3VsdFJlbEluZm8gKnJlbGluZm8sIEVTdGF0ZSAqZXN0YXRlKQog
CQlUdXBsZUNvbnZlcnNpb25NYXAgKm1hcCA9IEV4ZWNHZXRSb290VG9DaGlsZE1hcChyZWxpbmZv
LCBlc3RhdGUpOwogCiAJCWlmIChtYXApCi0JCQl1cGRhdGVkQ29scyA9IGV4ZWN1dGVfYXR0cl9t
YXBfY29scyhtYXAtPmF0dHJNYXAsIHVwZGF0ZWRDb2xzKTsKKwkJeworCQkJLyogU2VlIGJlbG93
ICovCisJCQlpZiAocmVsaW5mby0+cmlfZm9yUG9ydGlvbk9mKQorCQkJeworCQkJCUF0dHJOdW1i
ZXIJcmFuZ2VBdHRubyA9IHJlbGluZm8tPnJpX2ZvclBvcnRpb25PZi0+ZnBfcmFuZ2VBdHRubzsK
KworCQkJCXJhbmdlQXR0bm8gPSBtYXAtPmF0dHJNYXAtPmF0dG51bXNbcmFuZ2VBdHRubyAtIDFd
OworCisJCQkJaWYgKCFibXNfaXNfbWVtYmVyKHJhbmdlQXR0bm8gLSBGaXJzdExvd0ludmFsaWRI
ZWFwQXR0cmlidXRlTnVtYmVyLAorCQkJCQkJCQkgICBwZXJtaW5mby0+dXBkYXRlZENvbHMpKQor
CQkJCXsKKwkJCQkJTWVtb3J5Q29udGV4dCBvbGRDb250ZXh0OworCisJCQkJCW9sZENvbnRleHQg
PSBNZW1vcnlDb250ZXh0U3dpdGNoVG8oZXN0YXRlLT5lc19xdWVyeV9jeHQpOworCisJCQkJCXBl
cm1pbmZvLT51cGRhdGVkQ29scyA9CisJCQkJCQlibXNfYWRkX21lbWJlcihwZXJtaW5mby0+dXBk
YXRlZENvbHMsCisJCQkJCQkJCQkgICByYW5nZUF0dG5vIC0gRmlyc3RMb3dJbnZhbGlkSGVhcEF0
dHJpYnV0ZU51bWJlcik7CisKKwkJCQkJTWVtb3J5Q29udGV4dFN3aXRjaFRvKG9sZENvbnRleHQp
OworCQkJCX0KKwkJCX0KKworCQkJcmV0dXJuIGV4ZWN1dGVfYXR0cl9tYXBfY29scyhtYXAtPmF0
dHJNYXAsIHBlcm1pbmZvLT51cGRhdGVkQ29scyk7CisJCX0KIAl9CiAKIAkvKgpAQCAtMTQzOCwy
MSArMTQ2MSwyMSBAQCBFeGVjR2V0VXBkYXRlZENvbHMoUmVzdWx0UmVsSW5mbyAqcmVsaW5mbywg
RVN0YXRlICplc3RhdGUpCiAJCUF0dHJOdW1iZXIJcmFuZ2VBdHRubyA9IHJlbGluZm8tPnJpX2Zv
clBvcnRpb25PZi0+ZnBfcmFuZ2VBdHRubzsKIAogCQlpZiAoIWJtc19pc19tZW1iZXIocmFuZ2VB
dHRubyAtIEZpcnN0TG93SW52YWxpZEhlYXBBdHRyaWJ1dGVOdW1iZXIsCi0JCQkJCQkgICB1cGRh
dGVkQ29scykpCisJCQkJCQkgICBwZXJtaW5mby0+dXBkYXRlZENvbHMpKQogCQl7CiAJCQlNZW1v
cnlDb250ZXh0IG9sZENvbnRleHQ7CiAKIAkJCW9sZENvbnRleHQgPSBNZW1vcnlDb250ZXh0U3dp
dGNoVG8oZXN0YXRlLT5lc19xdWVyeV9jeHQpOwogCi0JCQl1cGRhdGVkQ29scyA9Ci0JCQkJYm1z
X2FkZF9tZW1iZXIodXBkYXRlZENvbHMsCisJCQlwZXJtaW5mby0+dXBkYXRlZENvbHMgPQorCQkJ
CWJtc19hZGRfbWVtYmVyKHBlcm1pbmZvLT51cGRhdGVkQ29scywKIAkJCQkJCQkgICByYW5nZUF0
dG5vIC0gRmlyc3RMb3dJbnZhbGlkSGVhcEF0dHJpYnV0ZU51bWJlcik7CiAKIAkJCU1lbW9yeUNv
bnRleHRTd2l0Y2hUbyhvbGRDb250ZXh0KTsKIAkJfQogCX0KIAotCXJldHVybiB1cGRhdGVkQ29s
czsKKwlyZXR1cm4gcGVybWluZm8tPnVwZGF0ZWRDb2xzOwogfQogCiAvKiBSZXR1cm4gYSBiaXRt
YXAgcmVwcmVzZW50aW5nIGdlbmVyYXRlZCBjb2x1bW5zIGJlaW5nIHVwZGF0ZWQgKi8KZGlmZiAt
LWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZm9yX3BvcnRpb25fb2Yub3V0IGIvc3Jj
L3Rlc3QvcmVncmVzcy9leHBlY3RlZC9mb3JfcG9ydGlvbl9vZi5vdXQKaW5kZXggNjAyYWNhNmU2
YWEuLjI3M2Q3MTBmODk1IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2Zv
cl9wb3J0aW9uX29mLm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2Zvcl9wb3J0
aW9uX29mLm91dApAQCAtMjA2NCwyNCArMjA2NCwyNCBAQCBVUERBVEUgdGVtcG9yYWxfcGFydGl0
aW9uZWQgRk9SIFBPUlRJT04gT0YgdmFsaWRfYXQgRlJPTSAnMjAwMC0wNi0wMScgVE8gJzIwMDAt
MAogICAgICAgaWQgPSAnWzMsNCknCiAgIFdIRVJFIGlkID0gJ1s1LDYpJzsKIC0tIFVwZGF0ZSBh
bGwgcGFydGl0aW9ucyBhdCBvbmNlIChlYWNoIHdpdGggbGVmdG92ZXJzKQotU0VMRUNUICogRlJP
TSB0ZW1wb3JhbF9wYXJ0aXRpb25lZCBPUkRFUiBCWSBpZCwgdmFsaWRfYXQ7Ci0gIGlkICAgfCAg
ICAgICAgdmFsaWRfYXQgICAgICAgICB8ICBuYW1lICAgfCByYW5nZV9sZW4gCi0tLS0tLS0tKy0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tKy0tLS0tLS0tLS0tCi0gWzEsMikgfCBb
MjAwMC0wMS0wMSwyMDAwLTAzLTAxKSB8IG9uZSAgICAgfCAgICAgICAgNjAKLSBbMSwyKSB8IFsy
MDAwLTAzLTAxLDIwMDAtMDQtMDEpIHwgb25lXjEgICB8ICAgICAgICAzMQotIFsxLDIpIHwgWzIw
MDAtMDQtMDEsMjAwMC0wNi0wMSkgfCBvbmUgICAgIHwgICAgICAgIDYxCi0gWzEsMikgfCBbMjAw
MC0wNy0wMSwyMDEwLTAxLTAxKSB8IG9uZSAgICAgfCAgICAgIDM0NzEKLSBbMiwzKSB8IFsyMDAw
LTA2LTAxLDIwMDAtMDctMDEpIHwgdGhyZWVeMiB8ICAgICAgICAzMAotIFszLDQpIHwgWzIwMDAt
MDEtMDEsMjAwMC0wMy0wMSkgfCB0aHJlZSAgIHwgICAgICAgIDYwCi0gWzMsNCkgfCBbMjAwMC0w
My0wMSwyMDAwLTA0LTAxKSB8IHRocmVlXjEgfCAgICAgICAgMzEKLSBbMyw0KSB8IFsyMDAwLTA0
LTAxLDIwMDAtMDYtMDEpIHwgdGhyZWUgICB8ICAgICAgICA2MQotIFszLDQpIHwgWzIwMDAtMDYt
MDEsMjAwMC0wNy0wMSkgfCBmaXZlXjIgIHwgICAgICAgIDMwCi0gWzMsNCkgfCBbMjAwMC0wNy0w
MSwyMDEwLTAxLTAxKSB8IHRocmVlICAgfCAgICAgIDM0NzEKLSBbNCw1KSB8IFsyMDAwLTA2LTAx
LDIwMDAtMDctMDEpIHwgb25lXjIgICB8ICAgICAgICAzMAotIFs1LDYpIHwgWzIwMDAtMDEtMDEs
MjAwMC0wMy0wMSkgfCBmaXZlICAgIHwgICAgICAgIDYwCi0gWzUsNikgfCBbMjAwMC0wMy0wMSwy
MDAwLTA0LTAxKSB8IGZpdmVeMSAgfCAgICAgICAgMzEKLSBbNSw2KSB8IFsyMDAwLTA0LTAxLDIw
MDAtMDYtMDEpIHwgZml2ZSAgICB8ICAgICAgICA2MQotIFs1LDYpIHwgWzIwMDAtMDctMDEsMjAx
MC0wMS0wMSkgfCBmaXZlICAgIHwgICAgICAzNDcxCitTRUxFQ1QgKiwgdXBwZXIodmFsaWRfYXQp
IC0gbG93ZXIodmFsaWRfYXQpIGFzIHJhbmdlX2xlbjEgRlJPTSB0ZW1wb3JhbF9wYXJ0aXRpb25l
ZCBPUkRFUiBCWSBpZCwgdmFsaWRfYXQ7CisgIGlkICAgfCAgICAgICAgdmFsaWRfYXQgICAgICAg
ICB8ICBuYW1lICAgfCByYW5nZV9sZW4gfCByYW5nZV9sZW4xIAorLS0tLS0tLSstLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLSstLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0KKyBbMSwy
KSB8IFsyMDAwLTAxLTAxLDIwMDAtMDMtMDEpIHwgb25lICAgICB8ICAgICAgICA2MCB8ICAgICAg
ICAgNjAKKyBbMSwyKSB8IFsyMDAwLTAzLTAxLDIwMDAtMDQtMDEpIHwgb25lXjEgICB8ICAgICAg
ICAzMSB8ICAgICAgICAgMzEKKyBbMSwyKSB8IFsyMDAwLTA0LTAxLDIwMDAtMDYtMDEpIHwgb25l
ICAgICB8ICAgICAgICA2MSB8ICAgICAgICAgNjEKKyBbMSwyKSB8IFsyMDAwLTA3LTAxLDIwMTAt
MDEtMDEpIHwgb25lICAgICB8ICAgICAgMzQ3MSB8ICAgICAgIDM0NzEKKyBbMiwzKSB8IFsyMDAw
LTA2LTAxLDIwMDAtMDctMDEpIHwgdGhyZWVeMiB8ICAgICAgICAzMCB8ICAgICAgICAgMzAKKyBb
Myw0KSB8IFsyMDAwLTAxLTAxLDIwMDAtMDMtMDEpIHwgdGhyZWUgICB8ICAgICAgICA2MCB8ICAg
ICAgICAgNjAKKyBbMyw0KSB8IFsyMDAwLTAzLTAxLDIwMDAtMDQtMDEpIHwgdGhyZWVeMSB8ICAg
ICAgICAzMSB8ICAgICAgICAgMzEKKyBbMyw0KSB8IFsyMDAwLTA0LTAxLDIwMDAtMDYtMDEpIHwg
dGhyZWUgICB8ICAgICAgICA2MSB8ICAgICAgICAgNjEKKyBbMyw0KSB8IFsyMDAwLTA2LTAxLDIw
MDAtMDctMDEpIHwgZml2ZV4yICB8ICAgICAgICAzMCB8ICAgICAgICAgMzAKKyBbMyw0KSB8IFsy
MDAwLTA3LTAxLDIwMTAtMDEtMDEpIHwgdGhyZWUgICB8ICAgICAgMzQ3MSB8ICAgICAgIDM0NzEK
KyBbNCw1KSB8IFsyMDAwLTA2LTAxLDIwMDAtMDctMDEpIHwgb25lXjIgICB8ICAgICAgICAzMCB8
ICAgICAgICAgMzAKKyBbNSw2KSB8IFsyMDAwLTAxLTAxLDIwMDAtMDMtMDEpIHwgZml2ZSAgICB8
ICAgICAgICA2MCB8ICAgICAgICAgNjAKKyBbNSw2KSB8IFsyMDAwLTAzLTAxLDIwMDAtMDQtMDEp
IHwgZml2ZV4xICB8ICAgICAgICAzMSB8ICAgICAgICAgMzEKKyBbNSw2KSB8IFsyMDAwLTA0LTAx
LDIwMDAtMDYtMDEpIHwgZml2ZSAgICB8ICAgICAgICA2MSB8ICAgICAgICAgNjEKKyBbNSw2KSB8
IFsyMDAwLTA3LTAxLDIwMTAtMDEtMDEpIHwgZml2ZSAgICB8ICAgICAgMzQ3MSB8ICAgICAgIDM0
NzEKICgxNSByb3dzKQogCiBTRUxFQ1QgKiBGUk9NIHRlbXBvcmFsX3BhcnRpdGlvbmVkXzEgT1JE
RVIgQlkgaWQsIHZhbGlkX2F0OwpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZm9y
X3BvcnRpb25fb2Yuc3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZm9yX3BvcnRpb25fb2Yuc3Fs
CmluZGV4IDAwMWU4M2U0Y2U0Li42OGQxMjk4NDJhMyAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVn
cmVzcy9zcWwvZm9yX3BvcnRpb25fb2Yuc3FsCisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2Zv
cl9wb3J0aW9uX29mLnNxbApAQCAtMTM3MCw3ICsxMzcwLDcgQEAgVVBEQVRFIHRlbXBvcmFsX3Bh
cnRpdGlvbmVkIEZPUiBQT1JUSU9OIE9GIHZhbGlkX2F0IEZST00gJzIwMDAtMDYtMDEnIFRPICcy
MDAwLTAKIAogLS0gVXBkYXRlIGFsbCBwYXJ0aXRpb25zIGF0IG9uY2UgKGVhY2ggd2l0aCBsZWZ0
b3ZlcnMpCiAKLVNFTEVDVCAqIEZST00gdGVtcG9yYWxfcGFydGl0aW9uZWQgT1JERVIgQlkgaWQs
IHZhbGlkX2F0OworU0VMRUNUICosIHVwcGVyKHZhbGlkX2F0KSAtIGxvd2VyKHZhbGlkX2F0KSBh
cyByYW5nZV9sZW4xIEZST00gdGVtcG9yYWxfcGFydGl0aW9uZWQgT1JERVIgQlkgaWQsIHZhbGlk
X2F0OwogU0VMRUNUICogRlJPTSB0ZW1wb3JhbF9wYXJ0aXRpb25lZF8xIE9SREVSIEJZIGlkLCB2
YWxpZF9hdDsKIFNFTEVDVCAqIEZST00gdGVtcG9yYWxfcGFydGl0aW9uZWRfMyBPUkRFUiBCWSBp
ZCwgdmFsaWRfYXQ7CiBTRUxFQ1QgKiBGUk9NIHRlbXBvcmFsX3BhcnRpdGlvbmVkXzUgT1JERVIg
QlkgaWQsIHZhbGlkX2F0OwotLSAKMi4zNC4xCgo=
--00000000000008467f064ff06ed2--