MIME-Version: 1.0
References: <3f22a8bb-29e8-40cc-97a1-309181da2c13@dunslane.net>
 <CAKYtNApm8nA6hVMNkSjeNPiwTZBWYkhJKU7haQghUZdw74tYxA@mail.gmail.com>
 <CACJufxHc5Rp2roGyJOVnCk=Mx8_42_9vCGJSCFpLB5=AFQqHTQ@mail.gmail.com>
 <CAKYtNAoz-Sz2X1ipkQ5x1Sh08AMyy1kDRGfeRW3P1W-QoN+WOg@mail.gmail.com>
 <CAC6VRoZU2L2GX7+bXpsZ6bo+NuxBOe1dTGDPzKobUL4KVdm46A@mail.gmail.com>
 <CAKYtNApq+6Riz26So1nmXkRpL_7o868+r6i=wxQ+AgGQ4oSLig@mail.gmail.com>
 <CAC6VRoZbP=-=a+a78RoWcs2L4=4VEDZqJMg+7SyUAcSHATyDAQ@mail.gmail.com>
 <CAC6VRoY-1WC_O5UDwKzNc18LXLwjuTFb+qMNY3gaF3cCov6M6g@mail.gmail.com>
 <CAKYtNArc3j8Akb+nB1QyJLKic7ej7vKZqKnv_mbB+iQAJRzLnA@mail.gmail.com>
 <CAC6VRoat6NPcS6vfGrPrwaQB3G1JHLSqDeAkf1AJ7npWrwhnUQ@mail.gmail.com>
 <CAKYtNAp=TFEZWQbTRZso3kNaD9BH=-JPNQ30mT60cJN_04hEog@mail.gmail.com>
 <4022765f-38ee-48a3-b246-615b3f8e1c23@dunslane.net> <CAKYtNAq73_UeL4-0wgu9rawctHdS2zhpzWtqVuOChCS3M+2Ymg@mail.gmail.com>
 <CACJufxFs9NXXTeb78i2MD+pnZootayAtiGcNHNeU35SmQgMjbA@mail.gmail.com> <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net>
In-Reply-To: <59d3616f-6d6d-40d5-87e2-e019e350b52d@dunslane.net>
From: jian he <jian.universality@gmail.com>
Date: Mon, 23 Feb 2026 16:04:55 +0800
Message-ID: <CACJufxEnmJ8otfmN7Kp110Wqi=M4YE0-zn-W6SK+eTpWuZw_fg@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, tushar <tushar.ahuja@enterprisedb.com>, 
	Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000026c807064b793c7e"
Archived-At: <https://www.postgresql.org/message-id/CACJufxEnmJ8otfmN7Kp110Wqi%3DM4YE0-zn-W6SK%2BeTpWuZw_fg%40mail.gmail.com>
Precedence: bulk

--00000000000026c807064b793c7e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 22, 2026 at 1:05=E2=80=AFAM Andrew Dunstan <andrew@dunslane.net=
> wrote:
>
> What about options like these?:
>
>   n/--schema
>   N/--exclude-schema
>   t/--table
>   T/--trigger
>   I/--index
>   P/--function
>   -filter
>
> We're not currently doing anything about those, but do they make sense wh=
en restoring a pg_dumpall archive?
>

We should reject these options too, since these options do not make
sense for multiple databases, IMHO.

>
> pg_restore --clean --format=3Ddirectory will produce DROP DATABASE will
> process global objects,
> it will also produce DROP DATABASE when processing each individual databa=
se.
> To prevent errors during a subsequent restore, we can require
> pg_restore --clean option must be used together with --if-exists when
> restoring a non-plain-text dump.
>
> We could. Or we could just turn it on (and document that it will be turne=
d on) in this case. I'd rather not force people to use lots of flags.
>

Turning it on is OK for me.

The attached patch addresses the two issues described above.


--
jian
https://www.enterprisedb.com/

--00000000000026c807064b793c7e
Content-Type: application/octet-stream; 
	name="v18-0001-misc-fix-for-v18.no-cfbot"
Content-Disposition: attachment; 
	filename="v18-0001-misc-fix-for-v18.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mlyw4yfv0>
X-Attachment-Id: f_mlyw4yfv0

RnJvbSBmYmI3MzQwZmU5MjRmNGQxZmNhZGYyMGU5OTk3ODE5MGUwY2JkMGE0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IE1vbiwgMjMgRmViIDIwMjYgMTU6MDU6MDkgKzA4MDAKU3ViamVjdDogW1BBVENIIHYx
OCAxLzFdIG1pc2MgZml4IGZvciB2MTgKCk5vbi10ZXh0LW1vZGVzLWZvci1wZ19kdW1wYWxsLWNv
cnJlc3BvbmRpbmdseS1jaGFuZ2UucGF0Y2gKCmRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVz
L20vCi0tLQogZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwgfCAyNSArKysrKysrKysr
KysrKysrKysrKysrKysrCiBzcmMvYmluL3BnX2R1bXAvcGdfZHVtcGFsbC5jICAgICB8ICA2ICsr
KystLQogc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYyAgICAgfCAyNyArKysrKysrKysrKysr
KysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgMiBkZWxl
dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvcmVmL3BnX3Jlc3RvcmUuc2dtbCBi
L2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVzdG9yZS5zZ21sCmluZGV4IDNkNTUzMWNmYTk2Li5jZDgy
MzM3MTJlNCAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKKysr
IGIvZG9jL3NyYy9zZ21sL3JlZi9wZ19yZXN0b3JlLnNnbWwKQEAgLTU4LDcgKzU4LDI4IEBAIFBv
c3RncmVTUUwgZG9jdW1lbnRhdGlvbgogICAgV2hlbiByZXN0b3JpbmcgZnJvbSBhIGR1bXAgbWFk
ZSBieSA8YXBwbGljYXRpb24+cGdfZHVtcGFsbDwvYXBwbGljYXRpb24+LAogICAgZWFjaCBkYXRh
YmFzZSB3aWxsIGJlIGNyZWF0ZWQgYW5kIHRoZW4gdGhlIHJlc3RvcmF0aW9uIHdpbGwgYmUgcnVu
IGluIHRoYXQKICAgIGRhdGFiYXNlLgorICAgPC9wYXJhPgogCisgICA8cGFyYT4KKyAgICBOb3Qg
YWxsIG9wdGlvbnMgYXJlIHN1cHBvcnRlZCB3aGVuIHJlc3RvcmluZyBmcm9tIGFuIGFyY2hpdmUg
Y3JlYXRlZCBieSA8YXBwbGljYXRpb24+cGdfZHVtcGFsbDwvYXBwbGljYXRpb24+LgorICAgIFRo
ZSBmb2xsb3dpbmcgb3B0aW9ucyBhcmUgbm90IHN1cHBvcnRlZDoKKyAgICAgPG9wdGlvbj4tYS8t
LWRhdGEtb25seTwvb3B0aW9uPiwKKyAgICAgPG9wdGlvbj5maWx0ZXI8L29wdGlvbj4sCisgICAg
IDxvcHRpb24+LWwvLS1saXN0PC9vcHRpb24+LAorICAgICA8b3B0aW9uPi1MLy0tdXNlLWxpc3Q8
L29wdGlvbj4sCisgICAgIDxvcHRpb24+LW48L29wdGlvbj4vPG9wdGlvbj4tLXNjaGVtYTwvb3B0
aW9uPiwKKyAgICAgPG9wdGlvbj4tLW5vLXNjaGVtYTwvb3B0aW9uPiwKKyAgICAgPG9wdGlvbj4t
Tjwvb3B0aW9uPi88b3B0aW9uPi0tZXhjbHVkZS1zY2hlbWE8L29wdGlvbj4sCisgICAgIDxvcHRp
b24+LVA8L29wdGlvbj4vPG9wdGlvbj4tLWZ1bmN0aW9uPC9vcHRpb24+LAorICAgICA8b3B0aW9u
Pi1JPC9vcHRpb24+LzxvcHRpb24+LS1pbmRleDwvb3B0aW9uPiwKKyAgICAgPG9wdGlvbj4tLXN0
YXRpc3RpY3Mtb25seTwvb3B0aW9uPiwKKyAgICAgPG9wdGlvbj4tLXN0cmljdC1uYW1lczwvb3B0
aW9uPiwKKyAgICAgPG9wdGlvbj4tdDwvb3B0aW9uPi88b3B0aW9uPi0tdGFibGU8L29wdGlvbj4s
CisgICAgIDxvcHRpb24+LVQ8L29wdGlvbj4vPG9wdGlvbj4tLXRyaWdnZXI8L29wdGlvbj4sCisg
ICAgIEluIGFkZGl0aW9uLCA8b3B0aW9uPi0tc2VjdGlvbjwvb3B0aW9uPiBtdXN0IGluY2x1ZGUg
dmFsdWU8b3B0aW9uPi0tcHJlLWRhdGE8L29wdGlvbj4uCisgICA8L3BhcmE+CisKKyAgPHBhcmE+
CiAgICBPdGhlcndpc2UsIHdoZW4gYSBkYXRhYmFzZSBuYW1lIGlzIG5vdCBzcGVjaWZpZWQsIGEg
c2NyaXB0IGNvbnRhaW5pbmcgdGhlIFNRTAogICAgY29tbWFuZHMgbmVjZXNzYXJ5IHRvIHJlYnVp
bGQgdGhlIGRhdGFiYXNlIG9yIGNsdXN0ZXIgaXMgY3JlYXRlZCBhbmQgd3JpdHRlbgogICAgdG8g
YSBmaWxlIG9yIHN0YW5kYXJkIG91dHB1dC4gIFRoaXMgc2NyaXB0IG91dHB1dCBpcyBlcXVpdmFs
ZW50IHRvCkBAIC0xNTEsNiArMTcyLDEwIEBAIFBvc3RncmVTUUwgZG9jdW1lbnRhdGlvbgogICAg
ICAgICBJZiBhbnkgb2YgdGhlIG9iamVjdHMgZG8gbm90IGV4aXN0IGluIHRoZSBkZXN0aW5hdGlv
biBkYXRhYmFzZSwKICAgICAgICAgaWdub3JhYmxlIGVycm9yIG1lc3NhZ2VzIHdpbGwgYmUgcmVw
b3J0ZWQsCiAgICAgICAgIHVubGVzcyA8b3B0aW9uPi0taWYtZXhpc3RzPC9vcHRpb24+IGlzIGFs
c28gc3BlY2lmaWVkLgorICAgICAgICBXaGVuIHJlc3RvcmluZyBtdWx0aXBsZSBkYXRhYmFzZXMg
ZnJvbSBhbiBhcmNoaXZlIGNyZWF0ZWQgYnkKKyAgICAgICAgPGFwcGxpY2F0aW9uPnBnX2R1bXBh
bGw8L2FwcGxpY2F0aW9uPiBzcGVjaWZ5aW5nIHRoZQorICAgICAgICA8b3B0aW9uPi0tY2xlYW48
L29wdGlvbj4gb3B0aW9uIGltcGxpY2l0bHkgZW5hYmxlcworICAgICAgICA8b3B0aW9uPi0taWYt
ZXhpc3RzPC9vcHRpb24+IGFzIHdlbGwuCiAgICAgICAgPC9wYXJhPgogICAgICAgPC9saXN0aXRl
bT4KICAgICAgPC92YXJsaXN0ZW50cnk+CmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX2R1bXAvcGdf
ZHVtcGFsbC5jIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBhbGwuYwppbmRleCA1YTExNGQwOTE4
NS4uZDE4YzcyODBkMTkgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wYWxsLmMK
KysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXBhbGwuYwpAQCAtMTM0LDcgKzEzNCw2IEBAIHN0
YXRpYyBTaW1wbGVTdHJpbmdMaXN0IGRhdGFiYXNlX2V4Y2x1ZGVfbmFtZXMgPSB7TlVMTCwgTlVM
TH07CiAKIHN0YXRpYyBjaGFyICpyZXN0cmljdF9rZXk7CiBzdGF0aWMgQXJjaGl2ZSAqZm91dCA9
IE5VTEw7Ci1zdGF0aWMgcGdfY29tcHJlc3Nfc3BlY2lmaWNhdGlvbiBjb21wcmVzc2lvbl9zcGVj
ID0gezB9Owogc3RhdGljIGludAlkdW1wSWRWYWwgPSAwOwogc3RhdGljIEFyY2hpdmVGb3JtYXQg
YXJjaER1bXBGb3JtYXQgPSBhcmNoTnVsbDsKIHN0YXRpYyBjb25zdCBDYXRhbG9nSWQgbmlsQ2F0
YWxvZ0lkID0gezAsIDB9OwpAQCAtNjU1LDYgKzY1NCw3IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIg
KmFyZ3ZbXSkKIAkJUFFFeHBCdWZmZXIgcXJ5ID0gY3JlYXRlUFFFeHBCdWZmZXIoKTsKIAkJY2hh
ciAgICAgICAgICAgIGdsb2JhbF9wYXRoW01BWFBHUEFUSF07CiAJCWNvbnN0IGNoYXIgKmVuY25h
bWU7CisJCXBnX2NvbXByZXNzX3NwZWNpZmljYXRpb24gY29tcHJlc3Npb25fc3BlYyA9IHswfTsK
IAogCQkvKiBTZXQgZmlsZSBwYXRoIGZvciBnbG9iYWwgc3FsIGNvbW1hbmRzLiAqLwogCQlzbnBy
aW50ZihnbG9iYWxfcGF0aCwgTUFYUEdQQVRILCAiJXMvdG9jLmdsbyIsIGZpbGVuYW1lKTsKQEAg
LTExODQsNyArMTE4NCw5IEBAIGR1bXBSb2xlcyhQR2Nvbm4gKmNvbm4pCiAJCWlmIChhcmNoRHVt
cEZvcm1hdCA9PSBhcmNoTnVsbCkKIAkJewogCQkJZnByaW50ZihPUEYsICIlcyIsIGJ1Zi0+ZGF0
YSk7Ci0JCQlmcHJpbnRmKE9QRiwgIiVzIiwgY29tbWVudF9idWYtPmRhdGEpOworCisJCQlpZiAo
Y29tbWVudF9idWYtPmRhdGFbMF0gIT0gJ1wwJykKKwkJCQlmcHJpbnRmKE9QRiwgIiVzIiwgY29t
bWVudF9idWYtPmRhdGEpOwogCiAJCQlpZiAoc2VjbGFiZWxfYnVmLT5kYXRhWzBdICE9ICdcMCcp
CiAJCQkJZnByaW50ZihPUEYsICIlcyIsIHNlY2xhYmVsX2J1Zi0+ZGF0YSk7CmRpZmYgLS1naXQg
YS9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3Rv
cmUuYwppbmRleCAzN2YzMGU2NTQyMS4uMGM2NDA0MDk2ZTUgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4v
cGdfZHVtcC9wZ19yZXN0b3JlLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYwpA
QCAtNTY2LDYgKzU2Niw5IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogCiAJCW9wdHMt
PmZvcm1hdCA9IGFyY2hVbmtub3duOwogCisJCWlmIChvcHRzLT5kcm9wU2NoZW1hKQorCQkJb3B0
cy0+aWZfZXhpc3RzID0gdHJ1ZTsKKwogCQltZW1jcHkodG1wb3B0cywgb3B0cywgc2l6ZW9mKFJl
c3RvcmVPcHRpb25zKSk7CiAKIAkJLyoKQEAgLTYwMiw2ICs2MDUsMzAgQEAgbWFpbihpbnQgYXJn
YywgY2hhciAqKmFyZ3YpCiAJCQlwZ19mYXRhbCgib3B0aW9uICVzIGNhbm5vdCBleGNsdWRlICVz
IHdoZW4gcmVzdG9yaW5nIGEgcGdfZHVtcGFsbCBhcmNoaXZlIiwKIAkJCQkJICItLXNlY3Rpb24i
LCAiLS1wcmUtZGF0YSIpOwogCisJCWlmIChvcHRzLT5pbmRleE5hbWVzLmhlYWQgIT0gTlVMTCkK
KwkJCXBnX2ZhdGFsKCJvcHRpb24gJXMgY2Fubm90IGJlIHVzZWQgd2hlbiByZXN0b3JpbmcgYW4g
YXJjaGl2ZSBjcmVhdGVkIGJ5IHBnX2R1bXBhbGwiLAorCQkJCQkgIi1JLy0taW5kZXgiKTsKKwor
CQlpZiAob3B0cy0+ZnVuY3Rpb25OYW1lcy5oZWFkICE9IE5VTEwpCisJCQlwZ19mYXRhbCgib3B0
aW9uICVzIGNhbm5vdCBiZSB1c2VkIHdoZW4gcmVzdG9yaW5nIGFuIGFyY2hpdmUgY3JlYXRlZCBi
eSBwZ19kdW1wYWxsIiwKKwkJCQkJICItUC8tLWZ1bmN0aW9uIik7CisKKwkJaWYgKG9wdHMtPnNj
aGVtYU5hbWVzLmhlYWQgIT0gTlVMTCkKKwkJCXBnX2ZhdGFsKCJvcHRpb24gJXMgY2Fubm90IGJl
IHVzZWQgd2hlbiByZXN0b3JpbmcgYW4gYXJjaGl2ZSBjcmVhdGVkIGJ5IHBnX2R1bXBhbGwiLAor
CQkJCQkgIi1uLy0tc2NoZW1hIik7CisKKwkJaWYgKG9wdHMtPnNjaGVtYUV4Y2x1ZGVOYW1lcy5o
ZWFkICE9IE5VTEwpCisJCQlwZ19mYXRhbCgib3B0aW9uICVzIGNhbm5vdCBiZSB1c2VkIHdoZW4g
cmVzdG9yaW5nIGFuIGFyY2hpdmUgY3JlYXRlZCBieSBwZ19kdW1wYWxsIiwKKwkJCQkJICItTi8t
LWV4Y2x1ZGUtc2NoZW1hIik7CisKKwkJaWYgKG9wdHMtPnRyaWdnZXJOYW1lcy5oZWFkICE9IE5V
TEwpCisJCQlwZ19mYXRhbCgib3B0aW9uICVzIGNhbm5vdCBiZSB1c2VkIHdoZW4gcmVzdG9yaW5n
IGFuIGFyY2hpdmUgY3JlYXRlZCBieSBwZ19kdW1wYWxsIiwKKwkJCQkJICItVC8tLXRyaWdnZXIi
KTsKKworCQlpZiAob3B0cy0+dGFibGVOYW1lcy5oZWFkICE9IE5VTEwpCisJCQlwZ19mYXRhbCgi
b3B0aW9uICVzIGNhbm5vdCBiZSB1c2VkIHdoZW4gcmVzdG9yaW5nIGFuIGFyY2hpdmUgY3JlYXRl
ZCBieSBwZ19kdW1wYWxsIiwKKwkJCQkJICItdC8tLXRhYmxlIik7CisKIAkJLyoKIAkJICogVG8g
cmVzdG9yZSBmcm9tIGEgcGdfZHVtcGFsbCBhcmNoaXZlLCAtQyAoY3JlYXRlIGRhdGFiYXNlKSBv
cHRpb24KIAkJICogbXVzdCBiZSBzcGVjaWZpZWQgdW5sZXNzIHdlIGFyZSBvbmx5IHJlc3Rvcmlu
ZyBnbG9iYWxzLgotLSAKMi4zNC4xCgo=
--00000000000026c807064b793c7e--