MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql> <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
 <CACJufxGcZ1rK94cgfdc9McCD7W-83PT9_cx5VoFeC-HVc10Wzg@mail.gmail.com>
 <CAKYtNAqd4k+4+XANxjDc35i+WPme476DkP7msjYpX85F+4UsUg@mail.gmail.com> <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
In-Reply-To: <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 15 Jan 2025 16:58:45 +0800
Message-ID: <CACJufxEtDgADBXQhX5cp3mJtNVMy+j+Jdovuk3PWe5qJ0sE3Ag@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Guillaume Lelarge <guillaume@lelarge.info>, 
	Nathan Bossart <nathandbossart@gmail.com>, Magnus Hagander <magnus@hagander.net>, 
	Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CACJufxEtDgADBXQhX5cp3mJtNVMy%2Bj%2BJdovuk3PWe5qJ0sE3Ag%40mail.gmail.com>
Precedence: bulk

On Sun, Jan 12, 2025 at 5:31=E2=80=AFAM Mahendra Singh Thalor
<mahi6run@gmail.com> wrote:
>
> >
> > you also need change
> >      <varlistentry>
> >       <term><option>-f <replaceable
> > class=3D"parameter">filename</replaceable></option></term>
> >       <term><option>--file=3D<replaceable
> > class=3D"parameter">filename</replaceable></option></term>
> >       <listitem>
> >        <para>
> >         Send output to the specified file.  If this is omitted, the
> >         standard output is used.
> >        </para>
> >       </listitem>
> >      </varlistentry>
> > ?
> >
> > since if --format=3Dd,
> > <option>--file=3D<replaceable class=3D"parameter">filename</replaceable=
></option>
> > can not be omitted.
>
> No, we don't need this change. With --fromat=3Dd, we can omit the --file =
option.
>
I think this is not correct. since the following three will fail.

$BIN6/pg_dumpall --format=3Dcustom --exclude-database=3D*template* --schema=
-only
$BIN6/pg_dumpall --format=3Ddirectory --exclude-database=3D*template* --sch=
ema-only
$BIN6/pg_dumpall --format=3Dtar --exclude-database=3D*template* --schema-on=
ly

that means, pg_dumpall, when format is {custom|directory|tar} --file
option cannot be omitted.


you introduced a format p(plain) for pg_restore? since
$BIN6/pg_restore --dbname=3Dsrc6 --format=3Dp
will not error out.
but doc/src/sgml/ref/pg_restore.sgml didn't mention this format.


+ if (archDumpFormat =3D=3D archDirectory)
+ appendPQExpBufferStr(&cmd, " -F d ");
+ else if (archDumpFormat =3D=3D archCustom)
+ appendPQExpBufferStr(&cmd, " -F c ");
+ else if (archDumpFormat =3D=3D archTar)
+ appendPQExpBufferStr(&cmd, " -F t ");
can we use long format, i think that would improve the readability.
like changing from
appendPQExpBufferStr(&cmd, " -F d ");
to
appendPQExpBufferStr(&cmd, " --format=3Ddirectory");

------------------------<<>>>------
I have tested {pg_dump && pg_restore --list}. pg_restore --list works
fine with format {directory|custom|tar}
but it seems there may be some problems with {pg_dumpall && pg_restore
--list} where format is not plain.

with your v08 patch, in my local environment.
$BIN6/pg_dumpall --format=3Dcustom --exclude-database=3D*template*
--schema-only --file=3Ddumpall_src6.custom

$BIN6/pg_restore --dbname=3Dsrc6 --verbose --schema-only --list
$SRC6/dumpall_src6.custom
error:
pg_restore: error: option -C/--create should be specified when using
dump of pg_dumpall

$BIN6/pg_restore --dbname=3Dsrc6 --create --verbose --schema-only --list
$SRC6/dumpall_src6.custom
following is some of the output:

pg_restore: found dbname as : "`s3or" and db_oid:1 in map.dat file
while restoring
pg_restore: found dbname as : "`s3or" and db_oid:5 in map.dat file
while restoring
pg_restore: found total 2 database names in map.dat file
pg_restore: needs to restore 2 databases out of 2 databases
pg_restore: restoring database "`s3or"
pg_restore: error: could not open input file
"/home/jian/Desktop/pg_src/src6/postgres/dumpall_src6.custom/databases/1":
No such file or directory