MIME-Version: 1.0
References: <0f655bcd-6487-4179-f9cf-c248efbad510@gmail.com>
 <ZjFRSVnvvGrsdndU@pryzbyj2023>
 <41117807-3bea-45bc-a9c0-743c29abff2d@postgrespro.ru>
 <ZjTlQiBPYm707Rxv@pryzbyj2023>
 <CAPpHfduhHm+4yeObsj9wK4iZvV2Ve5xcr6BwZDFiNBYbE1PfLg@mail.gmail.com>
 <CAPpHfdtgLiT2d++-qLircLB8ATUfzgR=aTmRDdF7w=2E9yDHbQ@mail.gmail.com>
 <Zjvwqs-GV0MjWIhU@pryzbyj2023>
 <CAPpHfdvh_XYHahtpoxfzDkvYOFUH1F5tm3JTV=sOZt8M4CTBcA@mail.gmail.com>
 <ZkN6EfjQGz8TOhbL@pryzbyj2023>
 <CAPpHfdvz3S7SoRiaSk9C-Juy2EzHs6NC_c9uUR0i7bymKXkvuQ@mail.gmail.com>
 <ai_c4-v8iLA2kXFV@pryzbyj2023>
 <CAPpHfdvOvaPxMoUp3T6hf4UmAaOhdPCcw71OGUWDjTXvrTZ_JA@mail.gmail.com>
 <CALT9ZEFrDgha=RyOuWru45FTk9Dbj5FF-fTw0NnE8n1FwBb2yg@mail.gmail.com>
 <CAPpHfdvpzvNt=d_Csxe-TCtvF9MRNdeMtfJu3RkmTgBkkQbGUw@mail.gmail.com>
In-Reply-To: 
 <CAPpHfdvpzvNt=d_Csxe-TCtvF9MRNdeMtfJu3RkmTgBkkQbGUw@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Tue, 16 Jun 2026 16:08:39 +0800
Message-ID: 
 <CACJufxEu1_pGYaFgiDf8wFjy-T1FBg4nfbnrtvz+mStZLDn2pA@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Alexander Korotkov <aekorotkov@gmail.com>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>,
	Dmitry Koval <d.koval@postgrespro.ru>,
 Alexander Lakhin <exclusion@gmail.com>,
	pgsql-hackers@lists.postgresql.org,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxEu1_pGYaFgiDf8wFjy-T1FBg4nfbnrtvz%2BmStZLDn2pA%40mail.gmail.com>
Precedence: bulk

On Tue, Jun 16, 2026 at 5:37=E2=80=AFAM Alexander Korotkov <aekorotkov@gmai=
l.com> wrote:
>
> On Tue, Jun 16, 2026 at 12:36=E2=80=AFAM Pavel Borisov <pashkin.elfe@gmai=
l.com> wrote:
> > On Tue, 16 Jun 2026 at 00:50, Alexander Korotkov <aekorotkov@gmail.com>=
 wrote:
> > >
> > > On Mon, Jun 15, 2026 at 2:07=E2=80=AFPM Justin Pryzby <pryzby@telsaso=
ft.com> wrote:
> > > >
> > > > I hit an error when I tried this patch.
> > > >
> > > > CREATE TABLE a (a text) PARTITION BY RANGE(a);
> > > > CREATE TABLE a1 PARTITION OF a DEFAULT;
> > > > INSERT INTO a SELECT repeat('1', 9999999);
> > > > CREATE TABLE a2 PARTITION OF a FOR VALUES FROM (2)TO(3);
> > > > ALTER TABLE a MERGE PARTITIONS (a1, a2) INTO a1;
> > > > ERROR:  row is too big: size 39264, maximum size 8160
> > >
> > > Thank you for your report.  It appears that createPartitionTable()
> > > misses NewRelationCreateToastTable() call (for instance, DefineTable(=
)
> > > has this call).  The attached patch implements fix and has tests.  I'=
m
> > > going to push it if no objections.
> >
> > It looks like the patch is missing in the last message.
>

src5=3D# explain (analyze, timing, costs off) SELECT repeat('1', 9999999);
                     QUERY PLAN
-----------------------------------------------------
 Result (actual time=3D0.002..0.003 rows=3D1.00 loops=3D1)
 Planning Time: 1454.745 ms
 Execution Time: 0.035 ms
(3 rows)

Time: 1458.413 ms (00:01.458)

The timing above is from an Assert-enabled build.
Could we optimize these tests to make them less expensive to run?


--
jian
https://www.enterprisedb.com/