public inbox for [email protected]  

help / color / mirror / Atom feed

From: jian he <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Sun, 14 Jun 2026 10:39:42 +0800
Message-ID: <CACJufxF3WB=juHAU5DwbyeNCtiUe5VOOfNTuqOYPTGEkaKf94A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CACJufxHJFNBJ0vHCCLestWV5b7DF5e4VzfmovqGKBGgqg+rcGA@mail.gmail.com>
	<CAAAe_zBY0rrgf+tKXMUc-Y3nDDD69hddRBKopEKAZobhY=Cy-Q@mail.gmail.com>
	<CAAAe_zDYxq0d3exCDwvKncD0kaL2uehDir6HXo4r5DXMitKrSg@mail.gmail.com>
	<[email protected]>

On Sat, Jun 13, 2026 at 8:26 PM Tatsuo Ishii <[email protected]> wrote:
>
> I have created v48 RPR (Row pattern recognition) patches based on the
> attached incremental patches against v47 patches. I have briefly
> looked through all the incremental patches. If I have missed
> something, I will follow up later.  The patches are based on the
> commit 3e3d7875e95 on the master branch.
>

get_windowclause_startup_tuples
do we need some comments for WindowClause->defineClause

src/backend/executor/README.rpr
  (2) Transcription to WindowClause
      - Copies rpPattern, rpSkipTo, initial fields

In transformRPR, we did this:
``wc->rpPattern = windef->rpCommonSyntax->rpPattern;``
Since this is an assignment, not a copy, is "Copies rpPattern" incorrect?

ISO reference typo: most occurrences use {ISO/IEC 19075},
but rpr_integration.sql and some places reference 9075-2:2016 instead of 19075.
We may need check all occurrences to ensure consistency.

In struct ResultRelInfo, we have fields like {ri_CheckConstraintExprs,
ri_WithCheckOptionExprs}.
Similarly, I want to rename WindowAggState->defineClauseList to
defineClauseExprs

I think the comment on function contain_rpr_walker can be removed,
since transformWithClause already explains it.

Is "judgment" really the right word?

I don't fully understand the purpose of eval_nav_offset_helper now.
Also, the branch where (isnull == true) and (offset < 0) appears
unreachable; it's never hit in the regression tests.
We should add some regression tests for these scenarios.



--
jian
https://www.enterprisedb.com/

view thread (121+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <CACJufxF3WB=juHAU5DwbyeNCtiUe5VOOfNTuqOYPTGEkaKf94A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox