MIME-Version: 1.0
References: <CAKYtNAoyQV-UKosfFDfm_ZqdC-oYaRT-01jMv1k+o9OSyXovTg@mail.gmail.com>
 <202502192109.5ifhfegolh6w@alvherre.pgsql> <CAKYtNAppgqMUjuyn7a8s-guvZuwyqt=nm99CkJ1gaME7K4eEKQ@mail.gmail.com>
In-Reply-To: <CAKYtNAppgqMUjuyn7a8s-guvZuwyqt=nm99CkJ1gaME7K4eEKQ@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Thu, 20 Feb 2025 17:18:13 +0800
Message-ID: <CACJufxFMa=gtKYSrPu_jnCYYT700SexbPONOGFjodZKc7A3Nyg@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>, 
	Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000b56812062e8f5c02"
Archived-At: <https://www.postgresql.org/message-id/CACJufxFMa%3DgtKYSrPu_jnCYYT700SexbPONOGFjodZKc7A3Nyg%40mail.gmail.com>
Precedence: bulk

--000000000000b56812062e8f5c02
Content-Type: text/plain; charset="UTF-8"

hi.
about 0001

/*
 * connectDatabase
 *
 * Make a database connection with the given parameters.  An
 * interactive password prompt is automatically issued if required.
 *
 * If fail_on_error is false, we return NULL without printing any message
 * on failure, but preserve any prompted password for the next try.
 *
 * On success, the global variable 'connstr' is set to a connection string
 * containing the options used.
 */
PGconn *
connectDatabase(const char *dbname, const char *connection_string,
                const char *pghost, const char *pgport, const char *pguser,
                trivalue prompt_password, bool fail_on_error, const
char *progname,
                const char **connstr, int *server_version)
do the comments need to change? since no
global variable 'connstr' in common_dumpall_restore.c
maybe we need some words to explain server_version, (i don't have a
huge opinion though).


/*-------------------------------------------------------------------------
 *
 * common_dumpall_restore.c
 *
 * Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
 * Portions Copyright (c) 1994, Regents of the University of California
 *
 * This is a common file for pg_dumpall and pg_restore.
 * src/bin/pg_dump/common_dumpall_restore.c
 *
 *-------------------------------------------------------------------------
 */

may change to

/*-------------------------------------------------------------------------
 *
 * common_dumpall_restore.c
 *     This is a common file for pg_dumpall and pg_restore.
 *
 * Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
 * Portions Copyright (c) 1994, Regents of the University of California
 *
 * IDENTIFICATION
 *    src/bin/pg_dump/common_dumpall_restore.c
 *
 *-------------------------------------------------------------------------
 */
so the style aligns with most other files.
(we can apply the same logic to src/bin/pg_dump/common_dumpall_restore.h)


in src/bin/pg_dump/pg_dumpall.c
#include "common_dumpall_restore.h"
imply include "pg_backup.h".
so in src/bin/pg_dump/pg_dumpall.c, we don't need include "pg_backup.h"


attached are minor cosmetic changes for v19.

--000000000000b56812062e8f5c02
Content-Type: application/octet-stream; name="v19_minor_change.no-cfbot"
Content-Disposition: attachment; filename="v19_minor_change.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_m7d4p6u10>
X-Attachment-Id: f_m7d4p6u10

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19iYWNrdXAuaCBiL3NyYy9iaW4vcGdfZHVt
cC9wZ19iYWNrdXAuaAppbmRleCA2NTAwMGU1YTA4My4uMjczYzkyMDQ0YTQgMTAwNjQ0Ci0tLSBh
L3NyYy9iaW4vcGdfZHVtcC9wZ19iYWNrdXAuaAorKysgYi9zcmMvYmluL3BnX2R1bXAvcGdfYmFj
a3VwLmgKQEAgLTMxOSw3ICszMTksNyBAQCBleHRlcm4gQXJjaGl2ZSAqQ3JlYXRlQXJjaGl2ZShj
b25zdCBjaGFyICpGaWxlU3BlYywgY29uc3QgQXJjaGl2ZUZvcm1hdCBmbXQsCiAJCQkJCQkJICBE
YXRhRGlyU3luY01ldGhvZCBzeW5jX21ldGhvZCk7CiAKIC8qIFRoZSAtLWxpc3Qgb3B0aW9uICov
Ci1leHRlcm4gdm9pZCBQcmludFRPQ1N1bW1hcnkoQXJjaGl2ZSAqQUhYLCBib29sIGFwcGVuZF9k
YXRhKTsKK2V4dGVybiB2b2lkIFByaW50VE9DU3VtbWFyeShBcmNoaXZlICpBSFgpOwogCiBleHRl
cm4gUmVzdG9yZU9wdGlvbnMgKk5ld1Jlc3RvcmVPcHRpb25zKHZvaWQpOwogCmRpZmYgLS1naXQg
YS9zcmMvYmluL3BnX2R1bXAvcGdfYmFja3VwX2FyY2hpdmVyLmMgYi9zcmMvYmluL3BnX2R1bXAv
cGdfYmFja3VwX2FyY2hpdmVyLmMKaW5kZXggYjhiMDc1NjIwNjkuLjIxNTk1ZTZkZDZmIDEwMDY0
NAotLS0gYS9zcmMvYmluL3BnX2R1bXAvcGdfYmFja3VwX2FyY2hpdmVyLmMKKysrIGIvc3JjL2Jp
bi9wZ19kdW1wL3BnX2JhY2t1cF9hcmNoaXZlci5jCkBAIC0xMjY4LDcgKzEyNjgsNyBAQCBBcmNo
aXZlRW50cnkoQXJjaGl2ZSAqQUhYLCBDYXRhbG9nSWQgY2F0YWxvZ0lkLCBEdW1wSWQgZHVtcElk
LAogCiAvKiBQdWJsaWMgKi8KIHZvaWQKLVByaW50VE9DU3VtbWFyeShBcmNoaXZlICpBSFgsIGJv
b2wgYXBwZW5kX2RhdGEpCitQcmludFRPQ1N1bW1hcnkoQXJjaGl2ZSAqQUhYKQogewogCUFyY2hp
dmVIYW5kbGUgKkFIID0gKEFyY2hpdmVIYW5kbGUgKikgQUhYOwogCVJlc3RvcmVPcHRpb25zICpy
b3B0ID0gQUgtPnB1YmxpYy5yb3B0OwpAQCAtMTI4NCw3ICsxMjg0LDcgQEAgUHJpbnRUT0NTdW1t
YXJ5KEFyY2hpdmUgKkFIWCwgYm9vbCBhcHBlbmRfZGF0YSkKIAogCXNhdiA9IFNhdmVPdXRwdXQo
QUgpOwogCWlmIChyb3B0LT5maWxlbmFtZSkKLQkJU2V0T3V0cHV0KEFILCByb3B0LT5maWxlbmFt
ZSwgb3V0X2NvbXByZXNzaW9uX3NwZWMsIGFwcGVuZF9kYXRhKTsKKwkJU2V0T3V0cHV0KEFILCBy
b3B0LT5maWxlbmFtZSwgb3V0X2NvbXByZXNzaW9uX3NwZWMsIGZhbHNlKTsKIAogCWlmIChzdHJm
dGltZShzdGFtcF9zdHIsIHNpemVvZihzdGFtcF9zdHIpLCBQR0RVTVBfU1RSRlRJTUVfRk1ULAog
CQkJCSBsb2NhbHRpbWUoJkFILT5jcmVhdGVEYXRlKSkgPT0gMCkKZGlmZiAtLWdpdCBhL3NyYy9i
aW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMgYi9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCmlu
ZGV4IDhhNzhhNTJmYjA5Li41Mjk1MTI5MzEzYiAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ19kdW1w
L3BnX3Jlc3RvcmUuYworKysgYi9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCkBAIC0xMjIs
NyArMTIyLDcgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAJYm9vbAkJZGF0YV9vbmx5
ID0gZmFsc2U7CiAJYm9vbAkJc2NoZW1hX29ubHkgPSBmYWxzZTsKIAlpbnQJCQluX2Vycm9ycyA9
IDA7Ci0JYm9vbAkJCQlnbG9iYWxzX29ubHkgPSBmYWxzZTsKKwlib29sCQlnbG9iYWxzX29ubHkg
PSBmYWxzZTsKIAlTaW1wbGVTdHJpbmdMaXN0CWRiX2V4Y2x1ZGVfcGF0dGVybnMgPSB7TlVMTCwg
TlVMTH07CiAKIAlzdHJ1Y3Qgb3B0aW9uIGNtZG9wdHNbXSA9IHsKQEAgLTU1OSwxNCArNTU5LDEz
IEBAIG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICogVGhpcyB3aWxsIHJlc3RvcmUgb25l
IGRhdGFiYXNlIHVzaW5nIHRvYy5kYXQgZmlsZS4KICAqIGRibmFtZSBpcyB0aGUgY3VycmVudCB0
byBiZSByZXN0b3JlZCBkYXRhYmFzZSBuYW1lLgogICoKLSAqIHJldHVybnMsIG51bWJlciBvZiBl
cnJvcnMgd2hpbGUgZG9pbmcgcmVzdG9yZS4KKyAqIHJldHVybnMgdGhlIG51bWJlciBvZiBlcnJv
cnMgd2hpbGUgZG9pbmcgcmVzdG9yZS4KICAqLwogc3RhdGljIGludAogcmVzdG9yZU9uZURhdGFi
YXNlKGNvbnN0IGNoYXIgKmlucHV0RmlsZVNwZWMsIFJlc3RvcmVPcHRpb25zICpvcHRzLAogCQkJ
CSAgIGludCBudW1Xb3JrZXJzLCBib29sIGFwcGVuZF9kYXRhLCBjb25zdCBjaGFyICpkYm5hbWUp
CiB7CiAJQXJjaGl2ZQkJKkFIOwotCWludAkJCW5fZXJyb3JzID0gMDsKIAogCUFIID0gT3BlbkFy
Y2hpdmUoaW5wdXRGaWxlU3BlYywgb3B0cy0+Zm9ybWF0KTsKIApAQCAtNTkzLDIxICs1OTIsMTcg
QEAgcmVzdG9yZU9uZURhdGFiYXNlKGNvbnN0IGNoYXIgKmlucHV0RmlsZVNwZWMsIFJlc3RvcmVP
cHRpb25zICpvcHRzLAogCUFILT5udW1Xb3JrZXJzID0gbnVtV29ya2VyczsKIAogCWlmIChvcHRz
LT50b2NTdW1tYXJ5KQotCQlQcmludFRPQ1N1bW1hcnkoQUgsIGFwcGVuZF9kYXRhKTsKKwkJUHJp
bnRUT0NTdW1tYXJ5KEFIKTsKIAllbHNlCiAJewogCQlQcm9jZXNzQXJjaGl2ZVJlc3RvcmVPcHRp
b25zKEFIKTsKIAkJUmVzdG9yZUFyY2hpdmUoQUgsIGFwcGVuZF9kYXRhKTsKIAl9CiAKLQkvKiBy
ZXR1cm4gbnVtYmVyIG9mIGVycm9ycyAqLwotCWlmIChBSC0+bl9lcnJvcnMpCi0JCW5fZXJyb3Jz
ID0gQUgtPm5fZXJyb3JzOwotCiAJLyogQUggbWF5IGJlIGZyZWVkIGluIENsb3NlQXJjaGl2ZT8g
Ki8KIAlDbG9zZUFyY2hpdmUoQUgpOwogCi0JcmV0dXJuIG5fZXJyb3JzOworCXJldHVybiBBSC0+
bl9lcnJvcnM7CiB9CiAKIHN0YXRpYyB2b2lkCkBAIC0xMTYzLDcgKzExNTgsNyBAQCByZXN0b3Jl
QWxsRGF0YWJhc2VzKFBHY29ubiAqY29ubiwgY29uc3QgY2hhciAqZHVtcGRpcnBhdGgsCiAJCWlm
IChuX2Vycm9ycykKIAkJewogCQkJbl9lcnJvcnNfdG90YWwgKz0gbl9lcnJvcnM7Ci0JCQlwZ19s
b2dfd2FybmluZygiZXJyb3JzIGlnbm9yZWQgb24gXCIlc1wiIGRhdGFiYXNlIHJlc3RvcmU6ICVk
IiwgZGJvaWRfY2VsbC0+ZGJfbmFtZSwgbl9lcnJvcnMpOworCQkJcGdfbG9nX3dhcm5pbmcoImVy
cm9ycyBpZ25vcmVkIG9uIGRhdGFiYXNlIFwiJXNcIiByZXN0b3JlOiAlZCIsIGRib2lkX2NlbGwt
PmRiX25hbWUsIG5fZXJyb3JzKTsKIAkJfQogCiAJCWRib2lkX2NlbGwgPSBkYm9pZF9jZWxsLT5u
ZXh0OwpAQCAtMTE5Myw3ICsxMTg4LDcgQEAgcmVzdG9yZUFsbERhdGFiYXNlcyhQR2Nvbm4gKmNv
bm4sIGNvbnN0IGNoYXIgKmR1bXBkaXJwYXRoLAogICogU2VtaWNvbG9uIGlzIGNvbnNpZGVyZWQg
YXMgc3RhdGVtZW50IHRlcm1pbmF0b3IuICBJZiBvdXRmaWxlIGlzIHBhc3NlZCwgdGhlbgogICog
dGhpcyB3aWxsIGNvcHkgYWxsIHNxbCBjb21tYW5kcyBpbnRvIG91dGZpbGUgcmF0aGVyIHRoZW4g
ZXhlY3V0aW5nIHRoZW0uCiAgKgotICogcmV0dXJucywgbnVtYmVyIG9mIGVycm9ycyB3aGlsZSBw
cm9jZXNzaW5nIGdsb2JhbC5kYXQKKyAqIHJldHVybnMgdGhlIG51bWJlciBvZiBlcnJvcnMgd2hp
bGUgcHJvY2Vzc2luZyBnbG9iYWwuZGF0CiAgKi8KIHN0YXRpYyBpbnQKIHByb2Nlc3NfZ2xvYmFs
X3NxbF9jb21tYW5kcyhQR2Nvbm4gKmNvbm4sIGNvbnN0IGNoYXIgKmR1bXBkaXJwYXRoLCBjb25z
dCBjaGFyICpvdXRmaWxlKQo=
--000000000000b56812062e8f5c02--