MIME-Version: 1.0
References: 
 <CACJufxHs1Hs00EqsZ4NbuAjmYzMzjJyP1sAj12Ne=cBsEVmQOA@mail.gmail.com>
 <CALdSSPiRHCyC0fYy_E=gO+c7sbwU=7=Fz2CF-4aEa3mAe7yYAg@mail.gmail.com>
 <CACJufxGjgdWnhq5X5VL9orLXyKx-ZayT_Zj_-bAKr=kf0pZ_Nw@mail.gmail.com>
 <CA+renyXkcs=5P3dd=OoyM+A=UKA7iR_zS4TAQ42F9NTv+2RNiA@mail.gmail.com>
In-Reply-To: 
 <CA+renyXkcs=5P3dd=OoyM+A=UKA7iR_zS4TAQ42F9NTv+2RNiA@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Fri, 17 Apr 2026 11:20:08 +0800
Message-ID: 
 <CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg@mail.gmail.com>
Subject: Re: DELETE/UPDATE FOR PORTION OF with rule system is not working
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: Kirill Reshke <reshkekirill@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Type: multipart/mixed; boundary="00000000000042e56d064f9f6f8e"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxFSTwzJxFYwD5mb5hSj9CvZxBh500Sza0CKoFCxB6iLsg%40mail.gmail.com>
Precedence: bulk

--00000000000042e56d064f9f6f8e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 16, 2026 at 6:40=E2=80=AFAM Paul A Jungwirth
<pj@illuminatedcomputing.com> wrote:
>
> I only have two small suggestions:
>
> Please use '[1, 11)' syntax to match the other tests.
>
> Breaking these long lines would be nice. For example:
>
> +CREATE RULE fpo_rule1 AS ON INSERT TO fpo_rule
> +  DO INSTEAD UPDATE fpo_rule FOR PORTION OF f2 FROM 1 TO 4 SET f1 =3D 2;
>
Please check the attached v2.

V1 only has DO INSTEAD rules, adding one DO ALSO rule would make the
test coverage more robust.


--
jian
https://www.enterprisedb.com/

--00000000000042e56d064f9f6f8e
Content-Type: text/x-patch; charset="US-ASCII";
	name="v2-0001-fix-DELETE-UPDATE-FOR-PORTION-OF-with-rules.patch"
Content-Disposition: attachment;
	filename="v2-0001-fix-DELETE-UPDATE-FOR-PORTION-OF-with-rules.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mo2cbeh60>
X-Attachment-Id: f_mo2cbeh60

RnJvbSAyYjliMDRjOTY2OGM5YTYxN2U5YmNlZWJlMjk1NjEzM2MyMzIzZmZlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IEZyaSwgMTcgQXByIDIwMjYgMTE6MTM6MDAgKzA4MDAKU3ViamVjdDogW1BBVENIIHYy
IDEvMV0gZml4IERFTEVURS9VUERBVEUgRk9SIFBPUlRJT04gT0Ygd2l0aCBydWxlcwoKQXV0aG9y
OiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+ClJldmlld2VkLWJ5OiBLaXJp
bGwgUmVzaGtlIDxyZXNoa2VraXJpbGxAZ21haWwuY29tPgpSZXZpZXdlZC1ieTogUGF1bCBBIEp1
bmd3aXJ0aCA8cGpAaWxsdW1pbmF0ZWRjb21wdXRpbmcuY29tPgoKRGlzY3Vzc2lvbjogaHR0cHM6
Ly9wb3N0Z3IuZXMvbS9DQUNKdWZ4SHMxSHMwMEVxc1o0TmJ1QWptWXpNempKeVAxc0FqMTJOZT1j
QnNFVm1RT0FAbWFpbC5nbWFpbC5jb20KLS0tCiBzcmMvYmFja2VuZC9ub2Rlcy9ub2RlRnVuY3Mu
YyAgICAgICAgICAgICAgICB8ICA0ICsrCiBzcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2Zvcl9w
b3J0aW9uX29mLm91dCB8IDU1ICsrKysrKysrKysrKysrKysrKysrCiBzcmMvdGVzdC9yZWdyZXNz
L3NxbC9mb3JfcG9ydGlvbl9vZi5zcWwgICAgICB8IDMzICsrKysrKysrKysrKwogMyBmaWxlcyBj
aGFuZ2VkLCA5MiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvbm9kZXMv
bm9kZUZ1bmNzLmMgYi9zcmMvYmFja2VuZC9ub2Rlcy9ub2RlRnVuY3MuYwppbmRleCBjMGI4ODBl
YzIzMy4uN2VkYmQ1YjcyMjUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL25vZGVzL25vZGVGdW5j
cy5jCisrKyBiL3NyYy9iYWNrZW5kL25vZGVzL25vZGVGdW5jcy5jCkBAIC0yNTgzLDYgKzI1ODMs
OCBAQCBleHByZXNzaW9uX3RyZWVfd2Fsa2VyX2ltcGwoTm9kZSAqbm9kZSwKIAkJCXsKIAkJCQlG
b3JQb3J0aW9uT2ZFeHByICpmb3JQb3J0aW9uT2YgPSAoRm9yUG9ydGlvbk9mRXhwciAqKSBub2Rl
OwogCisJCQkJaWYgKFdBTEsoZm9yUG9ydGlvbk9mLT5yYW5nZVZhcikpCisJCQkJCXJldHVybiB0
cnVlOwogCQkJCWlmIChXQUxLKGZvclBvcnRpb25PZi0+dGFyZ2V0RnJvbSkpCiAJCQkJCXJldHVy
biB0cnVlOwogCQkJCWlmIChXQUxLKGZvclBvcnRpb25PZi0+dGFyZ2V0VG8pKQpAQCAtMjU5MSw2
ICsyNTkzLDggQEAgZXhwcmVzc2lvbl90cmVlX3dhbGtlcl9pbXBsKE5vZGUgKm5vZGUsCiAJCQkJ
CXJldHVybiB0cnVlOwogCQkJCWlmIChXQUxLKGZvclBvcnRpb25PZi0+b3ZlcmxhcHNFeHByKSkK
IAkJCQkJcmV0dXJuIHRydWU7CisJCQkJaWYgKFdBTEsoZm9yUG9ydGlvbk9mLT5yYW5nZVRhcmdl
dExpc3QpKQorCQkJCQlyZXR1cm4gdHJ1ZTsKIAkJCX0KIAkJCWJyZWFrOwogCQljYXNlIFRfUGFy
dGl0aW9uUHJ1bmVTdGVwT3A6CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVk
L2Zvcl9wb3J0aW9uX29mLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZm9yX3BvcnRp
b25fb2Yub3V0CmluZGV4IDMxZjc3MmM3MjNkLi4wYzBhMjA1YzQ0YiAxMDA2NDQKLS0tIGEvc3Jj
L3Rlc3QvcmVncmVzcy9leHBlY3RlZC9mb3JfcG9ydGlvbl9vZi5vdXQKKysrIGIvc3JjL3Rlc3Qv
cmVncmVzcy9leHBlY3RlZC9mb3JfcG9ydGlvbl9vZi5vdXQKQEAgLTIwOTcsNCArMjA5Nyw1OSBA
QCBTRUxFQ1QgKiBGUk9NIHRlbXBvcmFsX3BhcnRpdGlvbmVkXzUgT1JERVIgQlkgaWQsIHZhbGlk
X2F0OwogKDQgcm93cykKIAogRFJPUCBUQUJMRSB0ZW1wb3JhbF9wYXJ0aXRpb25lZDsKKy0tIFVQ
REFURS9ERUxFVEUgRk9SIFBPUlRJT04gT0Ygd2l0aCBSVUxFcworQ1JFQVRFIFRBQkxFIGZwb19y
dWxlIChmMSBiaWdpbnQsIGYyIGludDRyYW5nZSk7CitJTlNFUlQgSU5UTyBmcG9fcnVsZSBWQUxV
RVMgKDEsICdbMSwgMTEpJyk7CitDUkVBVEUgUlVMRSBmcG9fcnVsZTEgQVMgT04gSU5TRVJUIFRP
IGZwb19ydWxlCisgIERPIElOU1RFQUQgVVBEQVRFIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYy
IEZST00gMSBUTyA0IFNFVCBmMSA9IDI7CitJTlNFUlQgSU5UTyBmcG9fcnVsZSBWQUxVRVMgKDEs
ICdbMSwgMTEpJyk7CitTRUxFQ1QgKiBGUk9NIGZwb19ydWxlIE9SREVSIEJZIGYxOworIGYxIHwg
ICBmMiAgIAorLS0tLSstLS0tLS0tLQorICAxIHwgWzQsMTEpCisgIDIgfCBbMSw0KQorKDIgcm93
cykKKworQ1JFQVRFIFJVTEUgZnBvX3J1bGUyIEFTIE9OIElOU0VSVCBUTyBmcG9fcnVsZQorICBE
TyBJTlNURUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gMSBU
TyA0OworSU5TRVJUIElOVE8gZnBvX3J1bGUgVkFMVUVTICgxLCAnWzEsIDExKScpOworU0VMRUNU
ICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKyBmMSB8ICAgZjIgICAKKy0tLS0rLS0tLS0t
LS0KKyAgMSB8IFs0LDExKQorKDEgcm93KQorCitDUkVBVEUgUlVMRSBmcG9fcnVsZTMgQVMgT04g
REVMRVRFIFRPIGZwb19ydWxlCisgIERPIElOU1RFQUQgVVBEQVRFIGZwb19ydWxlIEZPUiBQT1JU
SU9OIE9GIGYyIEZST00gMSBUTyA4IFNFVCBmMSA9IDI7CitERUxFVEUgRlJPTSBmcG9fcnVsZSBG
T1IgUE9SVElPTiBPRiBmMiBGUk9NIDEgVE8gNTsKK1NFTEVDVCAqIEZST00gZnBvX3J1bGUgT1JE
RVIgQlkgZjE7CisgZjEgfCAgIGYyICAgCistLS0tKy0tLS0tLS0tCisgIDEgfCBbOCwxMSkKKyAg
MiB8IFs0LDgpCisoMiByb3dzKQorCitEUk9QIFJVTEUgZnBvX3J1bGUzIE9OIGZwb19ydWxlOwor
Q1JFQVRFIFJVTEUgZnBvX3J1bGU0IEFTIE9OIFVQREFURSBUTyBmcG9fcnVsZQorICBETyBJTlNU
RUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gNiBUTyA5Owor
VVBEQVRFIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gNCBUTyA5IFNFVCBmMSA9IDEy
OworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKyBmMSB8ICAgZjIgICAKKy0t
LS0rLS0tLS0tLS0KKyAgMSB8IFs5LDExKQorICAyIHwgWzQsNikKKygyIHJvd3MpCisKK0RST1Ag
UlVMRSBmcG9fcnVsZTQgT04gZnBvX3J1bGU7CitDUkVBVEUgUlVMRSBmcG9fcnVsZTUgQVMgT04g
VVBEQVRFIFRPIGZwb19ydWxlCisgIERPIEFMU08gREVMRVRFIEZST00gZnBvX3J1bGUgRk9SIFBP
UlRJT04gT0YgZjIgRlJPTSA0IFRPIDY7CitVUERBVEUgZnBvX3J1bGUgRk9SIFBPUlRJT04gT0Yg
ZjIgRlJPTSA5IFRPIDEwIFNFVCBmMSA9IDM7CitTRUxFQ1QgKiBGUk9NIGZwb19ydWxlIE9SREVS
IEJZIGYxOworIGYxIHwgICBmMiAgICAKKy0tLS0rLS0tLS0tLS0tCisgIDEgfCBbMTAsMTEpCisg
IDMgfCBbOSwxMCkKKygyIHJvd3MpCisKK0RST1AgVEFCTEUgZnBvX3J1bGU7CiBSRVNFVCBkYXRl
c3R5bGU7CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3JfcG9ydGlvbl9vZi5z
cWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3JfcG9ydGlvbl9vZi5zcWwKaW5kZXggZDQwNjJh
Y2YxZDEuLmZkNzlhOWI3OGU3IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3Jf
cG9ydGlvbl9vZi5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZm9yX3BvcnRpb25fb2Yu
c3FsCkBAIC0xMzY1LDQgKzEzNjUsMzcgQEAgU0VMRUNUICogRlJPTSB0ZW1wb3JhbF9wYXJ0aXRp
b25lZF81IE9SREVSIEJZIGlkLCB2YWxpZF9hdDsKIAogRFJPUCBUQUJMRSB0ZW1wb3JhbF9wYXJ0
aXRpb25lZDsKIAorLS0gVVBEQVRFL0RFTEVURSBGT1IgUE9SVElPTiBPRiB3aXRoIFJVTEVzCitD
UkVBVEUgVEFCTEUgZnBvX3J1bGUgKGYxIGJpZ2ludCwgZjIgaW50NHJhbmdlKTsKK0lOU0VSVCBJ
TlRPIGZwb19ydWxlIFZBTFVFUyAoMSwgJ1sxLCAxMSknKTsKKworQ1JFQVRFIFJVTEUgZnBvX3J1
bGUxIEFTIE9OIElOU0VSVCBUTyBmcG9fcnVsZQorICBETyBJTlNURUFEIFVQREFURSBmcG9fcnVs
ZSBGT1IgUE9SVElPTiBPRiBmMiBGUk9NIDEgVE8gNCBTRVQgZjEgPSAyOworSU5TRVJUIElOVE8g
ZnBvX3J1bGUgVkFMVUVTICgxLCAnWzEsIDExKScpOworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBP
UkRFUiBCWSBmMTsKKworQ1JFQVRFIFJVTEUgZnBvX3J1bGUyIEFTIE9OIElOU0VSVCBUTyBmcG9f
cnVsZQorICBETyBJTlNURUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYy
IEZST00gMSBUTyA0OworSU5TRVJUIElOVE8gZnBvX3J1bGUgVkFMVUVTICgxLCAnWzEsIDExKScp
OworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKworQ1JFQVRFIFJVTEUgZnBv
X3J1bGUzIEFTIE9OIERFTEVURSBUTyBmcG9fcnVsZQorICBETyBJTlNURUFEIFVQREFURSBmcG9f
cnVsZSBGT1IgUE9SVElPTiBPRiBmMiBGUk9NIDEgVE8gOCBTRVQgZjEgPSAyOworREVMRVRFIEZS
T00gZnBvX3J1bGUgRk9SIFBPUlRJT04gT0YgZjIgRlJPTSAxIFRPIDU7CitTRUxFQ1QgKiBGUk9N
IGZwb19ydWxlIE9SREVSIEJZIGYxOworCitEUk9QIFJVTEUgZnBvX3J1bGUzIE9OIGZwb19ydWxl
OworQ1JFQVRFIFJVTEUgZnBvX3J1bGU0IEFTIE9OIFVQREFURSBUTyBmcG9fcnVsZQorICBETyBJ
TlNURUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gNiBUTyA5
OworVVBEQVRFIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gNCBUTyA5IFNFVCBmMSA9
IDEyOworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKworRFJPUCBSVUxFIGZw
b19ydWxlNCBPTiBmcG9fcnVsZTsKK0NSRUFURSBSVUxFIGZwb19ydWxlNSBBUyBPTiBVUERBVEUg
VE8gZnBvX3J1bGUKKyAgRE8gQUxTTyBERUxFVEUgRlJPTSBmcG9fcnVsZSBGT1IgUE9SVElPTiBP
RiBmMiBGUk9NIDQgVE8gNjsKK1VQREFURSBmcG9fcnVsZSBGT1IgUE9SVElPTiBPRiBmMiBGUk9N
IDkgVE8gMTAgU0VUIGYxID0gMzsKK1NFTEVDVCAqIEZST00gZnBvX3J1bGUgT1JERVIgQlkgZjE7
CisKK0RST1AgVEFCTEUgZnBvX3J1bGU7CisKIFJFU0VUIGRhdGVzdHlsZTsKLS0gCjIuMzQuMQoK
--00000000000042e56d064f9f6f8e--