MIME-Version: 1.0
References: <bee34abe-fe87-49b3-8523-8ae19e641ccf@yandex.ru>
 <ff99283d-f9d4-4b37-b4fa-3a433fb408a4@tantorlabs.com> <e1f5b560691a4fe693625d529e19e13959210568.camel@moonset.ru>
 <53c47c2d-72a5-44f2-900c-9973b2af1808@tantorlabs.com> <c82e7776-7841-42a0-9247-878584174750@tantorlabs.com>
 <4a902cea-54fb-41b5-b208-b84731a5f577@postgrespro.ru> <CACJufxHb_YGCp=pVH6DZcpk9yML+SueffPeaRbX2LzXZVahd_w@mail.gmail.com>
 <CACJufxE6yAP+jUm4_GyKp7gUCkzbuJ9HGB-rR=92_hcLLZ9KTg@mail.gmail.com>
 <092adec6-4eae-4bd4-bd0d-473a9df1282b@tantorlabs.com> <3deae1bd-ad84-4459-a26e-04c9136b84e9@postgrespro.ru>
 <CAPpHfdug0s2MD7bBf-5nDQGn1WBxCKiTmZyGfxHz_7P0CDOjbg@mail.gmail.com>
 <c4e4e305-7119-4183-b49a-d7092f4efba3@postgrespro.ru> <f05a9031-f923-41b1-9bf9-81204cb56561@postgrespro.ru>
In-Reply-To: <f05a9031-f923-41b1-9bf9-81204cb56561@postgrespro.ru>
From: jian he <jian.universality@gmail.com>
Date: Thu, 5 Sep 2024 20:47:00 +0800
Message-ID: <CACJufxFU4ej3iGtGg3GDqmGzRmTVq3d9RGq+ibLfQoS8E3hJEQ@mail.gmail.com>
Subject: Re: Vacuum statistics
To: Alena Rybakina <a.rybakina@postgrespro.ru>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, 
	Andrei Zubkov <zubkov@moonset.ru>, Alena Rybakina <lena.ribackina@yandex.ru>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>, a.lepikhov@postgrespro.ru
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CACJufxFU4ej3iGtGg3GDqmGzRmTVq3d9RGq%2BibLfQoS8E3hJEQ%40mail.gmail.com>
Precedence: bulk

On Thu, Sep 5, 2024 at 1:23=E2=80=AFAM Alena Rybakina <a.rybakina@postgresp=
ro.ru> wrote:
>
> Hi, all!
>
> I have attached the new version of the code and the diff files
> (minor-vacuum.no-cbot).
>

hi.

still have white space issue when using "git apply",
you may need to use "git diff --check" to find out where.


 /* ----------
diff --git a/src/test/regress/expected/opr_sanity.out
b/src/test/regress/expected/opr_sanity.out
index 5d72b970b03..7026de157e4 100644
--- a/src/test/regress/expected/opr_sanity.out
+++ b/src/test/regress/expected/opr_sanity.out
@@ -32,11 +32,12 @@ WHERE p1.prolang =3D 0 OR p1.prorettype =3D 0 OR
        prokind NOT IN ('f', 'a', 'w', 'p') OR
        provolatile NOT IN ('i', 's', 'v') OR
        proparallel NOT IN ('s', 'r', 'u');
- oid  |        proname
-------+------------------------
+ oid  |         proname
+------+-------------------------
  8001 | pg_stat_vacuum_tables
  8002 | pg_stat_vacuum_indexes
-(2 rows)
+ 8003 | pg_stat_vacuum_database
+(3 rows)


looking at src/test/regress/sql/opr_sanity.sql:

-- **************** pg_proc ****************
-- Look for illegal values in pg_proc fields.

SELECT p1.oid, p1.proname
FROM pg_proc as p1
WHERE p1.prolang =3D 0 OR p1.prorettype =3D 0 OR
       p1.pronargs < 0 OR
       p1.pronargdefaults < 0 OR
       p1.pronargdefaults > p1.pronargs OR
       array_lower(p1.proargtypes, 1) !=3D 0 OR
       array_upper(p1.proargtypes, 1) !=3D p1.pronargs-1 OR
       0::oid =3D ANY (p1.proargtypes) OR
       procost <=3D 0 OR
       CASE WHEN proretset THEN prorows <=3D 0 ELSE prorows !=3D 0 END OR
       prokind NOT IN ('f', 'a', 'w', 'p') OR
       provolatile NOT IN ('i', 's', 'v') OR
       proparallel NOT IN ('s', 'r', 'u');

that means
 oid  |         proname
------+-------------------------
 8001 | pg_stat_vacuum_tables
 8002 | pg_stat_vacuum_indexes
 8003 | pg_stat_vacuum_database


These above functions, pg_proc.prorows should > 0 when
pg_proc.proretset is true.
I think that's the opr_sanity test's intention.
so you may need to change pg_proc.dat.

BTW the doc says:
prorows float4, Estimated number of result rows (zero if not proretset)


segmentation fault cases:
select * from pg_stat_vacuum_indexes(0);
select * from pg_stat_vacuum_tables(0);


+ else if (type =3D=3D PGSTAT_EXTVAC_DB)
+ {
+ PgStatShared_Database   *dbentry;
+ PgStat_EntryRef   *entry_ref;
+ Oid dbid =3D PG_GETARG_OID(0);
+
+ if (OidIsValid(dbid))
+ {
+ entry_ref =3D pgstat_get_entry_ref_locked(PGSTAT_KIND_DATABASE,
+ dbid, InvalidOid, false);
+ dbentry =3D (PgStatShared_Database *) entry_ref->shared_stats;
+
+ if (dbentry =3D=3D NULL)
+ /* Table doesn't exist or isn't a heap relation */
+ return;
+
+ tuplestore_put_for_database(dbid, rsinfo, dbentry);
+ pgstat_unlock_entry(entry_ref);
+ }
+ }
didn't error out when dbid is invalid?


pg_stat_vacuum_tables
pg_stat_vacuum_indexes
pg_stat_vacuum_database
these functions didn't verify the only input argument oid's kind.
for example:

create table s(a int primary key) with (autovacuum_enabled =3D off);
create view sv as select * from s;
vacuum s;
select * from pg_stat_vacuum_tables('sv'::regclass::oid);
select * from pg_stat_vacuum_indexes('sv'::regclass::oid);
select * from pg_stat_vacuum_database('sv'::regclass::oid);

above all these 3 examples should error out? because  sv is view.

in src/backend/catalog/system_views.sql
for view creation of pg_stat_vacuum_indexes
you can change to

WHERE
  db.datname =3D current_database() AND
  rel.oid =3D stats.relid AND
  ns.oid =3D rel.relnamespace
AND rel.relkind =3D 'i':


pg_stat_vacuum_tables  in in src/backend/catalog/system_views.sql
you can change to

WHERE
  db.datname =3D current_database() AND
  rel.oid =3D stats.relid AND
  ns.oid =3D rel.relnamespace
AND rel.relkind =3D 'r':