Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smCsk-004273-K9 for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Sep 2024 13:50:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1smCsi-00AxkX-CW for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Sep 2024 13:50:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smCsi-00AxkP-2X for pgsql-hackers@lists.postgresql.org; Thu, 05 Sep 2024 13:50:40 +0000 Received: from mail-vk1-xa36.google.com ([2607:f8b0:4864:20::a36]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1smCsg-000HiV-6P for pgsql-hackers@postgresql.org; Thu, 05 Sep 2024 13:50:39 +0000 Received: by mail-vk1-xa36.google.com with SMTP id 71dfb90a1353d-4fcf40c9ed3so308852e0c.2 for ; Thu, 05 Sep 2024 06:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725544237; x=1726149037; darn=postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=UrJ9rTPJ9FinyMYED3yugOidZ4KIsrrNwsGDBAg/yx0=; b=KpoIyDcNZB8PaDjXPiRMPAJL/sf8YM+jqDXgECI6P7g3xLxPsEGhxj+e0S9mrQ5srY 9Wks0VNaWEDIQ1Y2obPWXw+IIzEFwmYq0ut8crpDGCb7EICXkDEKu5NZucD0uFnIIFrq sqQNhJeyf3jp11RzL7tMh2G//G2/zhMH6x40zck6Ns3CWDTVuLXAEU3HH0jmQf14HitD ol6OM+YG6PbP/17P2ihfw66vTS0HKyMFCHBftM0zZHu7SCKhvIPu+69gghS1mQ+KSPw5 oxED0SNgp9dEB7/TZxz1MmmvKgECFH7/GvwYIwKAtS+z27E/l8o8ugdnOIN9CxM60Few g0QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725544237; x=1726149037; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UrJ9rTPJ9FinyMYED3yugOidZ4KIsrrNwsGDBAg/yx0=; b=Z/yLelUYfBPJ4MLPQ/H8U5A+TOU2ASfqMUINwwqhAz5bENp8fWLzi07Q/wlBnYjZyV DHVTza+dn+/TK2yQop3J0drecxSGUewXKtDs/ZhgSzECvxCorRp9EA6BNZkXbgwaYXVz /uGxD7nIV209ITELKJ8PNzRXQAF7vBktUIHMG1vGxl6pRXYevrNF69ZPFTgMcWlUw7XJ yEdpaRvbQQdAhV8Isrjo5xWhSZ71wB43CPqOtauZBnyjJLK+zjj9W9Hg0XtGwaIdjtsg U+6pMbfqLkPY6ZUJVr7A73rZxTWDeFUMiCo7l4gqqmCB7fdBHmnfQlycErqlzo8MrSFQ M9hw== X-Gm-Message-State: AOJu0Yy8W97907G0RPHVTt1xdEkCdz1aTQGaQ9ybkcFhG4jjMkgeHGr9 vo1NYA9RNn7DMsYvkoxc4Du5wRsuqAkJCKymWHJPzNdPY76s4yetvonomWXJpl7QvSJ5HqY9ed2 s6vHBvEyVv+DWhebPssxAijp0n6uCPARRsi0= X-Google-Smtp-Source: AGHT+IFFZIJhfpP8tH/oSpzX7V3jEDJ++6eb5ElRzHlL9ARrlB6UzLhTl4UG4SYnHg1vUv/M0f2si2nn2dlof+fNm50= X-Received: by 2002:a05:6122:16aa:b0:4ef:280f:96ea with SMTP id 71dfb90a1353d-500d5bf0de3mr13676883e0c.4.1725544237139; Thu, 05 Sep 2024 06:50:37 -0700 (PDT) MIME-Version: 1.0 From: jian he Date: Thu, 5 Sep 2024 21:50:26 +0800 Message-ID: Subject: ATExecColumnDefault comments To: PostgreSQL-development Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk hi. one minor issue for ATExecColumnDefault comments. /* * ALTER TABLE ALTER COLUMN SET/DROP DEFAULT * * Return the address of the affected column. */ static ObjectAddress ATExecColumnDefault(Relation rel, const char *colName, Node *newDefault, LOCKMODE lockmode) the comment should be: * ALTER TABLE ALTER COLUMN SET/DROP DEFAULT * ALTER VIEW ALTER COLUMN SET/DROP DEFAULT ? Sometimes, comments are useful for quickly glance at what this function does. Therefore I guess reword it would be helpful.