MIME-Version: 1.0
References: <567ED6CA.2040504@sigaev.ru>
 <CAPpHfdt58O5jzKMjkScNbGecM5JqfaMfdGLjs4rk5XisfjTNBw@mail.gmail.com>
 <16a7e3aa-24c0-4986-8820-ea2857bd7b6b@postgrespro.ru>
 <421656a9-5df7-41bb-9d58-1c1edbd5dc3e@postgrespro.ru>
 <28c727ba-5260-42a8-88b0-4ecdeeca6ef8@postgrespro.ru>
 <4c1c2c0b-802f-45ae-a7cd-007bfd8957cf@postgrespro.ru>
 <52f0d302-7963-452f-8c5a-f66d261514eb@postgrespro.ru>
 <43ad8a48-b980-410d-a83c-5beebf82a4ed@postgrespro.ru>
 <b5a5b515-6f38-431a-98b8-d30abae62fde@postgrespro.ru>
 <be8ae03d-9eb3-4adb-beb8-3b356b3c68bb@postgrespro.ru>
 <CAPpHfdu-_j6=E9CHjSGu0=SidfTqdtj7qk78dCdW-=4RFDHBDw@mail.gmail.com>
 <04ef16eb-46c1-4ce7-9f68-d1c80ef0be81@postgrespro.ru>
 <CA+TgmoZCgP6FrBQEusn4yaWm02XU8OPeoEMk91q7PRBgwaAkFw@mail.gmail.com>
 <cfdc7fef-cf0b-437b-89fa-62ffd6677f7d@postgrespro.ru>
 <59e67a40-95a8-4d74-ae4e-027ea0f59084@postgrespro.ru>
 <59b77a8a-29d6-4727-bf26-4a30a6a9719a@postgrespro.ru>
 <32d23d97-d07f-4d44-9933-ba3295fb3ed8@postgrespro.ru>
 <aec17a1a-9de0-4994-8a53-c6b4e64afb17@postgrespro.ru>
 <CACJufxGXhJ823cdAdp2Ho7qC-HZ3_-dtdj-myaAi_u9RQLn45g@mail.gmail.com>
 <CACJufxG=wB6qLbOAWaYEQHccN+qi=6-pw7zKVWZ53ZiDZNRTRA@mail.gmail.com>
In-Reply-To: 
 <CACJufxG=wB6qLbOAWaYEQHccN+qi=6-pw7zKVWZ53ZiDZNRTRA@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 31 Jan 2024 18:15:00 +0800
Message-ID: 
 <CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu+HsVA@mail.gmail.com>
Subject: Re: POC, WIP: OR-clause support for indexes
To: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>,
 Robert Haas <robertmhaas@gmail.com>,
	pgsql-hackers@postgresql.org, Alexander Korotkov <aekorotkov@gmail.com>,
	Peter Geoghegan <pg@bowt.ie>, "Finnerty, Jim" <jfinnert@amazon.com>,
 Marcos Pegoraro <marcos@f10.com.br>, teodor@sigaev.ru,
	Ranier Vilela <ranier.vf@gmail.com>,
 Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Peter Eisentraut <peter@eisentraut.org>
Content-Type: multipart/mixed; boundary="0000000000007d869b06103b2713"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxFrZS07oBHMk1_c8P3A84VZ3ysXiZV8NeU6gAnvu%2BHsVA%40mail.gmail.com>
Precedence: bulk

--0000000000007d869b06103b2713
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024 at 10:55=E2=80=AFAM jian he <jian.universality@gmail.c=
om> wrote:
>
> based on my understanding of
> https://www.postgresql.org/docs/current/xoper-optimization.html#XOPER-COM=
MUTATOR
> I think you need move commutator check right after the `if
> (get_op_rettype(opno) !=3D BOOLOID)` branch
>
I was wrong about this part. sorry for the noise.


I have made some changes (attachment).
* if the operator expression left or right side type category is
{array | domain | composite}, then don't do the transformation.
(i am not 10% sure with composite)

* if the left side of the operator expression node contains volatile
functions, then don't do the transformation.

* some other minor  cosmetic changes.

--0000000000007d869b06103b2713
Content-Type: application/octet-stream; name="v14_comments.no-cfbot"
Content-Disposition: attachment; filename="v14_comments.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_ls1mphkk0>
X-Attachment-Id: f_ls1mphkk0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9leHByLmMgYi9zcmMvYmFja2Vu
ZC9wYXJzZXIvcGFyc2VfZXhwci5jCmluZGV4IDZiNGIwMGViLi5mYjE5OTIzMCAxMDA2NDQKLS0t
IGEvc3JjL2JhY2tlbmQvcGFyc2VyL3BhcnNlX2V4cHIuYworKysgYi9zcmMvYmFja2VuZC9wYXJz
ZXIvcGFyc2VfZXhwci5jCkBAIC0yMDIsNiArMjAyLDcgQEAgdHJhbnNmb3JtQm9vbEV4cHJPcihQ
YXJzZVN0YXRlICpwc3RhdGUsIEJvb2xFeHByICpleHByKQogCQlPckNsYXVzZUdyb3VwS2V5CQlo
YXNoa2V5OwogCQlib29sCQkJCQlmb3VuZDsKIAkJT2lkCQkJCQkJb3BubzsKKwkJVFlQQ0FURUdP
UlkgCQkJY2F0ZWdvcnk7CiAJCU5vZGUJCQkJICAgKmxlZnRvcCwgKnJpZ2h0b3A7CiAKIAkJLyog
QXQgZmlyc3QsIHRyYW5zZm9ybSB0aGUgYXJnIGFuZCBldmFsdWF0ZSBjb25zdGFudCBleHByZXNz
aW9ucy4gKi8KQEAgLTI0Myw3ICsyNDQsNyBAQCB0cmFuc2Zvcm1Cb29sRXhwck9yKFBhcnNlU3Rh
dGUgKnBzdGF0ZSwgQm9vbEV4cHIgKmV4cHIpCiAKIAkJCWlmICghT2lkSXNWYWxpZChvcG5vKSkK
IAkJCXsKLQkJCQkvKiBDb21tdXRlciBkb2Vzbid0IGV4aXN0LCB3ZSBjYW4ndCByZXZlcnNlIHRo
ZSBvcmRlciAqLworCQkJCS8qIGNvbW11dGF0b3IgZG9lc24ndCBleGlzdCwgd2UgY2FuJ3QgcmV2
ZXJzZSB0aGUgb3JkZXIgKi8KIAkJCQlvcl9saXN0ID0gbGFwcGVuZChvcl9saXN0LCBvcnF1YWwp
OwogCQkJCWNvbnRpbnVlOwogCQkJfQpAQCAtMjYyLDYgKzI2MywzMyBAQCB0cmFuc2Zvcm1Cb29s
RXhwck9yKFBhcnNlU3RhdGUgKnBzdGF0ZSwgQm9vbEV4cHIgKmV4cHIpCiAJCQljb250aW51ZTsK
IAkJfQogCisJCS8qIHRyYW5zZm9ybWF0aW9uIG9ubHkgd29ya3Mgd2l0aCBib3RoIHNpZGUgdHlw
ZSBpcyBub3QgeyBhcnJheSB8IGNvbXBvaXN0ZSB8IGRvbWFpbiB9ICovCisJCWNhdGVnb3J5ID0g
VHlwZUNhdGVnb3J5KGV4cHJUeXBlKGNvbnN0X2V4cHIpKTsKKwkJaWYgKGNhdGVnb3J5ID09IFRZ
UENBVEVHT1JZX0FSUkFZIHx8IGNhdGVnb3J5ID09IFRZUFRZUEVfRE9NQUlOCisJCQl8fCBjYXRl
Z29yeSA9PSBUWVBUWVBFX0NPTVBPU0lURSkKKwkJeworCQkJb3JfbGlzdCA9IGxhcHBlbmQob3Jf
bGlzdCwgb3JxdWFsKTsKKwkJCWNvbnRpbnVlOworCQl9CisKKwkJY2F0ZWdvcnkgPSBUeXBlQ2F0
ZWdvcnkoZXhwclR5cGUobmNvbnN0X2V4cHIpKTsKKwkJaWYgKGNhdGVnb3J5ID09IFRZUENBVEVH
T1JZX0FSUkFZIHx8IGNhdGVnb3J5ID09IFRZUFRZUEVfRE9NQUlOCisJCQl8fCBjYXRlZ29yeSA9
PSBUWVBUWVBFX0NPTVBPU0lURSkKKwkJeworCQkJb3JfbGlzdCA9IGxhcHBlbmQob3JfbGlzdCwg
b3JxdWFsKTsKKwkJCWNvbnRpbnVlOworCQl9CisKKwkJLyoKKwkJICogaWYgdGhlIG5vbi1jb25z
dCAobGVmdCBzaWRlIG9mIG9wZXJhdG9yIGV4cHJlc3Npb24pIGNvbnRhaW4gdm9sdGFpbiBmdW5j
dGlvbnMKKwkJICogdGhlbiB3ZSBjYW5ub3QgZG8gdGhlIHRyYW5zZm9ybWF0aW9uCisJCSovCisJ
CWlmIChjb250YWluX3ZvbGF0aWxlX2Z1bmN0aW9ucygoTm9kZSAqKSBuY29uc3RfZXhwcikpCisJ
CXsKKwkJCW9yX2xpc3QgPSBsYXBwZW5kKG9yX2xpc3QsIG9ycXVhbCk7CisJCQljb250aW51ZTsK
KwkJfQorCiAJCS8qCiAJCSogQXQgdGhpcyBwb2ludCB3ZSBkZWZpbml0ZWx5IGhhdmUgYSB0cmFu
c2Zvcm1hYmxlIGNsYXVzZS4KIAkJKiBDbGFzc2lmeSBpdCBhbmQgYWRkIGludG8gc3BlY2lmaWMg
Z3JvdXAgb2YgY2xhdXNlcywgb3IgY3JlYXRlIG5ldwpAQCAtMzMzLDcgKzM2MSw3IEBAIHRyYW5z
Zm9ybUJvb2xFeHByT3IoUGFyc2VTdGF0ZSAqcHN0YXRlLCBCb29sRXhwciAqZXhwcikKIAkJZWxz
ZQogCQkJYXJyYXlfdHlwZSA9IEludmFsaWRPaWQ7CiAKLQkJaWYgKGFycmF5X3R5cGUgIT0gSW52
YWxpZE9pZCkKKwkJaWYgKE9pZElzVmFsaWQoYXJyYXlfdHlwZSkpCiAJCXsKIAkJCS8qCiAJCQkg
KiBPSzogY29lcmNlIGFsbCB0aGUgcmlnaHQtaGFuZCBub24tVmFyIGlucHV0cyB0byB0aGUgY29t
bW9uCkBAIC0zOTIsOCArNDIwLDEwIEBAIHRyYW5zZm9ybUJvb2xFeHByT3IoUGFyc2VTdGF0ZSAq
cHN0YXRlLCBCb29sRXhwciAqZXhwcikKIAkJZWxzZQogCQl7CiAJCQkvKgotCQkJICogVGhpcyBw
YXJ0IHdvcmtzIG9uIGludGFycmF5IHRlc3QgKE9SIHRoZXJlIGlzIG1hZGUgb24KLQkJCSAqIGVs
ZW1lbnRzIG9mIGEgY3VzdG9tIHR5cGUpCisJCQkgKiBJZiB0aGUgY29uc3Qgbm9kZSAocmlnaHQg
c2lkZSBvZiBvcGVyYXRvciBleHByZXNzaW9uKSAncyB0eXBlCisJCQkgKiAgZG9uJ3QgaGF2ZSDi
gJx0cnVl4oCdIGFycmF5IHR5cGUsIHRoZW4gd2UgY2Fubm5vdCBkbyB0aGUgdHJhbnNmb3JtYXRp
b24uCisJCQkgKiBXZSBzaW1wbHkgY29uY2F0ZW5hdGUgdGhlIGV4cHJlc3Npb24gbm9kZS4KKwkJ
CSAqCiAJCQkgKi8KIAkJCWxpc3RfZnJlZShlbnRyeS0+Y29uc3RzKTsKIAkJCW9yX2xpc3QgPSBs
aXN0X2NvbmNhdChvcl9saXN0LCBlbnRyeS0+ZXhwcnMpOwo=
--0000000000007d869b06103b2713--