MIME-Version: 1.0
References: <CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com>
 <CA+renyUMKg4-MyVbAi8Kj12Srd9BkU5Gt3FdbGdNr-ezHpL6cw@mail.gmail.com>
 <5650d77a-1d73-fd8d-4410-8e97dbeff572@illuminatedcomputing.com>
 <CA+renyWqpNdsi9OaPmXheeQL72adi_iz36VgVsqyyGpQ20FDAg@mail.gmail.com>
 <21964319-46e5-3e47-217b-6ac4169bdf13@enterprisedb.com> <CA+renyX0ipvY6A_jUOHeB1q9mL4bEYfAZ5FBB7G7jUo5bykjrA@mail.gmail.com>
 <f42e5be5-cd3e-bc4f-83e4-04a1e0270b17@enterprisedb.com> <27361388-f5ab-ea36-ea35-41d68a90e60d@illuminatedcomputing.com>
 <152e4c2c-36b4-bdc0-1b62-e9f9e8b68adc@enterprisedb.com> <251B44D1-D3E0-47E4-AB9D-4A848EDB495E@yesql.se>
 <1c674adf-4114-e8d8-cec7-ac10e2f424c7@enterprisedb.com> <CA+renyVyMOb+t6QNoq=PBK1CY_oa9wdJrObjj6S1-RK9CxYwKQ@mail.gmail.com>
 <831f17ba-ff36-1380-a475-a7cd2c65a89c@enterprisedb.com> <ab4cf49c-9839-3426-5114-f596fa9ee76b@illuminatedcomputing.com>
 <6f010a6e-8e20-658b-dc05-dc9033a694da@eisentraut.org> <7d44dade-ff31-5eef-80ac-78ed838066f6@postgresfriends.org>
 <88dadcc1-6652-ff7d-264d-73906a53dee9@illuminatedcomputing.com>
 <CACJufxHD2kv6hCy8yjVk486+d5rcuJS2XxkNH80g9Ui6Rz81Cg@mail.gmail.com>
 <CACJufxFTqiag-4fDPWJLxwwX+2gcZZWJPM9GyhPYD0tH=uM+jQ@mail.gmail.com>
 <CA+renyV4RxkWx57Vi5k_k0d7mkT7+F2kHYuKkwNPBaSOCaotFA@mail.gmail.com> <CACJufxG7DKLhyJgBaFttdXZe-4dOVu3NVED+4sdegdGs6R7JdQ@mail.gmail.com>
In-Reply-To: <CACJufxG7DKLhyJgBaFttdXZe-4dOVu3NVED+4sdegdGs6R7JdQ@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Tue, 12 Sep 2023 17:01:36 +0800
Message-ID: <CACJufxFxQH5NxD9UDvbcRCPtaSga+y0+Wwt54PA4KahLwhahOA@mail.gmail.com>
Subject: Re: SQL:2011 application time
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CACJufxFxQH5NxD9UDvbcRCPtaSga%2By0%2BWwt54PA4KahLwhahOA%40mail.gmail.com>
Precedence: bulk

hi. some trivial issue:

in src/backend/catalog/index.c
/* * System attributes are never null, so no need to check. */
if (attnum <= 0)

since you already checked attnum == 0
so here you can just attnum < 0?
-------------------------------------------------
ERROR:  column "valid_at" named in WITHOUT OVERLAPS is not a range type

IMHO, "named" is unnecessary.
-------------------------------------------------
doc/src/sgml/catalogs.sgml
pg_constraint adds another attribute (column): contemporal, seems no doc entry.

also the temporal in oxford definition is "relating to time", here we
can deal with range.
So maybe  "temporal" is not that accurate?