MIME-Version: 1.0
References: 
 <CAKYtNAr7ToCBSLO2Mm6NGFTZvbdTAFNgjv_YoRqJJghC3n1MiQ@mail.gmail.com>
 <202503111705.xy7fddu36qae@alvherre.pgsql>
In-Reply-To: <202503111705.xy7fddu36qae@alvherre.pgsql>
From: jian he <jian.universality@gmail.com>
Date: Wed, 12 Mar 2025 15:03:37 +0800
Message-ID: 
 <CACJufxG44zd+KV4B3_0d+Lf2fwnDDptX-DQRqn-o9ukmXEWeNw@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>,
 Srinath Reddy <srinath2133@gmail.com>,
	pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxG44zd%2BKV4B3_0d%2BLf2fwnDDptX-DQRqn-o9ukmXEWeNw%40mail.gmail.com>
Precedence: bulk

On Wed, Mar 12, 2025 at 1:06=E2=80=AFAM =C3=81lvaro Herrera <alvherre@alvh.=
no-ip.org> wrote:
>
> Hello,
>
> On 2025-Mar-11, Mahendra Singh Thalor wrote:
>
> > In map.dat file, I tried to fix this issue by adding number of characte=
rs
> > in dbname but as per code comments, as of now, we are not supporting \n=
\r
> > in dbnames so i removed handling.
> > I will do some more study to fix this issue.
>
> Yeah, I think this is saying that you should not consider the contents
> of map.dat as a shell string.  After all, you're not going to _execute_
> that file via the shell.
>
> Maybe for map.dat you need to escape such characters somehow, so that
> they don't appear as literal newlines/carriage returns.
>

I am confused.
currently pg_dumpall plain format will abort when encountering dbname
containing newline.
the left dumped plain file does not contain all the cluster databases data.


if pg_dumpall non-text format aborts earlier,
it's aligned with pg_dumpall plain format?
it's also an improvement since aborts earlier, nothing will be dumped?


am i missing something?