MIME-Version: 1.0
References: <202510210803.3b3vfvygxtjl@alvherre.pgsql>
 <87530674-E6B6-4C97-A704-78C7E07CF01F@gmail.com>
 <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
In-Reply-To: <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
From: jian he <jian.universality@gmail.com>
Date: Fri, 28 Nov 2025 18:29:17 +0800
Message-ID: 
 <CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
To: "David E. Wheeler" <david@justatheory.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Florents Tselai <florents.tselai@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter@eisentraut.org>, Robert Haas <robertmhaas@gmail.com>,
	Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	Andrew Dunstan <andrew@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA%40mail.gmail.com>
Precedence: bulk

On Wed, Oct 29, 2025 at 3:39=E2=80=AFAM David E. Wheeler <david@justatheory=
.com> wrote:
>

> Updated patches attached.
>
> Best,
>
> David
>
hi.

/*
 * All node's type of jsonpath expression
 *
 * These become part of the on-disk representation of the jsonpath type.
 * Therefore, to preserve pg_upgradability, the order must not be changed, =
and
 * new values must be added at the end.
 *
 * It is recommended that switch cases etc. in other parts of the code also
 * use this order, to maintain some consistency.
 */
typedef enum JsonPathItemType

some "switch" in the attached patch does not preserve the JsonPathItemType =
order
consistency, like executeItemOptUnwrapTarget.


--
jian
https://www.enterprisedb.com/