MIME-Version: 1.0
References: <CACJufxHTBkymh06D4mGKNe1YfRNFN+gFBybmygWk=PtMqu00LQ@mail.gmail.com>
 <CAKFQuwYD477A9Oy2PxRr_KY8t=k=jbOUK83ie0dS7fcpBsXS3Q@mail.gmail.com>
 <CACJufxE9kt7fAz_g_6PO0PmxK=duWDx+dNUyEWHkGxmRw0EqOg@mail.gmail.com>
 <CAKFQuwZ=ZEkQaFZBRpukNn-qvk4U52ZAsrLLRPAC4hgcZsJmkQ@mail.gmail.com>
 <CACJufxFpzqdfYvsj2iWhtemRyPSB5O7_gb9vRd7cE1ZcVvmZnw@mail.gmail.com>
 <CAKFQuwa-j+oA23EVA7qk+AUdpi24d1LC_O9MH5oSnzOv2McEhg@mail.gmail.com>
 <CACJufxH0jqshH6SC97eQ7T=QcSYpbtKMR2=wmds=K2UT9t0tFw@mail.gmail.com> <CAKFQuwbPdo1MORJqnQj=eA6bGrvGu_U+8J+oTWw7QDvuX2oAQw@mail.gmail.com>
In-Reply-To: <CAKFQuwbPdo1MORJqnQj=eA6bGrvGu_U+8J+oTWw7QDvuX2oAQw@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Tue, 1 Apr 2025 12:11:34 +0800
Message-ID: <CACJufxGF6vU7KUMqHL0RehdvwVBENz2Q++ZyGJaCzk2_VVPqWQ@mail.gmail.com>
Subject: Re: add function argument name to substring and substr
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CACJufxGF6vU7KUMqHL0RehdvwVBENz2Q%2B%2BZyGJaCzk2_VVPqWQ%40mail.gmail.com>
Precedence: bulk

On Tue, Apr 1, 2025 at 6:22=E2=80=AFAM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 9:04=E2=80=AFPM jian he <jian.universality@gmail.=
com> wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression e=
scape replaceable "escape" everywhere.
>
> Instead of fully documenting the obsolete syntax I added a note explainin=
g the keyword choice difference.  Removed mention of it completely from the=
 Pattern Matching portion of the documentation - that section has enough go=
ing on.
>
> I also add "Same as" references for the two pairs of entries.  Not marrie=
d to them but they do seem warranted; having Pattern Matching be required r=
eading to make that connection seems undesirable.
>

your v4-0001-v3-0001-substring.patch is not the same as my
v3-0001-add-argument-name-to-function-substring-and-subst.patch

for example:

-       <para role=3D"func_signature">
+       <para role=3D"func_signature"><s>
         <function>substring</function> (
<parameter>string</parameter> <type>text</type>
<literal>FROM</literal> <parameter>pattern</parameter>
<type>text</type> <literal>FOR</literal> <parameter>escape</parameter>
<type>text</type> )
-        <returnvalue>text</returnvalue>
+        <returnvalue>text</returnvalue></s>

can you make sure v4-0001-v3-0001-substring.patch the same as
v3-0001-add-argument-name-to-function-substring-and-subst.patch.

because I tried
git am


On Tue, Apr 1, 2025 at 6:22=E2=80=AFAM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 9:04=E2=80=AFPM jian he <jian.universality@gmail.=
com> wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression e=
scape replaceable "escape" everywhere.
>
> Instead of fully documenting the obsolete syntax I added a note explainin=
g the keyword choice difference.  Removed mention of it completely from the=
 Pattern Matching portion of the documentation - that section has enough go=
ing on.
>
> I also add "Same as" references for the two pairs of entries.  Not marrie=
d to them but they do seem warranted; having Pattern Matching be required r=
eading to make that connection seems undesirable.
>

your v4-0001-v3-0001-substring.patch is not the same as my
v3-0001-add-argument-name-to-function-substring-and-subst.patch

for example:

-       <para role=3D"func_signature">
+       <para role=3D"func_signature"><s>
         <function>substring</function> (
<parameter>string</parameter> <type>text</type>
<literal>FROM</literal> <parameter>pattern</parameter>
<type>text</type> <literal>FOR</literal> <parameter>escape</parameter>
<type>text</type> )
-        <returnvalue>text</returnvalue>
+        <returnvalue>text</returnvalue></s>

can you make sure v4-0001-v3-0001-substring.patch the same as
v3-0001-add-argument-name-to-function-substring-and-subst.patch.

because I tried git am


On Tue, Apr 1, 2025 at 6:22=E2=80=AFAM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Tue, Mar 18, 2025 at 9:04=E2=80=AFPM jian he <jian.universality@gmail.=
com> wrote:
>>
>>
>> new patch attached.
>>
>
> I've done v4 with a delta patch.
>
> Decided to standardize on calling the SQL Similar To regular expression e=
scape replaceable "escape" everywhere.
>
> Instead of fully documenting the obsolete syntax I added a note explainin=
g the keyword choice difference.  Removed mention of it completely from the=
 Pattern Matching portion of the documentation - that section has enough go=
ing on.
>
> I also add "Same as" references for the two pairs of entries.  Not marrie=
d to them but they do seem warranted; having Pattern Matching be required r=
eading to make that connection seems undesirable.
>

can not build docs based on your v4-0001.

your v4-0001-v3-0001-substring.patch is not the same as my
v3-0001-add-argument-name-to-function-substring-and-subst.patch

for example:
-       <para role=3D"func_signature">
+       <para role=3D"func_signature"><s>
         <function>substring</function> (
<parameter>string</parameter> <type>text</type>
<literal>FROM</literal> <parameter>pattern</parameter>
<type>text</type> <literal>FOR</literal> <parameter>escape</parameter>
<type>text</type> )
-        <returnvalue>text</returnvalue>
+        <returnvalue>text</returnvalue></s>

because I tried
git am v3-0001-add-argument-name-to-function-substring-and-subst.patch.
patch -p1 < v4-0002-v3-0002-delta.patch
Then there are several places that differ, it doesn't seem easy to
resolve the difference.


Can you make sure v4-0001-v3-0001-substring.patch the same as
v3-0001-add-argument-name-to-function-substring-and-subst.patch,
then I can review your delta patch.