Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzWhz-004eJh-2H for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Apr 2024 07:06:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rzWhw-00COPB-0N for pgsql-hackers@arkaria.postgresql.org; Wed, 24 Apr 2024 07:06:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rzWhv-00COP2-Ml for pgsql-hackers@lists.postgresql.org; Wed, 24 Apr 2024 07:06:19 +0000 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rzWht-004NBL-Cf for pgsql-hackers@postgresql.org; Wed, 24 Apr 2024 07:06:18 +0000 Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-7ed6cf3e7f8so1035247241.2 for ; Wed, 24 Apr 2024 00:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713942376; x=1714547176; darn=postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=cbFo2I4K3zYQJr3Ubkf/tp0MaZYhaJX2ywjwiC36OBk=; b=eaO66CaLnyKP/Zx9opkPK/EY+svUrqmylEuY9zCgvtKLAebj0sXNFWMzX3D8TSwGE5 lZ7aMl6fl8dxyBv206Pth/kwhEx5ilw65gjEwGaj1zSM/Go/IPSwDBUZkePgcooyYiAz WY/iI5hCLank8uFsF3iGaH9sVahg+NC0EpeHWHkhx2EDhbM1Cvle5wQwAxfYWWyLfCQX K97DPiMN/yKR7Q0eFGXQZMQEFsWGhxvGaqnVR1itDcbUn+gWgXvTwCKa3/zJojRAW3n0 GDBex4FNkm7oOZictDe0AYMHuek0kb02x4gU5l/CRM0wTcA2xQeI7BIBZmTVLNOYvmS3 ziVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713942376; x=1714547176; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cbFo2I4K3zYQJr3Ubkf/tp0MaZYhaJX2ywjwiC36OBk=; b=JlpplWU/Lqs/7ZMesnqpqc/Kog2HM8aVzQByzv/PUrFHuBk9F49kPhp4YqmBrapRG7 WLE+6amJ8f0yAvr4Fe1DzEw3/t6WCxZ6Wo0NBUGAIe3OlcS/e55Yib9m8l78QEwQumrx erEb6kEoTzlFpcbAKwcVOyIv4JQCQtEgS43tHM7UaX+0VckDaodiYoHDTcVswC0llJmN iY/Iur3cLSMeF+x3AA/C2gP86TRakVBsaDMZsvQPKhY15UlXvDdDi0qhzuXlKZmVPka3 MAoXIxj5iwjULPnX2VOUg0rZso+R/07ZaxO/QmS7HhcUoKcslwr4aWfWcWdNHQMUw5Ak SUKw== X-Gm-Message-State: AOJu0YwN14xkoMwD/Hc1IjxrzpRb0+dULxuvG8LKNc+T5jaOnwvls2wK yhS9ePzXvEUSr3+3vgWomTAkzjy6dZLSIeVIePfqi+JH5oxMX/gx31j3rOmodv2idfj+SShKkVF Unov132HTippQn97oj9Sd3BvSZuzngdcZcRs= X-Google-Smtp-Source: AGHT+IG7A96fU8X6jD5yRpq5Xp1dRbwnxVHdlZDbgzyoWW18a00QMI3vOy3nZ8mjtUc7yxZVV7Md8Uk8hm8t1ivvWBg= X-Received: by 2002:a67:e94f:0:b0:47b:d2e2:9336 with SMTP id p15-20020a67e94f000000b0047bd2e29336mr1734280vso.19.1713942375988; Wed, 24 Apr 2024 00:06:15 -0700 (PDT) MIME-Version: 1.0 From: jian he Date: Wed, 24 Apr 2024 15:05:00 +0800 Message-ID: Subject: minor error message inconsistency in make_pathkey_from_sortinfo To: PostgreSQL-development Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk hi. in make_pathkey_from_sortinfo equality_op = get_opfamily_member(opfamily, opcintype, opcintype, BTEqualStrategyNumber); if (!OidIsValid(equality_op)) /* shouldn't happen */ elog(ERROR, "missing operator %d(%u,%u) in opfamily %u", BTEqualStrategyNumber, opcintype, opcintype, opfamily); the error message seems not right? maybe if (!OidIsValid(equality_op)) /* shouldn't happen */ elog(ERROR, "missing operator =(%u,%u) in opfamily %u",opcintype, opcintype, opfamily); or if (!OidIsValid(equality_op)) /* shouldn't happen */ elog(ERROR, "missing equality operator for type %u in opfamily %u",opcintype, opcintype, opfamily);