MIME-Version: 1.0
References: 
 <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
 <CACJufxFkscyhak2cSr8t+EPfwv11yccfEZBBnPbX4tRc_mWkXQ@mail.gmail.com>
 <884bcf9e-d6e3-4b0c-8dcb-7f2110070ac9@postgrespro.ru>
 <CACJufxHRX6xQtzn+KenK3SDR2+4kUpVnO+0axforV_pohwMnFw@mail.gmail.com>
 <1e74c9fd-830e-4544-b0de-e49ea4b04029@postgrespro.ru>
 <CACJufxHNvb6PpeGDEkzZMnKHjZrQGBHRUENKb2AwZ4N3Q8G3fg@mail.gmail.com>
 <9c1b75f1-5c40-4a86-9a61-a4b3f1d7ec60@postgrespro.ru>
 <CACJufxE6mU7Za2X5Z4Cs9jEmgfjTYPy_ChiVXND5ZEZ3xM665g@mail.gmail.com>
 <7e1c67b8-ceba-4a04-964a-853eedeb02cc@postgrespro.ru>
 <CACJufxHakPGgUHfe4uThY2u_Hzq3YOP9m4B3gjZUTUm2mbVryA@mail.gmail.com>
 <CACJufxHo0u=PzgCn88VZEW0mtB=JopchqBTESudUMH+HCyiTpg@mail.gmail.com>
 <0b3907b4-83b9-4873-9feb-2b60b29cda33@postgrespro.ru>
 <CACJufxFTiAiN_27FzAE60Hm5yQ124EJ+b1dpNDstcSdCApFzLw@mail.gmail.com>
 <4f19550b-eb41-4649-8bf5-566dc020a720@postgrespro.ru>
 <CACJufxHjpdeDtOsmz9TyGX7jFU73LBEjX=JQpRQdAvDadT0coA@mail.gmail.com>
 <df72c242-a099-4d11-b02e-8ee8474c0455@postgrespro.ru>
In-Reply-To: <df72c242-a099-4d11-b02e-8ee8474c0455@postgrespro.ru>
From: jian he <jian.universality@gmail.com>
Date: Tue, 24 Jun 2025 16:06:56 +0800
Message-ID: 
 <CACJufxGSwvUwu2gyZfTzv=3TJ8Zu4=Kq-GB_pg3x5_5dpwYQkA@mail.gmail.com>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
To: Dmitry Koval <d.koval@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxGSwvUwu2gyZfTzv%3D3TJ8Zu4%3DKq-GB_pg3x5_5dpwYQkA%40mail.gmail.com>
Precedence: bulk

hi.

+ /* Sort array of lower bounds. */
+ qsort_arg(lower_bounds, nparts, sizeof(PartitionRangeBound *),
+  qsort_partition_rbound_cmp, (void *) key);
here, we don't need ``(void *)``


+ALTER TABLE [ IF EXISTS ] <replaceable class="parameter">name</replaceable>
+    MERGE PARTITIONS (<replaceable
class="parameter">partition_name1</replaceable>, <replaceable
class="parameter">partition_name2</replaceable> [, ...])
+        INTO <replaceable class="parameter">partition_name</replaceable>
In the synopsis section, we can combine the last two lines into one
for better formatting.

after
<varlistentry id="sql-altertable-parms-partition-name">
we can add the following to briefly explain parameters: partition_name1,
partition_name2


     <varlistentry id="sql-altertable-parms-partition-name1">
      <term><replaceable class="parameter">partition_name1</replaceable></term>
      <term><replaceable class="parameter">partition_name2</replaceable></term>
      <listitem>
       <para>
        The names of the tables being merged into the new partition.
       </para>
      </listitem>
     </varlistentry>

What do you think about alternative syntax:
ALTER TABLE tab1 MERGE PARTITION part1 WITH (part2, part3) mentioned in [1].
I think we need to settle this issue before moving forward.
If the current MERGE PARTITION design is finalized, then v48-0001 looks solid.

[1] https://postgr.es/m/CA+TgmoY0=bT_xBP8csR=MFE=FxGE2n2-me2-31jBOgEcLvW7ug@mail.gmail.com