MIME-Version: 1.0
References: <cb103623-8ee6-4ba5-a2c9-f32e3a4933fa@dunslane.net>
 <ZmcKMF61K4Ck51dK@nathan> <CABUevExoQ26jo+aQ9QZq+UMA1aD6gfpm9xBnh_t5e0DhaCeRYA@mail.gmail.com>
 <ZmcVqPOGjoccIh-i@nathan> <CABUevEyMEaaY37_eMW76F97TX2voxdtPNkm3FGqN9c3ZHy3GMg@mail.gmail.com>
 <740696.1718036463@sss.pgh.pa.us> <CABUevEwv4kQ5of9e+3mZ=Q9ZfkNtDbidPCLuDU_sm00d2Yf-rQ@mail.gmail.com>
 <CAKYtNAryL7Y-JEasiDCts+iiMRufNi74HpPvf=T4b9a1NSa_PQ@mail.gmail.com>
 <CAKYtNArH1=1gf=1t-OErx5G0y2P1nog1atQ4HMyxY2S5ocdnSA@mail.gmail.com>
 <Z3wUepoqtow7EeeR@nathan> <CAKYtNArQDOnTLCo6u8dU+32v-P5qe_naG+-hGrL=S2ZgMyS-_Q@mail.gmail.com>
 <CAKYtNAokugMDYMvqZLuhS7ghD55J9yeYoQzrSNRY9=bPz3Lbtw@mail.gmail.com>
 <CAKYtNAr+xdxtTdTTnjA8B+qkZMrjw6m9geMHcFFQH1itederoQ@mail.gmail.com>
 <CAECtzeXHvNNmVPwysJsCFoqfej4fx-bbzf+myjsM5Umj7kG_Pg@mail.gmail.com>
 <CAKYtNArMEsup-8QF9cBREwXjAOaqptGWF1eX1H=dRuTx3BWtwg@mail.gmail.com> <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
In-Reply-To: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Sat, 11 Jan 2025 13:48:27 +0800
Message-ID: <CACJufxGUucc2wscPFoZHHA9Ea4--wz-Lm86zm14s5TfTPZSqbw@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Guillaume Lelarge <guillaume@lelarge.info>, Nathan Bossart <nathandbossart@gmail.com>, 
	Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>, 
	Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, 
	Dilip Kumar <dilipbalaut@gmail.com>
Content-Type: multipart/mixed; boundary="000000000000de0efb062b67c423"
Archived-At: <https://www.postgresql.org/message-id/CACJufxGUucc2wscPFoZHHA9Ea4--wz-Lm86zm14s5TfTPZSqbw%40mail.gmail.com>
Precedence: bulk

--000000000000de0efb062b67c423
Content-Type: text/plain; charset="UTF-8"

in src/bin/pg_dump/pg_dumpall.c main
i think you need do

    archDumpFormat = parseDumpFormat(formatName);
    /*
     * Open the output file if required, otherwise use stdout.  If required,
     * then create new files with global.dat and map.dat names.
     */
    if (archDumpFormat != archNull)
    {
        char    toc_path[MAXPGPATH];
        /*
         * If directory/tar/custom format is specified then we must provide the
         * file name to create one main directory.
         */
        if (!filename || strcmp(filename, "") == 0)
            pg_fatal("no output directory specified");
        /* TODO: accept the empty existing directory. */
        if (mkdir(filename, 0700) < 0)
            pg_fatal("could not create directory \"%s\": %m",
                     filename);
        snprintf(toc_path, MAXPGPATH, "%s/global.dat", filename);
        OPF = fopen(toc_path, "w");
        if (!OPF)
            pg_fatal("could not open global.dat file: %s", strerror(errno));
    }
    else if (filename)
    {
        OPF = fopen(filename, PG_BINARY_W);
        if (!OPF)
            pg_fatal("could not open output file \"%s\": %m",
                     filename);
    }
    else
        OPF = stdout;

before connectDatabase call.

otherwise if the cluster is not setting up.
``pg_dumpall --format=d``
error would be about connection error, not
"pg_dumpall: error: no output directory specified"

we want ``pg_dumpall --format`` invalid options
to error out even if the cluster is not setting up.

attached are two invalid option test cases.

you also need change
     <varlistentry>
      <term><option>-f <replaceable
class="parameter">filename</replaceable></option></term>
      <term><option>--file=<replaceable
class="parameter">filename</replaceable></option></term>
      <listitem>
       <para>
        Send output to the specified file.  If this is omitted, the
        standard output is used.
       </para>
      </listitem>
     </varlistentry>
?

since if --format=d,
<option>--file=<replaceable class="parameter">filename</replaceable></option>
can not be omitted.

--000000000000de0efb062b67c423
Content-Type: application/octet-stream; 
	name="v7-0001-misc-tests-for-pg_dumpall.no-cfbot"
Content-Disposition: attachment; 
	filename="v7-0001-misc-tests-for-pg_dumpall.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_m5rrhwf00>
X-Attachment-Id: f_m5rrhwf00

RnJvbSAzMzllODEzYTEzN2U1YzIxNTA3M2I0MGQ1MDhiMjRiYTIzMTJkMWNhIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFNhdCwgMTEgSmFuIDIwMjUgMTM6NDM6MzQgKzA4MDAKU3ViamVjdDogW1BBVENIIHY3
IDEvMV0gbWlzYyB0ZXN0cyBmb3IgcGdfZHVtcGFsbAoKLS0tCiBzcmMvYmluL3BnX2R1bXAvdC8w
MDFfYmFzaWMucGwgICAgICAgICAgICAgIHwgNCArKysrCiBzcmMvYmluL3BnX2R1bXAvdC8wMDVf
cGdfZHVtcF9maWx0ZXJmaWxlLnBsIHwgOCArKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxMiBp
bnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2Jpbi9wZ19kdW1wL3QvMDAxX2Jhc2ljLnBs
IGIvc3JjL2Jpbi9wZ19kdW1wL3QvMDAxX2Jhc2ljLnBsCmluZGV4IDIxNDI0MGYxYWUuLjJkMjQ2
ZTBhNTAgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC90LzAwMV9iYXNpYy5wbAorKysgYi9z
cmMvYmluL3BnX2R1bXAvdC8wMDFfYmFzaWMucGwKQEAgLTIyNiw0ICsyMjYsOCBAQCBjb21tYW5k
X2ZhaWxzX2xpa2UoCiAJJ3BnX2R1bXBhbGw6IG9wdGlvbiAtLWV4Y2x1ZGUtZGF0YWJhc2UgY2Fu
bm90IGJlIHVzZWQgdG9nZXRoZXIgd2l0aCAtZy8tLWdsb2JhbHMtb25seScKICk7CiAKK2NvbW1h
bmRfZmFpbHNfbGlrZSgKKwlbICdwZ19kdW1wYWxsJywgJy0tZm9ybWF0JywgJ3gnIF0sCisJcXIv
XFFwZ19kdW1wYWxsOiBlcnJvcjogaW52YWxpZCBkdW1wIGZvcm1hdCAieCIgc3BlY2lmaWVkXEUv
LAorCSdwZ19kdW1wYWxsOiBpbnZhbGlkIGR1bXAgZm9ybWF0Jyk7CiBkb25lX3Rlc3RpbmcoKTsK
ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC90LzAwNV9wZ19kdW1wX2ZpbHRlcmZpbGUucGwg
Yi9zcmMvYmluL3BnX2R1bXAvdC8wMDVfcGdfZHVtcF9maWx0ZXJmaWxlLnBsCmluZGV4IDM1Njhh
MjQ2YjIuLmZlY2QzNDc4ZGQgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC90LzAwNV9wZ19k
dW1wX2ZpbHRlcmZpbGUucGwKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3QvMDA1X3BnX2R1bXBfZmls
dGVyZmlsZS5wbApAQCAtNTI5LDYgKzUyOSwxNCBAQCBjb21tYW5kX2ZhaWxzX2xpa2UoCiAKICMj
IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAjIHBnX3Jlc3RvcmUgdGVz
dHMKK2NvbW1hbmRfZmFpbHNfbGlrZSgKKwlbCisJCSdwZ19yZXN0b3JlJywgJy1wJywgJHBvcnQs
ICctZicsICRwbGFpbmZpbGUsCisJCSItLWV4Y2x1ZGUtZGF0YWJhc2U9Z3JhYmFkZ2UiLAorCQkn
LS1nbG9iYWxzLW9ubHknCisJXSwKKwlxci9cUWdfcmVzdG9yZTogZXJyb3I6IG9wdGlvbiAtLWV4
Y2x1ZGUtZGF0YWJhc2UgY2Fubm90IGJlIHVzZWQgdG9nZXRoZXIgd2l0aCAtZ1wvLS1nbG9iYWxz
LW9ubHlcRS8sCisJJ3BnX3Jlc3RvcmU6IG9wdGlvbiAtLWV4Y2x1ZGUtZGF0YWJhc2UgY2Fubm90
IGJlIHVzZWQgdG9nZXRoZXIgd2l0aCAtZy8tLWdsb2JhbHMtb25seScpOwogCiBjb21tYW5kX29r
KAogCVsKLS0gCjIuMzQuMQoK
--000000000000de0efb062b67c423--