MIME-Version: 1.0
References: <CACJufxEN_mmgTtp-raJ9-VJHgyAGmb0SrO+01kn5by4mJ_XOfw@mail.gmail.com>
In-Reply-To: <CACJufxEN_mmgTtp-raJ9-VJHgyAGmb0SrO+01kn5by4mJ_XOfw@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Sat, 21 Feb 2026 23:07:52 +0800
Message-ID: <CACJufxGcUztOYcCj85o15YT68qPY3qpwUtdndqDgOs_Sps6Cow@mail.gmail.com>
Subject: Re: refactor ExecInitPartitionInfo
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000fbf890064b56e8b4"
Archived-At: <https://www.postgresql.org/message-id/CACJufxGcUztOYcCj85o15YT68qPY3qpwUtdndqDgOs_Sps6Cow%40mail.gmail.com>
Precedence: bulk

--000000000000fbf890064b56e8b4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 28, 2025 at 7:00=E2=80=AFPM jian he <jian.universality@gmail.co=
m> wrote:
>
> hi.
>
> I noticed the following code pattern repeated several times in
> ExecInitPartitionInfo.
> ```
> if (part_attmap =3D=3D NULL)
>             build_attrmap_by_name(RelationGetDescr(partrel),
>                                   RelationGetDescr(firstResultRel),
>                                   false);
> ```
>
> we can consolidated into one, like:
>
> +    if (node !=3D NULL &&
> +        (list_length(node->withCheckOptionLists) > 0 ||
> +         list_length(node->returningLists) > 0 ||
> +         node->onConflictAction !=3D ONCONFLICT_NONE ||
> +         node->operation =3D=3D CMD_MERGE))
> +    {
> +        part_attmap =3D
> +            build_attrmap_by_name(RelationGetDescr(partrel),
> +                                  RelationGetDescr(firstResultRel),
> +                                  false);
> +    }
> +
>


> +    if (node !=3D NULL &&
> +        (list_length(node->withCheckOptionLists) > 0 ||
> +         list_length(node->returningLists) > 0 ||
> +         node->onConflictAction !=3D ONCONFLICT_NONE ||
> +         node->operation =3D=3D CMD_MERGE))
V1 is way too complicated.
IMHO, we can just do

    if (node !=3D NULL)
        part_attmap =3D build_attrmap_by_name(RelationGetDescr(partrel),
                                            RelationGetDescr(firstResultRel=
),
                                            false);

We have now consolidated five uses of build_attrmap_by_name into one.


--
jian
https://www.enterprisedb.com/

--000000000000fbf890064b56e8b4
Content-Type: text/x-patch; charset="US-ASCII"; 
	name="v2-0001-refactor-ExecInitPartitionInfo.patch"
Content-Disposition: attachment; 
	filename="v2-0001-refactor-ExecInitPartitionInfo.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mlwg09k90>
X-Attachment-Id: f_mlwg09k90

RnJvbSAzYjdlYjI4NDI0MTY3NWExMDI2ZWVlYmM5YTZmNjgyYTg4Zjk1NDMwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFNhdCwgMjEgRmViIDIwMjYgMjI6NTA6NTUgKzA4MDAKU3ViamVjdDogW1BBVENIIHYy
IDEvMV0gcmVmYWN0b3IgRXhlY0luaXRQYXJ0aXRpb25JbmZvCgpEaXNjdXNzaW9uOiBodHRwczov
L3Bvc3Rnci5lcy9tL0NBQ0p1ZnhFTl9tbWdUdHAtcmFKOS1WSkhneUFHbWIwU3JPKzAxa241Ynk0
bUpfWE9md0BtYWlsLmdtYWlsLmNvbQpjb21taXRmZXN0OiBodHRwczovL2NvbW1pdGZlc3QucG9z
dGdyZXNxbC5vcmcvcGF0Y2gvNjI4MAotLS0KIHNyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNQYXJ0
aXRpb24uYyB8IDM1ICsrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk
LCA2IGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNr
ZW5kL2V4ZWN1dG9yL2V4ZWNQYXJ0aXRpb24uYyBiL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNQ
YXJ0aXRpb24uYwppbmRleCBiYWIyOTRmNWU5MS4uZDYyZDZhNzFmMDMgMTAwNjQ0Ci0tLSBhL3Ny
Yy9iYWNrZW5kL2V4ZWN1dG9yL2V4ZWNQYXJ0aXRpb24uYworKysgYi9zcmMvYmFja2VuZC9leGVj
dXRvci9leGVjUGFydGl0aW9uLmMKQEAgLTYwNyw2ICs2MDcsMTEgQEAgRXhlY0luaXRQYXJ0aXRp
b25JbmZvKE1vZGlmeVRhYmxlU3RhdGUgKm10c3RhdGUsIEVTdGF0ZSAqZXN0YXRlLAogCQkJCQkJ
KG5vZGUgIT0gTlVMTCAmJgogCQkJCQkJIG5vZGUtPm9uQ29uZmxpY3RBY3Rpb24gIT0gT05DT05G
TElDVF9OT05FKSk7CiAKKwlpZiAobm9kZSAhPSBOVUxMKQorCQlwYXJ0X2F0dG1hcCA9IGJ1aWxk
X2F0dHJtYXBfYnlfbmFtZShSZWxhdGlvbkdldERlc2NyKHBhcnRyZWwpLAorCQkJCQkJCQkJCQlS
ZWxhdGlvbkdldERlc2NyKGZpcnN0UmVzdWx0UmVsKSwKKwkJCQkJCQkJCQkJZmFsc2UpOworCiAJ
LyoKIAkgKiBCdWlsZCBXSVRIIENIRUNLIE9QVElPTiBjb25zdHJhaW50cyBmb3IgdGhlIHBhcnRp
dGlvbi4gIE5vdGUgdGhhdCB3ZQogCSAqIGRpZG4ndCBidWlsZCB0aGUgd2l0aENoZWNrT3B0aW9u
TGlzdCBmb3IgcGFydGl0aW9ucyB3aXRoaW4gdGhlIHBsYW5uZXIsCkBAIC02NDksMTAgKzY1NCw2
IEBAIEV4ZWNJbml0UGFydGl0aW9uSW5mbyhNb2RpZnlUYWJsZVN0YXRlICptdHN0YXRlLCBFU3Rh
dGUgKmVzdGF0ZSwKIAkJLyoKIAkJICogQ29udmVydCBWYXJzIGluIGl0IHRvIGNvbnRhaW4gdGhp
cyBwYXJ0aXRpb24ncyBhdHRyaWJ1dGUgbnVtYmVycy4KIAkJICovCi0JCXBhcnRfYXR0bWFwID0K
LQkJCWJ1aWxkX2F0dHJtYXBfYnlfbmFtZShSZWxhdGlvbkdldERlc2NyKHBhcnRyZWwpLAotCQkJ
CQkJCQkgIFJlbGF0aW9uR2V0RGVzY3IoZmlyc3RSZXN1bHRSZWwpLAotCQkJCQkJCQkgIGZhbHNl
KTsKIAkJd2NvTGlzdCA9IChMaXN0ICopCiAJCQltYXBfdmFyaWFibGVfYXR0bm9zKChOb2RlICop
IHdjb0xpc3QsCiAJCQkJCQkJCWZpcnN0VmFybm8sIDAsCkBAIC03MDYsMTQgKzcwNyw2IEBAIEV4
ZWNJbml0UGFydGl0aW9uSW5mbyhNb2RpZnlUYWJsZVN0YXRlICptdHN0YXRlLCBFU3RhdGUgKmVz
dGF0ZSwKIAkJICovCiAJCXJldHVybmluZ0xpc3QgPSBsaW5pdGlhbChub2RlLT5yZXR1cm5pbmdM
aXN0cyk7CiAKLQkJLyoKLQkJICogQ29udmVydCBWYXJzIGluIGl0IHRvIGNvbnRhaW4gdGhpcyBw
YXJ0aXRpb24ncyBhdHRyaWJ1dGUgbnVtYmVycy4KLQkJICovCi0JCWlmIChwYXJ0X2F0dG1hcCA9
PSBOVUxMKQotCQkJcGFydF9hdHRtYXAgPQotCQkJCWJ1aWxkX2F0dHJtYXBfYnlfbmFtZShSZWxh
dGlvbkdldERlc2NyKHBhcnRyZWwpLAotCQkJCQkJCQkJICBSZWxhdGlvbkdldERlc2NyKGZpcnN0
UmVzdWx0UmVsKSwKLQkJCQkJCQkJCSAgZmFsc2UpOwogCQlyZXR1cm5pbmdMaXN0ID0gKExpc3Qg
KikKIAkJCW1hcF92YXJpYWJsZV9hdHRub3MoKE5vZGUgKikgcmV0dXJuaW5nTGlzdCwKIAkJCQkJ
CQkJZmlyc3RWYXJubywgMCwKQEAgLTk1MSwxMSArOTQ0LDcgQEAgRXhlY0luaXRQYXJ0aXRpb25J
bmZvKE1vZGlmeVRhYmxlU3RhdGUgKm10c3RhdGUsIEVTdGF0ZSAqZXN0YXRlLAogCQkJCQlMaXN0
CSAgICpvbmNvbmZsY29sczsKIAogCQkJCQlvbmNvbmZsc2V0ID0gY29weU9iamVjdChub2RlLT5v
bkNvbmZsaWN0U2V0KTsKLQkJCQkJaWYgKHBhcnRfYXR0bWFwID09IE5VTEwpCi0JCQkJCQlwYXJ0
X2F0dG1hcCA9Ci0JCQkJCQkJYnVpbGRfYXR0cm1hcF9ieV9uYW1lKFJlbGF0aW9uR2V0RGVzY3Io
cGFydHJlbCksCi0JCQkJCQkJCQkJCQkgIFJlbGF0aW9uR2V0RGVzY3IoZmlyc3RSZXN1bHRSZWwp
LAotCQkJCQkJCQkJCQkJICBmYWxzZSk7CisKIAkJCQkJb25jb25mbHNldCA9IChMaXN0ICopCiAJ
CQkJCQltYXBfdmFyaWFibGVfYXR0bm9zKChOb2RlICopIG9uY29uZmxzZXQsCiAJCQkJCQkJCQkJ
CUlOTkVSX1ZBUiwgMCwKQEAgLTEwMDcsMTIgKzk5Niw2IEBAIEV4ZWNJbml0UGFydGl0aW9uSW5m
byhNb2RpZnlUYWJsZVN0YXRlICptdHN0YXRlLCBFU3RhdGUgKmVzdGF0ZSwKIAkJCQl7CiAJCQkJ
CUxpc3QJICAgKmNsYXVzZTsKIAotCQkJCQlpZiAocGFydF9hdHRtYXAgPT0gTlVMTCkKLQkJCQkJ
CXBhcnRfYXR0bWFwID0KLQkJCQkJCQlidWlsZF9hdHRybWFwX2J5X25hbWUoUmVsYXRpb25HZXRE
ZXNjcihwYXJ0cmVsKSwKLQkJCQkJCQkJCQkJCSAgUmVsYXRpb25HZXREZXNjcihmaXJzdFJlc3Vs
dFJlbCksCi0JCQkJCQkJCQkJCQkgIGZhbHNlKTsKLQogCQkJCQljbGF1c2UgPSBjb3B5T2JqZWN0
KChMaXN0ICopIG5vZGUtPm9uQ29uZmxpY3RXaGVyZSk7CiAJCQkJCWNsYXVzZSA9IChMaXN0ICop
CiAJCQkJCQltYXBfdmFyaWFibGVfYXR0bm9zKChOb2RlICopIGNsYXVzZSwKQEAgLTEwNjQsMTIg
KzEwNDcsNiBAQCBFeGVjSW5pdFBhcnRpdGlvbkluZm8oTW9kaWZ5VGFibGVTdGF0ZSAqbXRzdGF0
ZSwgRVN0YXRlICplc3RhdGUsCiAJCUV4cHJDb250ZXh0ICplY29udGV4dCA9IG10c3RhdGUtPnBz
LnBzX0V4cHJDb250ZXh0OwogCQlOb2RlCSAgICpqb2luQ29uZGl0aW9uOwogCi0JCWlmIChwYXJ0
X2F0dG1hcCA9PSBOVUxMKQotCQkJcGFydF9hdHRtYXAgPQotCQkJCWJ1aWxkX2F0dHJtYXBfYnlf
bmFtZShSZWxhdGlvbkdldERlc2NyKHBhcnRyZWwpLAotCQkJCQkJCQkJICBSZWxhdGlvbkdldERl
c2NyKGZpcnN0UmVzdWx0UmVsKSwKLQkJCQkJCQkJCSAgZmFsc2UpOwotCiAJCWlmICh1bmxpa2Vs
eSghbGVhZl9wYXJ0X3JyaS0+cmlfcHJvamVjdE5ld0luZm9WYWxpZCkpCiAJCQlFeGVjSW5pdE1l
cmdlVHVwbGVTbG90cyhtdHN0YXRlLCBsZWFmX3BhcnRfcnJpKTsKIAotLSAKMi4zNC4xCgo=
--000000000000fbf890064b56e8b4--