MIME-Version: 1.0
References: <202510210803.3b3vfvygxtjl@alvherre.pgsql>
 <87530674-E6B6-4C97-A704-78C7E07CF01F@gmail.com>
 <3DC56A6A-9525-4C05-B45A-9A135A66BC34@justatheory.com>
 <CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
 <A654130B-16AF-4E37-9D73-B3CDC80C751C@justatheory.com>
 <CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
In-Reply-To: 
 <CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Thu, 4 Dec 2025 12:22:19 +0800
Message-ID: 
 <CACJufxGdgxyRLd03wM=GtJzUskXnXxEBGGtwA2vsTvkV827SxA@mail.gmail.com>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
To: "David E. Wheeler" <david@justatheory.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
 =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Florents Tselai <florents.tselai@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter@eisentraut.org>, Robert Haas <robertmhaas@gmail.com>,
	Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	Andrew Dunstan <andrew@dunslane.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxGdgxyRLd03wM%3DGtJzUskXnXxEBGGtwA2vsTvkV827SxA%40mail.gmail.com>
Precedence: bulk

On Thu, Dec 4, 2025 at 11:56=E2=80=AFAM jian he <jian.universality@gmail.co=
m> wrote:
>
> On Mon, Dec 1, 2025 at 5:16=E2=80=AFAM David E. Wheeler <david@justatheor=
y.com> wrote:
> >
> > Well-spotted, thank you! Fixed in v15, attached.
> >
>
> seems no deparse regress tests, like:
> create view vj as select jsonb_path_query('"   hello   "', '$.ltrim(" ")'=
) as a;
> \sv vj
>
> that mean the changes in printJsonPathItem are not tested?
>

hi.
seems no tests for the changes in jspIsMutableWalker too.
we can make some simple dummy tests like:

create table tjs(a jsonb);
create index on tjs(jsonb_path_match(a, '$.ltrim(" ")'));

--
jian
https://www.enterprisedb.com/