MIME-Version: 1.0
References: <ahgAsvfSt3kbw88l@alvherre.pgsql>
 <7B7172F4-DB02-4259-997B-6AEF5ADF7FCE@gmail.com>
 <CACJufxHbVuY683j3DHEU4LSswo8DTzLJbTvhv2Uj6gqN8pJs7Q@mail.gmail.com>
 <14E223D8-8425-446A-A36C-6B62BC334656@gmail.com>
 <9A3D388C-1DF4-4C43-9AB6-83529A8F48C8@gmail.com>
In-Reply-To: <9A3D388C-1DF4-4C43-9AB6-83529A8F48C8@gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 3 Jun 2026 14:58:45 +0800
Message-ID: 
 <CACJufxGgSKFGWja=JPv3-zq3whON5cESLp7Z5=OsYvZOaRGnGw@mail.gmail.com>
Subject: Re: Fix bug of CHECK constraint enforceability recursion
To: Chao Li <li.evan.chao@gmail.com>
Cc: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	"L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Content-Type: multipart/mixed; boundary="000000000000ab701d065353f7bf"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxGgSKFGWja%3DJPv3-zq3whON5cESLp7Z5%3DOsYvZOaRGnGw%40mail.gmail.com>
Precedence: bulk

--000000000000ab701d065353f7bf
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 2, 2026 at 2:40=E2=80=AFPM Chao Li <li.evan.chao@gmail.com> wro=
te:
>
> Oops! I just found that I forgot to commit a tiny comment tuning in 0001.=
 So posting v6.
>
Hi.

One partition cannot have two direct parent tables. see
ATExecAttachPartition comment:
/* A partition can only have one parent */

Also
CREATE TABLE ... PARTITION OF automatically copies the parent
constraint definition, and
ALTER TABLE ... ATTACH PARTITION already rejects cases where the
parent is enforced but the child is not.

Therefore, I think calling ATCheckCheckConstrHasEnforcedParent once is
enough for partition inheritance.

Also please check the attached minor refactoring.


--
jian
https://www.enterprisedb.com/

--000000000000ab701d065353f7bf
Content-Type: application/octet-stream;
	name="checkconstr_inheritance_issue.nocfbot"
Content-Disposition: attachment;
	filename="checkconstr_inheritance_issue.nocfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mpxpsq4g0>
X-Attachment-Id: f_mpxpsq4g0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2JhY2tl
bmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggNjRhMGRhY2NhNGYuLjkxMjY3NGNjMGIzIDEw
MDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYworKysgYi9zcmMvYmFj
a2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYwpAQCAtMTI3NjksNiArMTI3NjksMTMgQEAgQVRFeGVj
QWx0ZXJDaGVja0NvbnN0ckVuZm9yY2VhYmlsaXR5KExpc3QgKip3cXVldWUsIEFUQWx0ZXJDb25z
dHJhaW50ICpjbWRjb24sCiAJCQljaGlsZHJlbiA9IGZpbmRfYWxsX2luaGVyaXRvcnMoUmVsYXRp
b25HZXRSZWxpZChyZWwpLAogCQkJCQkJCQkJCSAgIGxvY2ttb2RlLCBOVUxMKTsKIAorCQkJLyoK
KwkJCSAqIEJ1aWxkIHRoZSBzZXQgb2YgZXF1aXZhbGVudCBDSEVDSyBjb25zdHJhaW50cyB0aGF0
IHRoaXMgY29tbWFuZAorCQkJICogd2lsbCBhdHRlbXB0IHRvIGNoYW5nZSBiZWZvcmUgdmlzaXRp
bmcgZGVzY2VuZGFudHMuIFRoZSByb290CisJCQkgKiBpdHNlbGYgaGFzIGFscmVhZHkgYmVlbiBj
aGVja2VkIGFib3ZlLgorCQkJICovCisJCQljaGFuZ2luZ19jb25pZHMgPSBsaXN0X21ha2UxX29p
ZChjdXJyY29uLT5vaWQpOworCiAJCQlmb3JlYWNoX29pZChjaGlsZG9pZCwgY2hpbGRyZW4pCiAJ
CQl7CiAJCQkJaWYgKGNoaWxkb2lkID09IFJlbGF0aW9uR2V0UmVsaWQocmVsKSkKQEAgLTEyNzg1
LDM1ICsxMjc5MiwyMCBAQCBBVEV4ZWNBbHRlckNoZWNrQ29uc3RyRW5mb3JjZWFiaWxpdHkoTGlz
dCAqKndxdWV1ZSwgQVRBbHRlckNvbnN0cmFpbnQgKmNtZGNvbiwKIAkJCQkJCQllcnJjb2RlKEVS
UkNPREVfSU5WQUxJRF9UQUJMRV9ERUZJTklUSU9OKSwKIAkJCQkJCQllcnJtc2coImNvbnN0cmFp
bnQgbXVzdCBiZSBhbHRlcmVkIG9uIGNoaWxkIHRhYmxlcyB0b28iKSwKIAkJCQkJCQllcnJoaW50
KCJEbyBub3Qgc3BlY2lmeSB0aGUgT05MWSBrZXl3b3JkLiIpKTsKLQkJCX0KIAotCQkJaWYgKCFj
bWRjb24tPmlzX2VuZm9yY2VkKQotCQkJewogCQkJCS8qCi0JCQkJICogQnVpbGQgdGhlIHNldCBv
ZiBlcXVpdmFsZW50IENIRUNLIGNvbnN0cmFpbnRzIHRoYXQgdGhpcwotCQkJCSAqIGNvbW1hbmQg
d2lsbCBhdHRlbXB0IHRvIGNoYW5nZSBiZWZvcmUgdmlzaXRpbmcgZGVzY2VuZGFudHMuCi0JCQkJ
ICogVGhlIHJvb3QgaXRzZWxmIGhhcyBhbHJlYWR5IGJlZW4gY2hlY2tlZCBhYm92ZS4KKwkJCQkg
KiBJdCBpcyBzdWZmaWNpZW50IHRvIGxvb2sgdXAgdGhlIGNvbnN0cmFpbnQgYnkgbmFtZSBoZXJl
LgorCQkJCSAqIFN1cHBvcnRlZCBEREwgZW5zdXJlcyB0aGF0IGluaGVyaXRhYmxlIENIRUNLIGNv
bnN0cmFpbnRzCisJCQkJICogd2l0aCB0aGUgc2FtZSBuYW1lIGhhdmUgZXF1aXZhbGVudCBkZWZp
bml0aW9ucyB3aGVuIHRoZXkKKwkJCQkgKiBhcmUgcHJvcGFnYXRlZCB0byBjaGlsZHJlbiBvciB3
aGVuIGluaGVyaXRhbmNlIGlzCisJCQkJICogZXN0YWJsaXNoZWQuCiAJCQkJICovCi0JCQkJY2hh
bmdpbmdfY29uaWRzID0gbGlzdF9tYWtlMV9vaWQoY3VycmNvbi0+b2lkKTsKLQotCQkJCWZvcmVh
Y2hfb2lkKGNoaWxkb2lkLCBjaGlsZHJlbikKLQkJCQl7Ci0JCQkJCWlmIChjaGlsZG9pZCA9PSBS
ZWxhdGlvbkdldFJlbGlkKHJlbCkpCi0JCQkJCQljb250aW51ZTsKLQotCQkJCQkvKgotCQkJCQkg
KiBJdCBpcyBzdWZmaWNpZW50IHRvIGxvb2sgdXAgdGhlIGNvbnN0cmFpbnQgYnkgbmFtZQotCQkJ
CQkgKiBoZXJlLiAgU3VwcG9ydGVkIERETCBlbnN1cmVzIHRoYXQgaW5oZXJpdGFibGUgQ0hFQ0sK
LQkJCQkJICogY29uc3RyYWludHMgd2l0aCB0aGUgc2FtZSBuYW1lIGhhdmUgZXF1aXZhbGVudAot
CQkJCQkgKiBkZWZpbml0aW9ucyB3aGVuIHRoZXkgYXJlIHByb3BhZ2F0ZWQgdG8gY2hpbGRyZW4g
b3IKLQkJCQkJICogd2hlbiBpbmhlcml0YW5jZSBpcyBlc3RhYmxpc2hlZC4KLQkJCQkJICovCisJ
CQkJaWYgKCFjbWRjb24tPmlzX2VuZm9yY2VkKQogCQkJCQljaGFuZ2luZ19jb25pZHMgPQogCQkJ
CQkJbGlzdF9hcHBlbmRfdW5pcXVlX29pZChjaGFuZ2luZ19jb25pZHMsCiAJCQkJCQkJCQkJCSAg
IGdldF9yZWxhdGlvbl9jb25zdHJhaW50X29pZChjaGlsZG9pZCwKIAkJCQkJCQkJCQkJCQkJCQkJ
CSAgIGNtZGNvbi0+Y29ubmFtZSwKIAkJCQkJCQkJCQkJCQkJCQkJCSAgIGZhbHNlKSk7Ci0JCQkJ
fQogCQkJfQogCQl9CiAK
--000000000000ab701d065353f7bf--