MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql> <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
 <CACJufxGcZ1rK94cgfdc9McCD7W-83PT9_cx5VoFeC-HVc10Wzg@mail.gmail.com>
 <CAKYtNAqd4k+4+XANxjDc35i+WPme476DkP7msjYpX85F+4UsUg@mail.gmail.com>
 <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
 <CACJufxEtDgADBXQhX5cp3mJtNVMy+j+Jdovuk3PWe5qJ0sE3Ag@mail.gmail.com>
 <CAKYtNArwUxqR=LkQY1PT7tw+raMhf53oafo4WmSHGPHiER9d=A@mail.gmail.com>
 <CACJufxHUDGWe=2ZukvMfuwEcSK8CsVYm=9+rtPnrW7CRCfoCsw@mail.gmail.com>
 <CACJufxGOy1kAot+SAD9siKB797rj9K-bqeZOrS4fDYFFLo31bA@mail.gmail.com>
 <CAKYtNApE=x0sZxU3c9KqsYRU3dCztcfhQ+CDWhzgtH83HQUkuA@mail.gmail.com>
 <CACJufxHNNjAhVYJQS8x5U-9Fqsj6+tzG4uCivk2XTAOPTmstTA@mail.gmail.com>
 <CACJufxFJ9yJ=+WAHpXbDxf077Xw3O+ZziTwS55+ZK5APJ+6mUg@mail.gmail.com>
 <CACJufxEA-Q2hatN_BLcNrgfo8-4-m102gDdwVp0NTbuM2zyeDA@mail.gmail.com>
 <CAKYtNAqWjU6-J=VA-9-CVDLh7nX_Y_MgdSgyLFb6yYyZ1NYsyg@mail.gmail.com>
 <CACJufxEFxaiqytZRpL0Xbj8_XEtTm8-A2FE6u_9vigGO3z5oZQ@mail.gmail.com>
 <CAKYtNAr732dgvu43vLRBnDK=dPBVWAFBKaCp0982kwp0Yn8DOA@mail.gmail.com>
 <CACJufxGwXjG80LZ4miX+dXaT+3z5Kf1Mf0P_7FnR+641oqfUyg@mail.gmail.com>
 <CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ@mail.gmail.com>
 <CAKYtNApzcsV3a_jR6oduA12yKrx=aBv+vcA=RseT-2rLrC2o_g@mail.gmail.com>
 <CAFC+b6p84_wtbviPu-mLNxfOPLozN8OOjWcz_tjoDf=SuVDMTQ@mail.gmail.com>
 <CAFC+b6qJ9BAmN-J2ha-Q08MPbZ2FqTUB++B0ouvSk72px3D-NA@mail.gmail.com>
 <CAKYtNAqsOwq-u-h0+WEm2nonwZD4S=9ri4-d0vhAGjNQZ7FjnQ@mail.gmail.com>
 <CAKYtNAr+YSMu1TkyXzsxtvCMRoya05_=1V_LFKDrL=XpYJ9DxQ@mail.gmail.com>
 <CACJufxGp5p7_7EwNwg-GuKZO+XB9uxfWTZ+QWhhNvwgUF0Vb0w@mail.gmail.com>
 <CACJufxGoUgqv+T1MXuh_SH_FTwTMpqfUcntHP1c5Q7KnyPXgKQ@mail.gmail.com>
 <CACJufxFWFLZhtgk92HR78tKiYk0yRX-26v2y1eEN2NtjyXtU4A@mail.gmail.com>
 <CAKYtNApkrfDHyN5z+Spbat1xzVOEL9y5o+ALimYmb3eH3T8Vhw@mail.gmail.com>
 <CACJufxFrzYJ0oZNm=v9hg10UpPQNe+p0+2ydNirHxyhUT_JtXw@mail.gmail.com>
 <CAKYtNAqP=URFvX2dqH5RT+wmd9nrnrfH45rvD2H_w9zNBvJqQA@mail.gmail.com>
 <CACJufxEcGGddRgwDLafyi+GJDOamPR4rrPG_0tZp6Rh81mEPfA@mail.gmail.com>
 <CAKYtNApSjr=etW+uVQ2KW0NcV=aZq-QdOd0jULync=84iDWr-w@mail.gmail.com>
 <CACJufxEAWxWovH_dys5A2z53OGpftX_jJRTd1y8eB3HaojY+1A@mail.gmail.com>
 <CAKYtNAoRswr5B_sH-4o-V=UA74EpUKHbnXosG0Mk1=UJQfRWtA@mail.gmail.com>
 <CACJufxH3T9OFg53HDXydLCKgHFVqAmbOu_huJpitVtggdP31fw@mail.gmail.com>
 <CAKYtNArHMqce98D1sNUOXcDZwWxgJ=dg9sO+tGpfKdX7FoOoAg@mail.gmail.com>
 <CAFC+b6r2HDhms7aggMq8b8fJQL2r-RNTEeNcBnNj_0M41R81Lw@mail.gmail.com> <CAKYtNAqe=tk4ViMduz5g4iG4Hzu-O1d7Y++1Xo=ArbqFBQ=Cow@mail.gmail.com>
In-Reply-To: <CAKYtNAqe=tk4ViMduz5g4iG4Hzu-O1d7Y++1Xo=ArbqFBQ=Cow@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 19 Feb 2025 19:37:54 +0800
Message-ID: <CACJufxGio7+42fJ9GD5JzLjxDBt4vYBUO576p7BfKjyVdr1qNg@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000006237f6062e7d3255"
Archived-At: <https://www.postgresql.org/message-id/CACJufxGio7%2B42fJ9GD5JzLjxDBt4vYBUO576p7BfKjyVdr1qNg%40mail.gmail.com>
Precedence: bulk

--0000000000006237f6062e7d3255
Content-Type: text/plain; charset="UTF-8"

hi.

Currently, pg_retore says
--exit-on-error
Exit if an error is encountered while sending SQL commands to the
database. The default is to continue and to display a count of errors
at the end of the restoration.
Do we need to apply this to restore executing global commands (create
role, create tablespace)?
If not then we need to put some words in pg_restoe --exit-on-error
option saying that while restoring global objects --exit-on-error
option is ignored.


IMHO, in pg_restore.sgml, we need words explicitly saying that
when restoring multiple databases, all the specified options will
apply to each individual database.

I tested the following options for restoring multiple databases. The
results look good to me.
--index=index
--table=table
--schema-only
--transaction-size
--no-comments
some part of (--filter=filename)
--exclude-schema=schema

attach is a minor cosmetic change.

--0000000000006237f6062e7d3255
Content-Type: application/octet-stream; name="v17_pg_dumpall.minorchange"
Content-Disposition: attachment; filename="v17_pg_dumpall.minorchange"
Content-Transfer-Encoding: base64
Content-ID: <f_m7bu9f1o0>
X-Attachment-Id: f_m7bu9f1o0

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMgYi9zcmMvYmluL3BnX2R1
bXAvcGdfcmVzdG9yZS5jCmluZGV4IGQ1NDMxMjk3YTEuLmIxOWU2ZjAxODEgMTAwNjQ0Ci0tLSBh
L3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jl
c3RvcmUuYwpAQCAtODgwLDEwICs4ODAsMTAgQEAgUmVhZE9uZVN0YXRlbWVudChTdHJpbmdJbmZv
IGluQnVmLCBGSUxFICpwZmlsZSkKIC8qCiAgKiBmaWx0ZXJfZGJuYW1lc19mb3JfcmVzdG9yZQog
ICoKLSAqIFRoaXMgd2lsbCByZW1vdmUgbmFtZXMgZnJvbSBhbGwgZGJsaXN0IHRob3NlIGNhbgot
ICogYmUgY29uc3RydWN0ZWQgZnJvbSBkYXRhYmFzZV9leGNsdWRlX3BhdHRlcm4gbGlzdC4KKyAq
IFRoaXMgd2lsbCByZW1vdmUgZW50cmllcyBmcm9tIGRibmFtZV9vaWRfbGlzdCB0aGF0IHBhdHRl
cm4gbWF0Y2hpbmcgYW55IGluIHRoZQorICogZGJfZXhjbHVkZV9wYXR0ZXJucyBsaXN0LiBkYm5h
bWVfb2lkX2xpc3QgbWF5YmUgaW5wbGFjZSBtb2RpZmllZC4KICAqCi0gKiByZXR1cm5zIG51bWJl
ciBvZiBkYm5hbWVzIHRob3NlIHdpbGwgYmUgcmVzdG9yZWQuCisgKiByZXR1cm5zIG51bWJlciBv
ZiBkYXRhYmFzZSB3aWxsIGJlIHJlc3RvcmVkLgogICovCiBzdGF0aWMgaW50CiBmaWx0ZXJfZGJu
YW1lc19mb3JfcmVzdG9yZShQR2Nvbm4gKmNvbm4sCkBAIC05MjIsNyArOTIyLDcgQEAgZmlsdGVy
X2RibmFtZXNfZm9yX3Jlc3RvcmUoUEdjb25uICpjb25uLAogCQkJICogcGdfY2F0YWxvZy5kZWZh
dWx0CiAJCQkgKgogCQkJICogWFhYIHJlcHJlc2VudHMgdGhlIHN0cmluZyBsaXRlcmFsIGRhdGFi
YXNlIG5hbWUgZGVyaXZlZCBmcm9tIHRoZQotCQkJICogZGJvaWRfbGlzdCB2YXJpYWJsZSwgd2hp
Y2ggaXMgaW5pdGlhbGx5IGV4dHJhY3RlZCBmcm9tIHRoZQorCQkJICogZGJuYW1lX29pZF9saXN0
LCB3aGljaCBpcyBpbml0aWFsbHkgZXh0cmFjdGVkIGZyb20gdGhlCiAJCQkgKiBtYXAuZGF0IGZp
bGUgbG9jYXRlZCBpbiB0aGUgYmFja3VwIGRpcmVjdG9yeS4gIHRoYXQncyB3aHkgd2UKIAkJCSAq
IG5lZWQgcXVvdGVfbGl0ZXJhbF9jc3RyLgogCQkJICoKQEAgLTk3Miw3ICs5NzIsNyBAQCBmaWx0
ZXJfZGJuYW1lc19mb3JfcmVzdG9yZShQR2Nvbm4gKmNvbm4sCiAJCX0KIAkJZWxzZQogCQl7Ci0J
CQljb3VudF9kYisrOyAvKiBJbmNyZW1lbnQgZGIgY291bnRlci4gKi8KKwkJCWNvdW50X2RiKys7
CiAJCQlkYm9pZHByZWNlbGwgPSBkYm9pZF9jZWxsOwogCQl9CiAKQEAgLTExNjAsNyArMTE2MCw3
IEBAIHJlc3RvcmVBbGxEYXRhYmFzZXMoUEdjb25uICpjb25uLCBjb25zdCBjaGFyICpkdW1wZGly
cGF0aCwKIAogCQkvKiBSZXN0b3JlIHNpbmdsZSBkYXRhYmFzZSBhbmQgc2F2ZSBleGl0X2NvZGUu
ICovCiAJCWRiZXhpdF9jb2RlID0gcmVzdG9yZU9uZURhdGFiYXNlKHN1YmRpcnBhdGgsIG9wdHMs
IG51bVdvcmtlcnMsCi0JCQkJdHJ1ZSwgZGJvaWRfY2VsbC0+ZGJfbmFtZSk7CisJCQkJCQkJCQkJ
IHRydWUsIGRib2lkX2NlbGwtPmRiX25hbWUpOwogCiAJCS8qIFN0b3JlIGV4aXRfY29kZSB0byBy
ZXBvcnQgaXQgYmFjay4gKi8KIAkJaWYgKGV4aXRfY29kZSA9PSAwICYmIGRiZXhpdF9jb2RlICE9
IDApCkBAIC0xMjgyLDcgKzEyODIsNyBAQCBjb3B5X2dsb2JhbF9maWxlX3RvX291dF9maWxlKGNv
bnN0IGNoYXIgKm91dGZpbGUsIEZJTEUgKnBmaWxlKQogICovCiBzdGF0aWMgdm9pZAogc2ltcGxl
X2RiX29pZF9saXN0X2FwcGVuZChTaW1wbGVEYXRhYmFzZU9pZExpc3QgKmxpc3QsIE9pZCBkYl9v
aWQsCi0JCWNvbnN0IGNoYXIgKmRibmFtZSkKKwkJCQkJCSAgY29uc3QgY2hhciAqZGJuYW1lKQog
ewogCVNpbXBsZURhdGFiYXNlT2lkTGlzdENlbGwgKmNlbGw7CiAKQEAgLTEzNTAsOCArMTM1MCw4
IEBAIHNpbXBsZV9zdHJpbmdfZnVsbF9saXN0X2RlbGV0ZShTaW1wbGVTdHJpbmdMaXN0ICpsaXN0
KQogICovCiBzdGF0aWMgdm9pZAogc2ltcGxlX2RiX29pZF9saXN0X2RlbGV0ZShTaW1wbGVEYXRh
YmFzZU9pZExpc3QgKmxpc3QsCi0JCVNpbXBsZURhdGFiYXNlT2lkTGlzdENlbGwgKmNlbGwsCi0J
CVNpbXBsZURhdGFiYXNlT2lkTGlzdENlbGwgKnByZXYpCisJCQkJCQkgIFNpbXBsZURhdGFiYXNl
T2lkTGlzdENlbGwgKmNlbGwsCisJCQkJCQkgIFNpbXBsZURhdGFiYXNlT2lkTGlzdENlbGwgKnBy
ZXYpCiB7CiAJaWYgKHByZXYgPT0gTlVMTCkKIAl7Cg==
--0000000000006237f6062e7d3255--