MIME-Version: 1.0
References: 
 <CACJufxHs1Hs00EqsZ4NbuAjmYzMzjJyP1sAj12Ne=cBsEVmQOA@mail.gmail.com>
 <CALdSSPiRHCyC0fYy_E=gO+c7sbwU=7=Fz2CF-4aEa3mAe7yYAg@mail.gmail.com>
In-Reply-To: 
 <CALdSSPiRHCyC0fYy_E=gO+c7sbwU=7=Fz2CF-4aEa3mAe7yYAg@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Mon, 13 Apr 2026 17:01:06 +0800
Message-ID: 
 <CACJufxGjgdWnhq5X5VL9orLXyKx-ZayT_Zj_-bAKr=kf0pZ_Nw@mail.gmail.com>
Subject: Re: DELETE/UPDATE FOR PORTION OF with rule system is not working
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Paul A Jungwirth <pj@illuminatedcomputing.com>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Type: multipart/mixed; boundary="0000000000004522f5064f53bb15"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxGjgdWnhq5X5VL9orLXyKx-ZayT_Zj_-bAKr%3Dkf0pZ_Nw%40mail.gmail.com>
Precedence: bulk

--0000000000004522f5064f53bb15
Content-Type: text/plain; charset="UTF-8"

hi.
Actually it's supported.

The issue mentioned in the first email is caused by:
https://git.postgresql.org/cgit/postgresql.git/commit/?id=8e72d914c52876525a90b28444453de8085c866f
https://git.postgresql.org/cgit/postgresql.git/diff/src/backend/nodes/nodeFuncs.c?id=8e72d914c52876525a90b28444453de8085c866f

--- a/src/backend/nodes/nodeFuncs.c
+++ b/src/backend/nodes/nodeFuncs.c
@@ -2579,6 +2579,20 @@ expression_tree_walker_impl(Node *node,
return true;
}
break;
+ case T_ForPortionOfExpr:
+ {
+ ForPortionOfExpr *forPortionOf = (ForPortionOfExpr *) node;
+
+ if (WALK(forPortionOf->targetFrom))
+ return true;
+ if (WALK(forPortionOf->targetTo))
+ return true;
+ if (WALK(forPortionOf->targetRange))
+ return true;
+ if (WALK(forPortionOf->overlapsExpr))
+ return true;
+ }
+ break;

We forgot to WALK (expression_tree_walker_impl)
ForPortionOfExpr->rangeVar and ForPortionOfExpr->rangeTargetList.
We need to WALK those two fields of ForPortionOfExpr in
rewriteRuleAction (ChangeVarNodes,
ReplaceVarsFromTargetList, etc.), and maybe elsewhere.

i am surprised that nothing else has broken because of this.


--
jian
https://www.enterprisedb.com/

--0000000000004522f5064f53bb15
Content-Type: text/x-patch; charset="US-ASCII";
	name="v1-0001-fix-DELETE-UPDATE-FOR-PORTION-OF-with-rule.patch"
Content-Disposition: attachment;
	filename="v1-0001-fix-DELETE-UPDATE-FOR-PORTION-OF-with-rule.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnwyq5r90>
X-Attachment-Id: f_mnwyq5r90

RnJvbSBhMzc4ZjQ3MTg4NjQwMDgzMWFlZDhjN2RlYjRhZWFhMWE5MjgxMWIyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IE1vbiwgMTMgQXByIDIwMjYgMTY6NDQ6NDMgKzA4MDAKU3ViamVjdDogW1BBVENIIHYx
IDEvMV0gZml4IERFTEVURS9VUERBVEUgRk9SIFBPUlRJT04gT0Ygd2l0aCBydWxlCgpkaXNjdXNz
aW9uOiBodHRwczovL3Bvc3Rnci5lcy9tL0NBQ0p1ZnhIczFIczAwRXFzWjROYnVBam1Zek16akp5
UDFzQWoxMk5lPWNCc0VWbVFPQUBtYWlsLmdtYWlsLmNvbQpjb21taXRmZXN0IGVudHJ5OiBodHRw
czovL2NvbW1pdGZlc3QucG9zdGdyZXNxbC5vcmcvcGF0Y2gvCi0tLQogc3JjL2JhY2tlbmQvbm9k
ZXMvbm9kZUZ1bmNzLmMgICAgICAgICAgICAgICAgfCAgNCArKwogc3JjL3Rlc3QvcmVncmVzcy9l
eHBlY3RlZC9mb3JfcG9ydGlvbl9vZi5vdXQgfCA0MCArKysrKysrKysrKysrKysrKysrKwogc3Jj
L3Rlc3QvcmVncmVzcy9zcWwvZm9yX3BvcnRpb25fb2Yuc3FsICAgICAgfCAyMiArKysrKysrKysr
KwogMyBmaWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL2Jh
Y2tlbmQvbm9kZXMvbm9kZUZ1bmNzLmMgYi9zcmMvYmFja2VuZC9ub2Rlcy9ub2RlRnVuY3MuYwpp
bmRleCBjMGI4ODBlYzIzMy4uN2VkYmQ1YjcyMjUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL25v
ZGVzL25vZGVGdW5jcy5jCisrKyBiL3NyYy9iYWNrZW5kL25vZGVzL25vZGVGdW5jcy5jCkBAIC0y
NTgzLDYgKzI1ODMsOCBAQCBleHByZXNzaW9uX3RyZWVfd2Fsa2VyX2ltcGwoTm9kZSAqbm9kZSwK
IAkJCXsKIAkJCQlGb3JQb3J0aW9uT2ZFeHByICpmb3JQb3J0aW9uT2YgPSAoRm9yUG9ydGlvbk9m
RXhwciAqKSBub2RlOwogCisJCQkJaWYgKFdBTEsoZm9yUG9ydGlvbk9mLT5yYW5nZVZhcikpCisJ
CQkJCXJldHVybiB0cnVlOwogCQkJCWlmIChXQUxLKGZvclBvcnRpb25PZi0+dGFyZ2V0RnJvbSkp
CiAJCQkJCXJldHVybiB0cnVlOwogCQkJCWlmIChXQUxLKGZvclBvcnRpb25PZi0+dGFyZ2V0VG8p
KQpAQCAtMjU5MSw2ICsyNTkzLDggQEAgZXhwcmVzc2lvbl90cmVlX3dhbGtlcl9pbXBsKE5vZGUg
Km5vZGUsCiAJCQkJCXJldHVybiB0cnVlOwogCQkJCWlmIChXQUxLKGZvclBvcnRpb25PZi0+b3Zl
cmxhcHNFeHByKSkKIAkJCQkJcmV0dXJuIHRydWU7CisJCQkJaWYgKFdBTEsoZm9yUG9ydGlvbk9m
LT5yYW5nZVRhcmdldExpc3QpKQorCQkJCQlyZXR1cm4gdHJ1ZTsKIAkJCX0KIAkJCWJyZWFrOwog
CQljYXNlIFRfUGFydGl0aW9uUHJ1bmVTdGVwT3A6CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdy
ZXNzL2V4cGVjdGVkL2Zvcl9wb3J0aW9uX29mLm91dCBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0
ZWQvZm9yX3BvcnRpb25fb2Yub3V0CmluZGV4IDMxZjc3MmM3MjNkLi4wOGUwZDk5YTljMyAxMDA2
NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9mb3JfcG9ydGlvbl9vZi5vdXQKKysr
IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9mb3JfcG9ydGlvbl9vZi5vdXQKQEAgLTIwOTcs
NCArMjA5Nyw0NCBAQCBTRUxFQ1QgKiBGUk9NIHRlbXBvcmFsX3BhcnRpdGlvbmVkXzUgT1JERVIg
QlkgaWQsIHZhbGlkX2F0OwogKDQgcm93cykKIAogRFJPUCBUQUJMRSB0ZW1wb3JhbF9wYXJ0aXRp
b25lZDsKKy0tIFVQREFURS9ERUxFVEUgRk9SIFBPUlRJT04gT0Ygd2l0aCBSVUxFcworQ1JFQVRF
IFRBQkxFIGZwb19ydWxlIChmMSBiaWdpbnQsIGYyIGludDRyYW5nZSk7CitJTlNFUlQgSU5UTyBm
cG9fcnVsZSBWQUxVRVMgKDEsICdbMSwgMTBdJyk7CitDUkVBVEUgUlVMRSBmcG9fcnVsZTEgQVMg
T04gSU5TRVJUIFRPIGZwb19ydWxlIERPIElOU1RFQUQgVVBEQVRFIGZwb19ydWxlIEZPUiBQT1JU
SU9OIE9GIGYyIEZST00gMSBUTyA0IFNFVCBmMSA9IDI7CitJTlNFUlQgSU5UTyBmcG9fcnVsZSBW
QUxVRVMgKDEsICdbMSwgMTBdJyk7CitTRUxFQ1QgKiBGUk9NIGZwb19ydWxlIE9SREVSIEJZIGYx
OworIGYxIHwgICBmMiAgIAorLS0tLSstLS0tLS0tLQorICAxIHwgWzQsMTEpCisgIDIgfCBbMSw0
KQorKDIgcm93cykKKworQ1JFQVRFIFJVTEUgZnBvX3J1bGUyIEFTIE9OIElOU0VSVCBUTyBmcG9f
cnVsZSBETyBJTlNURUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZS
T00gMSBUTyA0OworSU5TRVJUIElOVE8gZnBvX3J1bGUgVkFMVUVTICgxLCAnWzEsIDEwXScpOwor
U0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKyBmMSB8ICAgZjIgICAKKy0tLS0r
LS0tLS0tLS0KKyAgMSB8IFs0LDExKQorKDEgcm93KQorCitDUkVBVEUgUlVMRSBmcG9fcnVsZTMg
QVMgT04gREVMRVRFIFRPIGZwb19ydWxlIERPIElOU1RFQUQgVVBEQVRFIGZwb19ydWxlIEZPUiBQ
T1JUSU9OIE9GIGYyIEZST00gMSBUTyA4IFNFVCBmMSA9IDI7CitERUxFVEUgRlJPTSBmcG9fcnVs
ZSBGT1IgUE9SVElPTiBPRiBmMiBGUk9NIDEgVE8gNTsKK1NFTEVDVCAqIEZST00gZnBvX3J1bGUg
T1JERVIgQlkgZjE7CisgZjEgfCAgIGYyICAgCistLS0tKy0tLS0tLS0tCisgIDEgfCBbOCwxMSkK
KyAgMiB8IFs0LDgpCisoMiByb3dzKQorCitEUk9QIFJVTEUgZnBvX3J1bGUzIE9OIGZwb19ydWxl
OworQ1JFQVRFIFJVTEUgZnBvX3J1bGU0IEFTIE9OIFVQREFURSBUTyBmcG9fcnVsZSBETyBJTlNU
RUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gNiBUTyA5Owor
VVBEQVRFIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gNCBUTyA5IFNFVCBmMSA9IDEy
OworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKyBmMSB8ICAgZjIgICAKKy0t
LS0rLS0tLS0tLS0KKyAgMSB8IFs5LDExKQorICAyIHwgWzQsNikKKygyIHJvd3MpCisKK0RST1Ag
VEFCTEUgZnBvX3J1bGU7CiBSRVNFVCBkYXRlc3R5bGU7CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9y
ZWdyZXNzL3NxbC9mb3JfcG9ydGlvbl9vZi5zcWwgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3Jf
cG9ydGlvbl9vZi5zcWwKaW5kZXggZDQwNjJhY2YxZDEuLjUzYmZhNzA1ZTM5IDEwMDY0NAotLS0g
YS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9mb3JfcG9ydGlvbl9vZi5zcWwKKysrIGIvc3JjL3Rlc3Qv
cmVncmVzcy9zcWwvZm9yX3BvcnRpb25fb2Yuc3FsCkBAIC0xMzY1LDQgKzEzNjUsMjYgQEAgU0VM
RUNUICogRlJPTSB0ZW1wb3JhbF9wYXJ0aXRpb25lZF81IE9SREVSIEJZIGlkLCB2YWxpZF9hdDsK
IAogRFJPUCBUQUJMRSB0ZW1wb3JhbF9wYXJ0aXRpb25lZDsKIAorLS0gVVBEQVRFL0RFTEVURSBG
T1IgUE9SVElPTiBPRiB3aXRoIFJVTEVzCitDUkVBVEUgVEFCTEUgZnBvX3J1bGUgKGYxIGJpZ2lu
dCwgZjIgaW50NHJhbmdlKTsKK0lOU0VSVCBJTlRPIGZwb19ydWxlIFZBTFVFUyAoMSwgJ1sxLCAx
MF0nKTsKKworQ1JFQVRFIFJVTEUgZnBvX3J1bGUxIEFTIE9OIElOU0VSVCBUTyBmcG9fcnVsZSBE
TyBJTlNURUFEIFVQREFURSBmcG9fcnVsZSBGT1IgUE9SVElPTiBPRiBmMiBGUk9NIDEgVE8gNCBT
RVQgZjEgPSAyOworSU5TRVJUIElOVE8gZnBvX3J1bGUgVkFMVUVTICgxLCAnWzEsIDEwXScpOwor
U0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsKKworQ1JFQVRFIFJVTEUgZnBvX3J1
bGUyIEFTIE9OIElOU0VSVCBUTyBmcG9fcnVsZSBETyBJTlNURUFEIERFTEVURSBGUk9NIGZwb19y
dWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00gMSBUTyA0OworSU5TRVJUIElOVE8gZnBvX3J1bGUg
VkFMVUVTICgxLCAnWzEsIDEwXScpOworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBm
MTsKKworQ1JFQVRFIFJVTEUgZnBvX3J1bGUzIEFTIE9OIERFTEVURSBUTyBmcG9fcnVsZSBETyBJ
TlNURUFEIFVQREFURSBmcG9fcnVsZSBGT1IgUE9SVElPTiBPRiBmMiBGUk9NIDEgVE8gOCBTRVQg
ZjEgPSAyOworREVMRVRFIEZST00gZnBvX3J1bGUgRk9SIFBPUlRJT04gT0YgZjIgRlJPTSAxIFRP
IDU7CitTRUxFQ1QgKiBGUk9NIGZwb19ydWxlIE9SREVSIEJZIGYxOworCitEUk9QIFJVTEUgZnBv
X3J1bGUzIE9OIGZwb19ydWxlOworQ1JFQVRFIFJVTEUgZnBvX3J1bGU0IEFTIE9OIFVQREFURSBU
TyBmcG9fcnVsZSBETyBJTlNURUFEIERFTEVURSBGUk9NIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9G
IGYyIEZST00gNiBUTyA5OworVVBEQVRFIGZwb19ydWxlIEZPUiBQT1JUSU9OIE9GIGYyIEZST00g
NCBUTyA5IFNFVCBmMSA9IDEyOworU0VMRUNUICogRlJPTSBmcG9fcnVsZSBPUkRFUiBCWSBmMTsK
K0RST1AgVEFCTEUgZnBvX3J1bGU7CisKIFJFU0VUIGRhdGVzdHlsZTsKLS0gCjIuMzQuMQoK
--0000000000004522f5064f53bb15--