public inbox for [email protected]
help / color / mirror / Atom feedFrom: jian he <[email protected]>
To: Dmitry Koval <[email protected]>
Cc: [email protected]
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: Wed, 17 Sep 2025 15:35:34 +0800
Message-ID: <CACJufxGkVBQCj+fP=Dpy3-Hnkay6UqYwnWY+h_GaMgz0UGa9LQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org>
<[email protected]>
<CAPpHfdsW5_rFLwTfkYuG42nX5RbJCVhaC2vkn8p5GsT8Lseuyw@mail.gmail.com>
<[email protected]>
<CACJufxGEa6ZxP6d5VjZ6-Rpx=+u9zEE9ioRZRqQ=d_HYY6+daQ@mail.gmail.com>
<CACJufxGh=L6YPr37Y4t+ZfReBeWdv8aiNEk7VoyhYyP7d6L-4w@mail.gmail.com>
<CACJufxE4o-m9Eu0OX33aUgfTVT3p7b3u242-CCJaOpWUaFhS=A@mail.gmail.com>
<CACJufxEH45Rtkn=n9hjakeKEkH7ou8domh+iQHMp+18Wq_L-4g@mail.gmail.com>
<[email protected]>
<CACJufxGWCVf5r9kE-z6MyR2b+wkaU15Q5m2tKz4cvBhYX3-x1g@mail.gmail.com>
<[email protected]>
<CAPpHfdshkf0C2h09S00TVB8h3x8UT+GZyQ6LK2WGg1hOjnNE4g@mail.gmail.com>
<CAPpHfdsh_jPZ6-2JtWoFeZravVQYY4cYCcnKXQW6KxEx+F5vxg@mail.gmail.com>
<[email protected]>
<CACJufxF1Hfx1PST7pCLrKkGcjHEn2A51znXmYwVccnt5GDORcw@mail.gmail.com>
<[email protected]>
On Wed, Sep 17, 2025 at 6:08 AM Dmitry Koval <[email protected]> wrote:
>
> 2. Patch v56-0001-refactor-v56-check_partitions_for_split.no-cfbot
> applied with cosmetic changes.
>
hi.
check_two_partitions_bounds_range
ereport(ERROR,
errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
merge_split
? errmsg("can not merge partition \"%s\" together with
partition \"%s\"",
second_name->relname, first_name->relname)
: errmsg("can not split to partition \"%s\" together
with partition \"%s\"",
second_name->relname, first_name->relname),
errdetail("lower bound of partition \"%s\" is not
equal to the upper bound of partition \"%s\"",
second_name->relname, first_name->relname),
merge_split
? errhint("ALTER TABLE ... MERGE PARTITIONS requires
the partition bounds to be adjacent.")
: errhint("ALTER TABLE ... SPLIT PARTITIONS requires
the partition bounds to be adjacent."),
parser_errposition(pstate, datum->location));
This is too much...., also bad for translation, so I refactored this.
I also refactored check_partition_bounds_for_split_range.
In ATExecSplitPartition,
"char relname[NAMEDATALEN];" is not necessary?
Attachments:
[application/octet-stream] v57-0001-refactor-for-v57.no-cfbot (14.7K, ../CACJufxGkVBQCj+fP=Dpy3-Hnkay6UqYwnWY+h_GaMgz0UGa9LQ@mail.gmail.com/2-v57-0001-refactor-for-v57.no-cfbot)
download
view thread (165+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
In-Reply-To: <CACJufxGkVBQCj+fP=Dpy3-Hnkay6UqYwnWY+h_GaMgz0UGa9LQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox