MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql> <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
 <CACJufxGcZ1rK94cgfdc9McCD7W-83PT9_cx5VoFeC-HVc10Wzg@mail.gmail.com>
 <CAKYtNAqd4k+4+XANxjDc35i+WPme476DkP7msjYpX85F+4UsUg@mail.gmail.com>
 <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
 <CACJufxEtDgADBXQhX5cp3mJtNVMy+j+Jdovuk3PWe5qJ0sE3Ag@mail.gmail.com>
 <CAKYtNArwUxqR=LkQY1PT7tw+raMhf53oafo4WmSHGPHiER9d=A@mail.gmail.com>
 <CACJufxHUDGWe=2ZukvMfuwEcSK8CsVYm=9+rtPnrW7CRCfoCsw@mail.gmail.com>
 <CACJufxGOy1kAot+SAD9siKB797rj9K-bqeZOrS4fDYFFLo31bA@mail.gmail.com>
 <CAKYtNApE=x0sZxU3c9KqsYRU3dCztcfhQ+CDWhzgtH83HQUkuA@mail.gmail.com>
 <CACJufxHNNjAhVYJQS8x5U-9Fqsj6+tzG4uCivk2XTAOPTmstTA@mail.gmail.com>
 <CACJufxFJ9yJ=+WAHpXbDxf077Xw3O+ZziTwS55+ZK5APJ+6mUg@mail.gmail.com>
 <CACJufxEA-Q2hatN_BLcNrgfo8-4-m102gDdwVp0NTbuM2zyeDA@mail.gmail.com>
 <CAKYtNAqWjU6-J=VA-9-CVDLh7nX_Y_MgdSgyLFb6yYyZ1NYsyg@mail.gmail.com>
 <CACJufxEFxaiqytZRpL0Xbj8_XEtTm8-A2FE6u_9vigGO3z5oZQ@mail.gmail.com>
 <CAKYtNAr732dgvu43vLRBnDK=dPBVWAFBKaCp0982kwp0Yn8DOA@mail.gmail.com>
 <CACJufxGwXjG80LZ4miX+dXaT+3z5Kf1Mf0P_7FnR+641oqfUyg@mail.gmail.com>
 <CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ@mail.gmail.com>
 <CAKYtNApzcsV3a_jR6oduA12yKrx=aBv+vcA=RseT-2rLrC2o_g@mail.gmail.com>
 <CAFC+b6p84_wtbviPu-mLNxfOPLozN8OOjWcz_tjoDf=SuVDMTQ@mail.gmail.com>
 <CAFC+b6qJ9BAmN-J2ha-Q08MPbZ2FqTUB++B0ouvSk72px3D-NA@mail.gmail.com>
 <CAKYtNAqsOwq-u-h0+WEm2nonwZD4S=9ri4-d0vhAGjNQZ7FjnQ@mail.gmail.com> <CAKYtNAr+YSMu1TkyXzsxtvCMRoya05_=1V_LFKDrL=XpYJ9DxQ@mail.gmail.com>
In-Reply-To: <CAKYtNAr+YSMu1TkyXzsxtvCMRoya05_=1V_LFKDrL=XpYJ9DxQ@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 29 Jan 2025 17:38:36 +0800
Message-ID: <CACJufxGp5p7_7EwNwg-GuKZO+XB9uxfWTZ+QWhhNvwgUF0Vb0w@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="0000000000000b1444062cd51563"
Archived-At: <https://www.postgresql.org/message-id/CACJufxGp5p7_7EwNwg-GuKZO%2BXB9uxfWTZ%2BQWhhNvwgUF0Vb0w%40mail.gmail.com>
Precedence: bulk

--0000000000000b1444062cd51563
Content-Type: text/plain; charset="UTF-8"

hi.

we need to escape the semicolon within the single quotes or double quotes.
I think my patch in [1] is correct.

we can have "ERROR:  role "z" already exists
but
error message like
pg_restore: error: could not execute query: "ERROR:  unterminated
quoted string at or near "';
should not be accepted in execute_global_sql_commands, ReadOneStatement, PQexec

attached is the all the corner test case i come up with against
ReadOneStatement.
your v13 will generate errors like "ERROR:  unterminated quoted string
at or near ..."',
which is not good, i think.

[1] https://www.postgresql.org/message-id/CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ%40mail.gmail.com

--0000000000000b1444062cd51563
Content-Type: application/sql; name="global_object_quotes_escape_tests.sql"
Content-Disposition: attachment; 
	filename="global_object_quotes_escape_tests.sql"
Content-Transfer-Encoding: base64
Content-ID: <f_m6hpnnwf0>
X-Attachment-Id: f_m6hpnnwf0

CmNyZWF0ZSByb2xlIHg7CmNvbW1lbnQgb24gcm9sZSB4IGlzICQkIifwn5iKOyIiJyQkOwpBTFRF
UiBST0xFIHggSU4gREFUQUJBU0UgdGVtcGxhdGUxIFNFVCBjbGllbnRfbWluX21lc3NhZ2VzID0g
J0RFQlVHJzsKQUxURVIgUk9MRSB4IFNFVCBtYWludGVuYW5jZV93b3JrX21lbSA9IDEwMDAwMDsK
Q1JFQVRFIFJPTEUgeDEgV0lUSCBMT0dJTiBQQVNTV09SRCAnanc4czBGNCcgVkFMSUQgVU5USUwg
JzIwMDUtMDEtMDEnOwpjb21tZW50IG9uIHJvbGUgeDEgaXMgJCQiJzsiJycKJCQ7CgpDUkVBVEUg
Uk9MRSB4MiBXSVRIIExPR0lOIFBBU1NXT1JEICdqdzhzMEYiNCc7CmNvbW1lbnQgb24gcm9sZSB4
MiBpcyAkJCc7IiQkOwoKY3JlYXRlIHJvbGUgeTsKY29tbWVudCBvbiByb2xlIHkgaXMgJCQ7Iick
JDsKY3JlYXRlIHJvbGUgIiciOwpjcmVhdGUgcm9sZSAiJyc7IjsKY3JlYXRlIHJvbGUgIic7Ozsn
OyI7CmNyZWF0ZSByb2xlIHo7CmNvbW1lbnQgb24gcm9sZSB6IGlzICQkIiI7JzskJDsKCmNyZWF0
ZSByb2xlICI7Cic7CjsKIjsKY3JlYXRlIHJvbGUgIjsiOwpjb21tZW50IG9uIHJvbGUgIjsiIGlz
ICQkOyInOycsIiwnICQkOwpjb21tZW50IG9uIHJvbGUgIjsiIGlzICQkOyInOycsIiwnIAoKJCQ7
CgpjcmVhdGUgcm9sZSAiCgoiOwpjb21tZW50IG9uIHJvbGUgeiBpcyAkJDsiJzsnLCIsJyc7Oyci
IjskJDs=
--0000000000000b1444062cd51563--