MIME-Version: 1.0
References: <202507262156.sb455angijk6@alvherre.pgsql>
 <202510301734.pj4uds3mqxx4@alvherre.pgsql>
 <CACJufxFPiasoUXFR4SK2QRq6mnztiX=3F82=8PyBrdocX5awBw@mail.gmail.com>
 <CAJSLCQ0UhdwrF-FBHN6DuPNmTb8mqq-=_jdxjscqoMXjnBkJbw@mail.gmail.com>
In-Reply-To: 
 <CAJSLCQ0UhdwrF-FBHN6DuPNmTb8mqq-=_jdxjscqoMXjnBkJbw@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 5 Nov 2025 16:46:04 +0800
Message-ID: 
 <CACJufxGp7HOxw_6V+xEUg=5=XUpxdH33LUdXuLjEyQHEWfjOzQ@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Robert Treat <rob@xzilla.net>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Antonin Houska <ah@cybertec.at>,
	Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxGp7HOxw_6V%2BxEUg%3D5%3DXUpxdH33LUdXuLjEyQHEWfjOzQ%40mail.gmail.com>
Precedence: bulk

On Wed, Nov 5, 2025 at 1:11=E2=80=AFPM Robert Treat <rob@xzilla.net> wrote:
> > --------------------
> >
> > + printf(_("      --index[=3DINDEX]             repack following an ind=
ex\n"));
> > should it be
> > + printf(_("--index[=3DINDEX]                   repack following an ind=
ex\n"));
> > ?
> >
>
> I believe this is included for alignment, since this option has no
> shorthand version.
>

if you compare pg_dump --help, pg_repackdb --help
then you will see the inconsistency.

This is legacy behavior, but can we move some of the error checks in
do_analyze_rel to an earlier point?
we call cluster_rel before analyze_rel, cluster_rel is way more time-consum=
ing,
a failure in analyze_rel means all the previous work (cluster_rel) is waste=
d.

+ else if (HeadMatches("REPACK", "(*") &&
+ !HeadMatches("REPACK", "(*)"))
+ {
+ /*
+ * This fires if we're in an unfinished parenthesized option list.
+ * get_previous_words treats a completed parenthesized option list as
+ * one word, so the above test is correct.
+ */
+ if (ends_with(prev_wd, '(') || ends_with(prev_wd, ','))
+ COMPLETE_WITH("VERBOSE");
+ else if (TailMatches("VERBOSE"))
+ COMPLETE_WITH("ON", "OFF");
+ }
this part can also support the ANALYZE option?

ClusterStmt
should be removed from src/tools/pgindent/typedefs.list?

doc/src/sgml/ref/clusterdb.sgml
  <para>
   <application>clusterdb</application> has been superceded by
   <application>pg_repackdb</application>.
  </para>
google told me, "superceded" should be "superseded"

--
jian he
EDB: http://www.enterprisedb.com