public inbox for [email protected]  

help / color / mirror / Atom feed

From: jian he <[email protected]>
To: Chao Li <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: Fix SET EXPRESSION for virtual columns with whole-row dependencies
Date: Mon, 15 Jun 2026 14:43:36 +0800
Message-ID: <CACJufxGxns84RGwn9ZtzuBMCjzEc1EHKcxx+cNPER_aY7iDySw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CACJufxHTK0Qk7AwdrHK=y8OtK--zEVY-Ossxx4UUgxaE2NCAXA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CACJufxHaErSjsxkhMJVS9zuGvrgej831ibieAvn1+1o-GQ8dFg@mail.gmail.com>
	<[email protected]>

On Sat, Jun 13, 2026 at 2:02 PM Chao Li <[email protected]> wrote:
>
> > On Jun 13, 2026, at 10:42, jian he <[email protected]> wrote:
> >
> > On Wed, Jun 10, 2026 at 5:06 PM Chao Li <[email protected]> wrote:
> >>
> >>
> >> After reading the other implementation in [1], I realized that I had missed the partial-index case, so I added coverage for that.
> >>
> >> I am still sending an updated version of this patch because my implementation is different from the one in [1]. I would like people to compare the two approaches and decide which direction is better.
> >>
> >
> > I tried your patch before but abandoned it due to many regression test failures.
> >
>
> Thanks for looking. But I wonder which tests I missed?
>
> I ran “make check-world” locally and passed. The CI tests all passed on the CF: https://commitfest.postgresql.org/patch/6867/
>

Apologies for the confusion.

I meant that I actually tried the same idea earlier, but abandoned it
after seeing many regression test failures.

Your v2 patch passes all the regression tests because of the special handling
added to the DEFAULT branch in RememberAllDependentForRebuilding. However, the
point of my previous message was that I am worried this special
handling below might
not be bulletproof (if foundObject.classId is not TypeRelationId, then
elog(ERROR) will be reached):


  /*
  * We don't expect any other sorts of objects to depend on a
- * column.
+ * column.  A whole-relation scan can find the relation's row
+ * type, which doesn't need rebuilding for SET EXPRESSION.
  */
+ if (attnum == 0 &&
+ foundObject.classId == TypeRelationId &&
+ get_typ_typrelid(foundObject.objectId) == RelationGetRelid(rel))
+ continue;
+

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix SET EXPRESSION for virtual columns with whole-row dependencies
  In-Reply-To: <CACJufxGxns84RGwn9ZtzuBMCjzEc1EHKcxx+cNPER_aY7iDySw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox