MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql> <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
 <CACJufxGcZ1rK94cgfdc9McCD7W-83PT9_cx5VoFeC-HVc10Wzg@mail.gmail.com>
 <CAKYtNAqd4k+4+XANxjDc35i+WPme476DkP7msjYpX85F+4UsUg@mail.gmail.com>
 <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
 <CACJufxEtDgADBXQhX5cp3mJtNVMy+j+Jdovuk3PWe5qJ0sE3Ag@mail.gmail.com>
 <CAKYtNArwUxqR=LkQY1PT7tw+raMhf53oafo4WmSHGPHiER9d=A@mail.gmail.com>
 <CACJufxHUDGWe=2ZukvMfuwEcSK8CsVYm=9+rtPnrW7CRCfoCsw@mail.gmail.com>
 <CACJufxGOy1kAot+SAD9siKB797rj9K-bqeZOrS4fDYFFLo31bA@mail.gmail.com>
 <CAKYtNApE=x0sZxU3c9KqsYRU3dCztcfhQ+CDWhzgtH83HQUkuA@mail.gmail.com>
 <CACJufxHNNjAhVYJQS8x5U-9Fqsj6+tzG4uCivk2XTAOPTmstTA@mail.gmail.com>
 <CACJufxFJ9yJ=+WAHpXbDxf077Xw3O+ZziTwS55+ZK5APJ+6mUg@mail.gmail.com>
 <CACJufxEA-Q2hatN_BLcNrgfo8-4-m102gDdwVp0NTbuM2zyeDA@mail.gmail.com>
 <CAKYtNAqWjU6-J=VA-9-CVDLh7nX_Y_MgdSgyLFb6yYyZ1NYsyg@mail.gmail.com>
 <CACJufxEFxaiqytZRpL0Xbj8_XEtTm8-A2FE6u_9vigGO3z5oZQ@mail.gmail.com>
 <CAKYtNAr732dgvu43vLRBnDK=dPBVWAFBKaCp0982kwp0Yn8DOA@mail.gmail.com>
 <CACJufxGwXjG80LZ4miX+dXaT+3z5Kf1Mf0P_7FnR+641oqfUyg@mail.gmail.com>
 <CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ@mail.gmail.com>
 <CAKYtNApzcsV3a_jR6oduA12yKrx=aBv+vcA=RseT-2rLrC2o_g@mail.gmail.com>
 <CAFC+b6p84_wtbviPu-mLNxfOPLozN8OOjWcz_tjoDf=SuVDMTQ@mail.gmail.com>
 <CAFC+b6qJ9BAmN-J2ha-Q08MPbZ2FqTUB++B0ouvSk72px3D-NA@mail.gmail.com>
 <CAKYtNAqsOwq-u-h0+WEm2nonwZD4S=9ri4-d0vhAGjNQZ7FjnQ@mail.gmail.com>
 <CAKYtNAr+YSMu1TkyXzsxtvCMRoya05_=1V_LFKDrL=XpYJ9DxQ@mail.gmail.com>
 <CACJufxGp5p7_7EwNwg-GuKZO+XB9uxfWTZ+QWhhNvwgUF0Vb0w@mail.gmail.com>
 <CACJufxGoUgqv+T1MXuh_SH_FTwTMpqfUcntHP1c5Q7KnyPXgKQ@mail.gmail.com>
 <CACJufxFWFLZhtgk92HR78tKiYk0yRX-26v2y1eEN2NtjyXtU4A@mail.gmail.com>
 <CAKYtNApkrfDHyN5z+Spbat1xzVOEL9y5o+ALimYmb3eH3T8Vhw@mail.gmail.com>
 <CACJufxFrzYJ0oZNm=v9hg10UpPQNe+p0+2ydNirHxyhUT_JtXw@mail.gmail.com>
 <CAKYtNAqP=URFvX2dqH5RT+wmd9nrnrfH45rvD2H_w9zNBvJqQA@mail.gmail.com>
 <CACJufxEcGGddRgwDLafyi+GJDOamPR4rrPG_0tZp6Rh81mEPfA@mail.gmail.com>
 <CAKYtNApSjr=etW+uVQ2KW0NcV=aZq-QdOd0jULync=84iDWr-w@mail.gmail.com>
 <CACJufxEAWxWovH_dys5A2z53OGpftX_jJRTd1y8eB3HaojY+1A@mail.gmail.com> <CAKYtNAoRswr5B_sH-4o-V=UA74EpUKHbnXosG0Mk1=UJQfRWtA@mail.gmail.com>
In-Reply-To: <CAKYtNAoRswr5B_sH-4o-V=UA74EpUKHbnXosG0Mk1=UJQfRWtA@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Wed, 12 Feb 2025 15:14:34 +0800
Message-ID: <CACJufxH3T9OFg53HDXydLCKgHFVqAmbOu_huJpitVtggdP31fw@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000003b480062decb494"
Archived-At: <https://www.postgresql.org/message-id/CACJufxH3T9OFg53HDXydLCKgHFVqAmbOu_huJpitVtggdP31fw%40mail.gmail.com>
Precedence: bulk

--00000000000003b480062decb494
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 12, 2025 at 1:17=E2=80=AFAM Mahendra Singh Thalor
<mahi6run@gmail.com> wrote:
>
> >
> > There are some tests per https://commitfest.postgresql.org/52/5495, I
> > will check it later.

hi.
the cfbot failure is related to function _tocEntryRequired

  if (strcmp(te->desc, "DATABASE") =3D=3D 0 ||
  strcmp(te->desc, "DATABASE PROPERTIES") =3D=3D 0)
  {
- if (ropt->createDB)
+ if (ropt->createDB || AH->format !=3D archNull)
  return REQ_SCHEMA;
  else
  return 0;

for restoring multiple databases:
in v16 implementation: pg_restore even if you do not specify --create,
it actually did what pg_restore --create option does.

if there are multiple databases in the archive:
to make the pg_restore --file output is usable, the output file need
have \connect and CREATE DATABASE
command. that is exactly what  --create option would do.
pg_restore --file behavior need align with pg_restore --dbname.
therefore pg_restore restoring multiple databases will use --create option.


we can either error out (pg_fatal) saying
restoring multiple databases requires the pg_restore --create option.
Or we can add a pg_log_info saying
pg_restore --create option will be set to true while restoring
multiple databases.


for restoring one database, the master behavior is fine.
so we don't need to change _tocEntryRequired.

--00000000000003b480062decb494
Content-Type: application/octet-stream; name="v16_misc.nocfbot"
Content-Disposition: attachment; filename="v16_misc.nocfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_m71kgx7s0>
X-Attachment-Id: f_m71kgx7s0

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19iYWNrdXBfYXJjaGl2ZXIuYyBiL3NyYy9i
aW4vcGdfZHVtcC9wZ19iYWNrdXBfYXJjaGl2ZXIuYwppbmRleCAzMmQ2NDU3MjhhLi4xZGZhMDQy
MGVhIDEwMDY0NAotLS0gYS9zcmMvYmluL3BnX2R1bXAvcGdfYmFja3VwX2FyY2hpdmVyLmMKKysr
IGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2JhY2t1cF9hcmNoaXZlci5jCkBAIC0yOTM0LDEzICsyOTM0
LDEzIEBAIF90b2NFbnRyeVJlcXVpcmVkKFRvY0VudHJ5ICp0ZSwgdGVTZWN0aW9uIGN1clNlY3Rp
b24sIEFyY2hpdmVIYW5kbGUgKkFIKQogCiAJLyoKIAkgKiBEQVRBQkFTRSBhbmQgREFUQUJBU0Ug
UFJPUEVSVElFUyBhbHNvIGhhdmUgYSBzcGVjaWFsIHJ1bGU6IHRoZXkgYXJlCi0JICogcmVzdG9y
ZWQgaW4gY3JlYXRlREIgbW9kZSBvciByZXN0b3JlZCBmb3JtYXQgaXMgbm90IHBsYWluIGZpbGUs
IGFuZCBub3QKLQkgKiByZXN0b3JlZCBvdGhlcndpc2UsIGluZGVwZW5kZW50bHkgb2YgYWxsIGVs
c2UuCisJICogcmVzdG9yZWQgaW4gY3JlYXRlREIgbW9kZSwgYW5kIG5vdCByZXN0b3JlZCBvdGhl
cndpc2UsIGluZGVwZW5kZW50bHkgb2YKKwkgKiBhbGwgZWxzZS4KIAkgKi8KIAlpZiAoc3RyY21w
KHRlLT5kZXNjLCAiREFUQUJBU0UiKSA9PSAwIHx8CiAJCXN0cmNtcCh0ZS0+ZGVzYywgIkRBVEFC
QVNFIFBST1BFUlRJRVMiKSA9PSAwKQogCXsKLQkJaWYgKHJvcHQtPmNyZWF0ZURCIHx8IEFILT5m
b3JtYXQgIT0gYXJjaE51bGwpCisJCWlmIChyb3B0LT5jcmVhdGVEQikKIAkJCXJldHVybiBSRVFf
U0NIRU1BOwogCQllbHNlCiAJCQlyZXR1cm4gMDsKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVt
cC9wZ19yZXN0b3JlLmMgYi9zcmMvYmluL3BnX2R1bXAvcGdfcmVzdG9yZS5jCmluZGV4IGFmN2Q4
MTVhNzcuLjJkM2FlMTRmNzUgMTAwNjQ0Ci0tLSBhL3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3Jl
LmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jlc3RvcmUuYwpAQCAtMTA5MCw4ICsxMDkwLDEx
IEBAIHJlc3RvcmVBbGxEYXRhYmFzZXMoUEdjb25uICpjb25uLCBjb25zdCBjaGFyICpkdW1wZGly
cGF0aCwKIAkgKiBUbyByZXN0b3JlIG11bHRpcGxlIGRhdGFiYXNlcywgLUMgKGNyZWF0ZSBkYXRh
YmFzZSkgb3B0aW9uIHNob3VsZCBiZSBzcGVjaWZpZWQKIAkgKiBvciBhbGwgZGF0YWJhc2VzIHNo
b3VsZCBiZSBjcmVhdGVkIGJlZm9yZSBwZ19yZXN0b3JlLgogCSAqLwotCWlmIChvcHRzLT5jcmVh
dGVEQiAhPSAxKQotCQlwZ19sb2dfaW5mbygicmVzdG9yaW5nIGR1bXAgb2YgcGdfZHVtcGFsbCB3
aXRob3V0IC1DIG9wdGlvbiwgdGhlcmUgbWlnaHQgYmUgbXVsdGlwbGUgZGF0YWJhc2VzIGluIGRp
cmVjdG9yeS4iKTsKKwlpZiAobnVtX2RiX3Jlc3RvcmUgPiAxICYmIG9wdHMtPmNyZWF0ZURCICE9
IDEpCisJeworCQlwZ19sb2dfaW5mbygicmVzdG9yaW5nIG11bHRpcGxlIGRhdGFiYXNlcyB3aXRo
b3V0IC1DIG9wdGlvbiwgaW1wbGljaXQgLUMgaXMgYXNzdW1lZCIpOworCQlvcHRzLT5jcmVhdGVE
QiA9IDE7CisJfQogCiAJLyogVE9ETzogTUFYX09OX0VYSVRfTklDRUxZIGlzIDEwMCBub3cuLi4g
bWF4IEFIIGhhbmRsZSByZWdpc3RlciBvbiBleGl0IC4qLwogCWlmIChudW1fZGJfcmVzdG9yZSA+
IE1BWF9PTl9FWElUX05JQ0VMWSkKQEAgLTExNDQsNyArMTE0NywxMCBAQCByZXN0b3JlQWxsRGF0
YWJhc2VzKFBHY29ubiAqY29ubiwgY29uc3QgY2hhciAqZHVtcGRpcnBhdGgsCiAKIAkJcGdfbG9n
X2luZm8oInJlc3RvcmluZyBkYXRhYmFzZSBcIiVzXCIiLCBkYm9pZF9jZWxsLT5kYl9uYW1lKTsK
IAotCQlkYmV4aXRfY29kZSA9IHJlc3RvcmVPbmVEYXRhYmFzZShzdWJkaXJwYXRoLCBvcHRzLCBu
dW1Xb3JrZXJzLCB0cnVlLCBkYm9pZF9jZWxsLT5kYl9uYW1lKTsKKwkJaWYgKG51bV9kYl9yZXN0
b3JlID09IDEpCisJCQlkYmV4aXRfY29kZSA9IHJlc3RvcmVPbmVEYXRhYmFzZShzdWJkaXJwYXRo
LCBvcHRzLCBudW1Xb3JrZXJzLCBmYWxzZSwgZGJvaWRfY2VsbC0+ZGJfbmFtZSk7CisJCWVsc2UK
KwkJCWRiZXhpdF9jb2RlID0gcmVzdG9yZU9uZURhdGFiYXNlKHN1YmRpcnBhdGgsIG9wdHMsIG51
bVdvcmtlcnMsIHRydWUsIGRib2lkX2NlbGwtPmRiX25hbWUpOwogCiAJCS8qIFN0b3JlIGV4aXRf
Y29kZSB0byByZXBvcnQgaXQgYmFjay4gKi8KIAkJaWYgKGV4aXRfY29kZSA9PSAwICYmIGRiZXhp
dF9jb2RlICE9IDApCg==
--00000000000003b480062decb494--