MIME-Version: 1.0
References: 
 <CACJufxHTBkymh06D4mGKNe1YfRNFN+gFBybmygWk=PtMqu00LQ@mail.gmail.com>
 <CAKFQuwYD477A9Oy2PxRr_KY8t=k=jbOUK83ie0dS7fcpBsXS3Q@mail.gmail.com>
 <CACJufxE9kt7fAz_g_6PO0PmxK=duWDx+dNUyEWHkGxmRw0EqOg@mail.gmail.com>
 <CAKFQuwZ=ZEkQaFZBRpukNn-qvk4U52ZAsrLLRPAC4hgcZsJmkQ@mail.gmail.com>
 <CACJufxFpzqdfYvsj2iWhtemRyPSB5O7_gb9vRd7cE1ZcVvmZnw@mail.gmail.com>
 <CAKFQuwa-j+oA23EVA7qk+AUdpi24d1LC_O9MH5oSnzOv2McEhg@mail.gmail.com>
 <CACJufxH0jqshH6SC97eQ7T=QcSYpbtKMR2=wmds=K2UT9t0tFw@mail.gmail.com>
 <CAKFQuwbPdo1MORJqnQj=eA6bGrvGu_U+8J+oTWw7QDvuX2oAQw@mail.gmail.com>
 <CACJufxGF6vU7KUMqHL0RehdvwVBENz2Q++ZyGJaCzk2_VVPqWQ@mail.gmail.com>
 <CAKFQuwZU=eY0F6jE4ekuPs5FMqNr2e-mJ=MTuaZTeDG+Xti1=g@mail.gmail.com>
 <CAB-JLwathhELcwARpTJ5cAh-Z6tS6V8PCXti9woGZMJiqzCPfA@mail.gmail.com>
 <CAKFQuwYSRa_Q-qpXMosT4HYx62aGjkiNA2A-d6dZhzTamHs6dw@mail.gmail.com>
 <CACJufxHbWiZLwzKs6k4+w=UjA_wDEEhWgH2fpUexxgvHOP_OWA@mail.gmail.com>
 <CACJufxHDCHsKp_8U8cQvnQpa8mPy1bJ5jjdcmjHGT9weoAT4bg@mail.gmail.com>
 <d4a5d8fd-cb3a-4615-a44e-b45a5557d350@dunslane.net>
In-Reply-To: <d4a5d8fd-cb3a-4615-a44e-b45a5557d350@dunslane.net>
From: jian he <jian.universality@gmail.com>
Date: Mon, 13 Oct 2025 23:26:46 +0800
Message-ID: 
 <CACJufxH3dnnQKRuPNhUtHEUN=XkAGsPmEfMpAW5zo=3CvVbgzQ@mail.gmail.com>
Subject: Re: add function argument name to substring and substr
To: Andrew Dunstan <andrew@dunslane.net>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
 Marcos Pegoraro <marcos@f10.com.br>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxH3dnnQKRuPNhUtHEUN%3DXkAGsPmEfMpAW5zo%3D3CvVbgzQ%40mail.gmail.com>
Precedence: bulk

On Mon, Oct 13, 2025 at 10:58=E2=80=AFPM Andrew Dunstan <andrew@dunslane.ne=
t> wrote:
>
> I'm late to the party on this, but I wonder if it wouldn't be better to
> use a type-neutral parameter name here, like "source", which could cover
> all these cases, instead of "string", "bytes", etc.
>

\df *regexp*

psql output generally begins with "string text, pattern text"
that's because of commit 580f872.

in that commit, discussion,
https://www.postgresql.org/message-id/CACJufxG3NFKKsh6x4fRLv8h3V-HvN4W5dA%3=
DzNKMxsNcDwOKang%40mail.gmail.com,
in that first patch, i did tried to use "source" in some cases, then I foun=
d out
if you changed to "source" then all the documentation also needs to be
changed.  so
I stuck to "string" in commit 580f872.

Here, for the functions substr and substring, I followed the precedent set =
by
the regex function using the term "string".

sure, we can change it to "source" if that's what people want.