Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKZz3-003Mtf-OY for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jan 2024 08:18:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rKZz2-00EcEH-Dg for pgsql-hackers@arkaria.postgresql.org; Tue, 02 Jan 2024 08:18:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rKZz2-00EcE9-4I for pgsql-hackers@lists.postgresql.org; Tue, 02 Jan 2024 08:18:44 +0000 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rKZyy-00F7ai-Ut for pgsql-hackers@lists.postgresql.org; Tue, 02 Jan 2024 08:18:43 +0000 Received: by mail-vs1-xe34.google.com with SMTP id ada2fe7eead31-466fb179334so584630137.1 for ; Tue, 02 Jan 2024 00:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704183519; x=1704788319; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1zI8oWQZa7M477aMAAN26973vZBXLAx3FSqSVqgR6BI=; b=G1GQUCOMy+eRY8QkKpkurKLResmCe6sHS/fd73T4Gx0DCsXRXevrBGzP1+U1rWbiZ0 qJyGhYJYYBzMSMZ/tD9/sEJp0lVoedgF1StMRk7mYm3hzkn2l2FoABtjAPanf6IPq5Xv pJhxmr3THUN0dFQz94iAFMB6TJVkgoPsxE2/RpTQUrTFh/JI+HikmEsNQKS2/L+wQxfg 4DSTggBemk8H17SBD6qhk0KNKZaTEpdIgHGBVs8U8KFpe1KpmnzGtGpOzbYGamE22MnR rIDpnDvkOAypakOFPPj8Gg4c/OMuw+MgGmr+X0uqfL7guCEz7zsx+OYlqWG4zvcd+mW4 IsrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704183519; x=1704788319; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1zI8oWQZa7M477aMAAN26973vZBXLAx3FSqSVqgR6BI=; b=pB0GJ2iJu8c8/d/9rhyEyV4maIwMuEZHlBoTKaDkLApv5Ho7sl48ZE8g25II8zkCLO uz86RVmRTjZ/rAtziWlyctwaEoHaA12TxRUO31/7G1GM3/AvLRN1tgpVOSqYI82hwwXI zQAtacXp4TlKyXB5jZ26QLRflLe68kjtWqtW9j7oklJk1QdjzKC52Ifd5qd8Qguxw0uF iuxN1cbFLZhoq6MSyxeOkOXuvbzJSqPDCZMu2YiQhpit4pSjWFFjuMA6VSaZboIQO2u8 coxkUbaLFJvxSKz+Yl1iWib7W6nb8ROQXfHKKai3O/6yW4H7wJcL6UELMxvGWSesE88Q hY2g== X-Gm-Message-State: AOJu0Ywog2DkMvDO3J1iDMdz1VxBEw0j6y3u+gQyHKlywBHyu+LIzpDo SL5spd5Nxqd+lT7ryWaLdut509tDRtVOpTrviJo= X-Google-Smtp-Source: AGHT+IEwQMbsA+68+wgCAPav0HP8KiHiLagghI/qFbgV+kfPvG1fDjGB1wl5ziOGU085vcHJ82RgS8kc0E524Vm1o1s= X-Received: by 2002:a05:6102:3752:b0:467:88e3:82b3 with SMTP id u18-20020a056102375200b0046788e382b3mr358701vst.15.1704183519038; Tue, 02 Jan 2024 00:18:39 -0800 (PST) MIME-Version: 1.0 References: <169880504467.94392.3769687331705514588.pgcf@coridan.postgresql.org> <87a5rry0bz.fsf@163.com> In-Reply-To: <87a5rry0bz.fsf@163.com> From: jian he Date: Tue, 2 Jan 2024 16:18:00 +0800 Message-ID: Subject: Re: Extract numeric filed in JSONB more effectively To: zhihuifan1213@163.com Cc: Chapman Flack , pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk hi. you don't need to change src/include/catalog/catversion.h as mentioned in https://wiki.postgresql.org/wiki/Committing_checklist Otherwise, cfbot will fail many times. +typedef enum JsonbValueTarget +{ + JsonbValue_AsJsonbValue, + JsonbValue_AsJsonb, + JsonbValue_AsText +} JsonbValueTarget; change to +typedef enum JsonbValueTarget +{ + JsonbValue_AsJsonbValue, + JsonbValue_AsJsonb, + JsonbValue_AsText, +} JsonbValueTarget; currently cannot do `git apply`.