MIME-Version: 1.0
References: <d2d872c3-84f9-48f6-9963-f4537f02bc91@eisentraut.org>
 <adb15d59-2e6b-4d2e-ac5b-7aaea41f738f@gmail.com>
 <CAK98qZ2QGcyJrJAFv9wjY6S8yP9dUVnmG9Gb4OXuzuMMuM1Z5Q@mail.gmail.com>
 <b24dc997-d78f-47bd-b323-14e68232d127@dunslane.net>
 <21fa36b4-6d56-4556-b524-9e3955b922c8@eisentraut.org>
 <CAK98qZ3Ly6PhRwCVmMKJBba5oHVF9k370MMT2b_gep-SuQfRtg@mail.gmail.com>
 <CAK98qZ1za8XgOLY+2hQMPGoxVYFyh=dDkM2dZPVeJK4J6poyvA@mail.gmail.com>
 <CAK98qZ0EfrPcv3ZwGdeDiLPEpXYfHOEc8S2D=OCPJGcyWy5d-g@mail.gmail.com>
 <CAK98qZ1rZaVNy6ViangQom4iinZVH7=ebqhTsPxMQbN5ZtE9XQ@mail.gmail.com>
 <CAFY6G8cY5SUG5L-0ryVpom6HynE49p8-XQ59qkaEgnZZJ-c4Rg@mail.gmail.com>
 <CAFY6G8eUGcU3A4AHprgYbSOAOj7+WGhGxS_YP0wd2+aCpZTiNg@mail.gmail.com>
 <CAK98qZ14uKKRVFg4ibzMfReYaZD6Byxq8nYnvNNtXNjCfcd8kQ@mail.gmail.com>
 <CAHgHdKtL9nNaKXGCLt9gWugVzYWKhoBDQ7NESUwdCBty8kFK-A@mail.gmail.com>
 <CAK98qZ1nz6ZZhQqTOCNwRguZE5GsBLW5BQT_k=s7AA6gc2CN_g@mail.gmail.com>
 <c7dc6735-57cb-4287-871f-4c92a7205357@postgresfriends.org>
 <CAN-LCVM6A9z6AzxsEX-vx9=3XgEUU6+zjUqejQw8LfjaRY5P1A@mail.gmail.com>
 <CAK98qZ2Pmf6ZSChLq+CEPKJ_8jSa0gFTNJWJTcWbCziDpqa=CA@mail.gmail.com>
 <CACJufxEt5bL-xYojenA7x1Fq=-DfhW3KGH=3Zz9TjJ1k95=uuQ@mail.gmail.com>
 <CAK98qZ0whQ=c+JGXbGSEBxCtLgy6sf-YGYqsKTAGsS-wt0wj+A@mail.gmail.com>
In-Reply-To: 
 <CAK98qZ0whQ=c+JGXbGSEBxCtLgy6sf-YGYqsKTAGsS-wt0wj+A@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Thu, 10 Jul 2025 16:53:28 +0800
Message-ID: 
 <CACJufxHqiKbh1RN4-rquYdnS8qK9kEQq=bpt6ED_yo1+OkU8jg@mail.gmail.com>
Subject: Re: SQL:2023 JSON simplified accessor support
To: Alexandra Wang <alexandra.wang.oss@gmail.com>
Cc: Nikita Malakhov <hukutoc@gmail.com>,
 Vik Fearing <vik@postgresfriends.org>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
 Matheus Alcantara <matheusssilv97@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Andrew Dunstan <andrew@dunslane.net>,
	Nikita Glukhov <glukhov.n.a@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	"David E. Wheeler" <david@justatheory.com>
Content-Type: multipart/mixed; boundary="000000000000f2ffe306398f5577"
Archived-At: 
 <https://www.postgresql.org/message-id/CACJufxHqiKbh1RN4-rquYdnS8qK9kEQq%3Dbpt6ED_yo1%2BOkU8jg%40mail.gmail.com>
Precedence: bulk

--000000000000f2ffe306398f5577
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 9, 2025 at 4:02=E2=80=AFPM Alexandra Wang
<alexandra.wang.oss@gmail.com> wrote:
>
> Thanks again for the patch! It was really helpful! I didn't directly
> apply it as I made a few different choices, but I think I have
> addressed all the points you covered in it.
>
> Let me know your thoughts!
>

hi.

in v12-0001 and v12-0002.
in transformIndirection
        if (!newresult)
        {
            /*
             * generic subscripting failed; falling back to function call o=
r
             * field selection for a composite type.
             */
            Node       *n;
            /* try to find function for field selection */
            newresult =3D ParseFuncOrColumn(pstate,
                                          list_make1(n),
                                          list_make1(result),
                                          last_srf,
                                          NULL,
                                          false,
                                          location);
}
the above comments mentioning "function call" is wrong?
you passed NULL for (FuncCall *fn) in ParseFuncOrColumn.
and ParseFuncOrColumn comments says
```If fn is null, we're dealing with column syntax not function syntax.``


I think coerce_jsonpath_subscript can be further simplified.
we already have message like:
errhint("jsonb subscript must be coercible to either integer or text."),
no need to pass the third argument a constant (INT4OID).
also
``Oid            targetType =3D UNKNOWNOID;``
set it as InvalidOid would be better.
attached is a minor refactoring of coerce_jsonpath_subscript
based on (v12-0001 to v12-0004).


after applied v12-0001 to v12-0006
+ /* emit warning conditionally to minimize duplicate warnings */
+ if (list_length(*indirection) > 0)
+ ereport(WARNING,
+ errcode(ERRCODE_WARNING),
+ errmsg("mixed usage of jsonb simplified accessor syntax and jsonb
subscripting."),
+ errhint("use dot-notation for member access, or use non-null integer
constants subscripting for array access."),
+ parser_errposition(pstate, warning_location));

src7=3D# select ('{"a": 1, "b": "c", "d": [1, 2, 3]}'::jsonb).d['1'::int8];
WARNING:  mixed usage of jsonb simplified accessor syntax and jsonb
subscripting.
LINE 1: ...t ('{"a": 1, "b": "c", "d": [1, 2, 3]}'::jsonb).d['1'::int8]...
                                                             ^
HINT:  use dot-notation for member access, or use non-null integer
constants subscripting for array access.
ERROR:  subscript type bigint is not supported
LINE 1: ...t ('{"a": 1, "b": "c", "d": [1, 2, 3]}'::jsonb).d['1'::int8]...
                                                             ^
HINT:  jsonb subscript must be coercible to either integer or text.

The above example looks very bad. location printed twice, hint message
is different.
two messages level (ERROR, WARNING).

also "or use non-null integer constants subscripting for array
access." seems wrong?
as you can see the below hint message saying it could be text or integer.

select ('{"a": 1, "b": "c", "d": [1, 2, 3]}'::jsonb)['1'::int8];
ERROR:  subscript type bigint is not supported
LINE 1: ...ect ('{"a": 1, "b": "c", "d": [1, 2, 3]}'::jsonb)['1'::int8]...
                                                             ^
HINT:  jsonb subscript must be coercible to either integer or text.

also select ('{"a": 1, "b": "c", "d": [1, 2, 3]}'::jsonb)[NULL::int4];
return NULL,  so "use non-null integer constants" is wrong.

--000000000000f2ffe306398f5577
Content-Type: application/octet-stream;
	name="v12-0001-minor-refactor-coerce_jsonpath_subscript.no-cfbot"
Content-Disposition: attachment;
	filename="v12-0001-minor-refactor-coerce_jsonpath_subscript.no-cfbot"
Content-Transfer-Encoding: base64
Content-ID: <f_mcx5fxop0>
X-Attachment-Id: f_mcx5fxop0

RnJvbSA2ZmI0NmY5NzAzMGFkYzU5ZjdmOGQ1MzEzMjY0ZWYxYzZhOTViMDYyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBqaWFuIGhlIDxqaWFuLnVuaXZlcnNhbGl0eUBnbWFpbC5jb20+
CkRhdGU6IFRodSwgMTAgSnVsIDIwMjUgMTU6NDM6MTggKzA4MDAKU3ViamVjdDogW1BBVENIIHYx
MiAxLzFdIG1pbm9yIHJlZmFjdG9yIGNvZXJjZV9qc29ucGF0aF9zdWJzY3JpcHQKCi0tLQogc3Jj
L2JhY2tlbmQvdXRpbHMvYWR0L2pzb25ic3Vicy5jIHwgMTIgKysrKysrLS0tLS0tCiAxIGZpbGUg
Y2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3Ny
Yy9iYWNrZW5kL3V0aWxzL2FkdC9qc29uYnN1YnMuYyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9q
c29uYnN1YnMuYwppbmRleCA1ZDBlYzZiZjJmYS4uN2ExNGY1MDZjOTIgMTAwNjQ0Ci0tLSBhL3Ny
Yy9iYWNrZW5kL3V0aWxzL2FkdC9qc29uYnN1YnMuYworKysgYi9zcmMvYmFja2VuZC91dGlscy9h
ZHQvanNvbmJzdWJzLmMKQEAgLTMzLDE0ICszMywxNCBAQCB0eXBlZGVmIHN0cnVjdCBKc29uYlN1
YldvcmtzcGFjZQogfSBKc29uYlN1YldvcmtzcGFjZTsKIAogc3RhdGljIE5vZGUgKgotY29lcmNl
X2pzb25wYXRoX3N1YnNjcmlwdChQYXJzZVN0YXRlICpwc3RhdGUsIE5vZGUgKnN1YkV4cHIsIE9p
ZCBudW10eXBlKQorY29lcmNlX2pzb25wYXRoX3N1YnNjcmlwdChQYXJzZVN0YXRlICpwc3RhdGUs
IE5vZGUgKnN1YkV4cHIpCiB7CiAJT2lkCQkJc3ViRXhwclR5cGUgPSBleHByVHlwZShzdWJFeHBy
KTsKLQlPaWQJCQl0YXJnZXRUeXBlID0gVU5LTk9XTk9JRDsKKwlPaWQJCQl0YXJnZXRUeXBlID0g
SW52YWxpZE9pZDsKIAogCWlmIChzdWJFeHByVHlwZSAhPSBVTktOT1dOT0lEKQogCXsKLQkJT2lk
CQkJdGFyZ2V0c1syXSA9IHtudW10eXBlLCBURVhUT0lEfTsKKwkJT2lkCQkJdGFyZ2V0c1syXSA9
IHtJTlQ0T0lELCBURVhUT0lEfTsKIAogCQkvKgogCQkgKiBKc29uYiBjYW4gaGFuZGxlIG11bHRp
cGxlIHN1YnNjcmlwdCB0eXBlcywgYnV0IGNhc2VzIHdoZW4gYQpAQCAtNTYsNyArNTYsNyBAQCBj
b2VyY2VfanNvbnBhdGhfc3Vic2NyaXB0KFBhcnNlU3RhdGUgKnBzdGF0ZSwgTm9kZSAqc3ViRXhw
ciwgT2lkIG51bXR5cGUpCiAJCQkJICogT25lIHR5cGUgaGFzIGFscmVhZHkgc3VjY2VlZGVkLCBp
dCBtZWFucyB0aGVyZSBhcmUgdHdvCiAJCQkJICogY29lcmNpb24gdGFyZ2V0cyBwb3NzaWJsZSwg
ZmFpbHVyZS4KIAkJCQkgKi8KLQkJCQlpZiAodGFyZ2V0VHlwZSAhPSBVTktOT1dOT0lEKQorCQkJ
CWlmIChPaWRJc1ZhbGlkKHRhcmdldFR5cGUpKQogCQkJCQllcmVwb3J0KEVSUk9SLAogCQkJCQkJ
CShlcnJjb2RlKEVSUkNPREVfREFUQVRZUEVfTUlTTUFUQ0gpLAogCQkJCQkJCSBlcnJtc2coInN1
YnNjcmlwdCB0eXBlICVzIGlzIG5vdCBzdXBwb3J0ZWQiLCBmb3JtYXRfdHlwZV9iZShzdWJFeHBy
VHlwZSkpLApAQCAtNzAsNyArNzAsNyBAQCBjb2VyY2VfanNvbnBhdGhfc3Vic2NyaXB0KFBhcnNl
U3RhdGUgKnBzdGF0ZSwgTm9kZSAqc3ViRXhwciwgT2lkIG51bXR5cGUpCiAJCS8qCiAJCSAqIE5v
IHN1aXRhYmxlIHR5cGVzIHdlcmUgZm91bmQsIGZhaWx1cmUuCiAJCSAqLwotCQlpZiAodGFyZ2V0
VHlwZSA9PSBVTktOT1dOT0lEKQorCQlpZiAoIU9pZElzVmFsaWQodGFyZ2V0VHlwZSkpCiAJCQll
cmVwb3J0KEVSUk9SLAogCQkJCQkoZXJyY29kZShFUlJDT0RFX0RBVEFUWVBFX01JU01BVENIKSwK
IAkJCQkJIGVycm1zZygic3Vic2NyaXB0IHR5cGUgJXMgaXMgbm90IHN1cHBvcnRlZCIsIGZvcm1h
dF90eXBlX2JlKHN1YkV4cHJUeXBlKSksCkBAIC0xMzksNyArMTM5LDcgQEAganNvbmJfc3Vic2Ny
aXB0X3RyYW5zZm9ybShTdWJzY3JpcHRpbmdSZWYgKnNic3JlZiwKIAkJaWYgKGFpLT51aWR4KQog
CQl7CiAJCQlzdWJFeHByID0gdHJhbnNmb3JtRXhwcihwc3RhdGUsIGFpLT51aWR4LCBwc3RhdGUt
PnBfZXhwcl9raW5kKTsKLQkJCXN1YkV4cHIgPSBjb2VyY2VfanNvbnBhdGhfc3Vic2NyaXB0KHBz
dGF0ZSwgc3ViRXhwciwgSU5UNE9JRCk7CisJCQlzdWJFeHByID0gY29lcmNlX2pzb25wYXRoX3N1
YnNjcmlwdChwc3RhdGUsIHN1YkV4cHIpOwogCQl9CiAJCWVsc2UKIAkJewotLSAKMi4zNC4xCgo=
--000000000000f2ffe306398f5577--