MIME-Version: 1.0
References: <CA+renyUApHgSZF9-nd-a0+OPGharLQLO=mDHcY4_qQ0+noCUVg@mail.gmail.com>
 <CA+renyV4RxkWx57Vi5k_k0d7mkT7+F2kHYuKkwNPBaSOCaotFA@mail.gmail.com>
 <CACJufxG7DKLhyJgBaFttdXZe-4dOVu3NVED+4sdegdGs6R7JdQ@mail.gmail.com>
 <CACJufxFxQH5NxD9UDvbcRCPtaSga+y0+Wwt54PA4KahLwhahOA@mail.gmail.com>
 <5157e85a-6007-27a7-853a-5601d9c3722f@illuminatedcomputing.com>
 <CACJufxGCWDSK2pYMwNdsyDGk6skbP_L5yvSBK67L6pxbGUF8OQ@mail.gmail.com>
 <5a16a59a-d497-7d72-07aa-0afc09d5193a@illuminatedcomputing.com>
 <CACJufxG_iZc8hbdcfjkU6q81kLf4R2Fp=VyDZbyhocuTbMNVEw@mail.gmail.com>
 <b8ef855d-216b-5499-6a6e-ec883a32bd96@illuminatedcomputing.com>
 <CACJufxGnN6-513copYkpgJia6Qq7vKtO6q7cigUpA=4Evozppg@mail.gmail.com>
 <CACJufxGsjGXbKT-qbPYtspLxN74B8Q8dBXRZV+HfgqC0hh-ZNQ@mail.gmail.com>
 <CACJufxGt4oYfa7UN2eAXymgOKH1irbhC5eY_oNkkdj30w-fefw@mail.gmail.com>
 <CACJufxExyO_mN8-OkgaTdgqmE5OfE=RBoQXizf=8uRj4c-pAYw@mail.gmail.com>
 <CACJufxGeUsmxOhnd2760kBv-hUWRwCy7A0s45pGSPTe8DJVTGw@mail.gmail.com> <2d9740ad-3bb7-473c-8441-344351caa8ee@illuminatedcomputing.com>
In-Reply-To: <2d9740ad-3bb7-473c-8441-344351caa8ee@illuminatedcomputing.com>
From: jian he <jian.universality@gmail.com>
Date: Tue, 7 Nov 2023 15:07:15 +0800
Message-ID: <CACJufxHuuUBq8jDaZgcyUtpb1xaQ_WVX5dLXsGFGtUf9tsPRag@mail.gmail.com>
Subject: Re: SQL:2011 application time
To: Paul Jungwirth <pj@illuminatedcomputing.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, 
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CACJufxHuuUBq8jDaZgcyUtpb1xaQ_WVX5dLXsGFGtUf9tsPRag%40mail.gmail.com>
Precedence: bulk

hi. based on v17. I found several doc related issues. previously I
didn't look closely....

+         </para>
+          In a temporal foreign key, the delete/update will use
+          <literal>FOR PORTION OF</literal> semantics to constrain the
+          effect to the bounds being deleted/updated in the referenced row.
+         </para>

The first "para" should be <para> ?
---
There are many warnings after #define WRITE_READ_PARSE_PLAN_TREES
see: http://cfbot.cputube.org/highlights/all.html#4308
Does that mean oue new change in gram.y is somehow wrong?
------
sgml/html/sql-update.html:
"range_or_period_name
The range column or period to use when performing a temporal update.
This must match the range or period used in the table's temporal
primary key."

Is the second sentence unnecessary? since no primary can still do "for
portion of update".

sgml/html/sql-update.html:
"start_time
The earliest time (inclusive) to change in a temporal update. This
must be a value matching the base type of the range or period from
range_or_period_name. It may also be the special value MINVALUE to
indicate an update whose beginning is unbounded."

probably something like the following:
"lower_bound"
The lower bound (inclusive) to change in an overlap update. This must
be a value matching the base type of the range or period from
range_or_period_name. It may also be the special value UNBOUNDED to
indicate an update whose beginning is unbounded."

Obviously the "start_time" reference also needs to change, and the
sql-delete.html reference also needs to change.
----------------------------------
UPDATE for_portion_of_test FOR PORTION OF valid_at  FROM NULL TO
"unbounded" SET name = 'NULL to NULL';
should fail, but not. double quoted unbounded is a column reference, I assume.

That's why I am confused with the function transformForPortionOfBound.
"if (nodeTag(n) == T_ColumnRef)" part.
-----------------------------------
in create_table.sgml. you also need to add  WITHOUT OVERLAPS related
info into <varlistentry id="sql-createtable-parms-unique">