MIME-Version: 1.0
References: <1cee81f3-312f-30e3-0282-c4df7ee72f93@xs4all.nl>
 <202403041503.5momp6knupgo@alvherre.pgsql> <CA+HiwqGtdVCg-KboUUU=svwukwXGT4EOFOk3eCZLz6h-d6YLNw@mail.gmail.com>
 <1e0e5800-965e-42ed-8caa-362294604243@enterprisedb.com> <CA+HiwqGYkYjXe2g0=c==BGSpVQfMJZBhPE-vesX3xCz4enBYPg@mail.gmail.com>
 <CACJufxH7Dc6Uo73_Ne+=+C_9a8-DZiExRo72gGe7u2CQV6BnFQ@mail.gmail.com> <CACJufxFf3xQhMeUujViWK=77hCJ-NiESjTdYyZ10ysd7gckcSQ@mail.gmail.com>
In-Reply-To: <CACJufxFf3xQhMeUujViWK=77hCJ-NiESjTdYyZ10ysd7gckcSQ@mail.gmail.com>
From: jian he <jian.universality@gmail.com>
Date: Thu, 7 Mar 2024 13:16:49 +0800
Message-ID: <CACJufxHwNWRNJG26HdgrFNo4M5bd=2-36qpy_bYE-JrCrJmaHQ@mail.gmail.com>
Subject: Re: remaining sql/json patches
To: Amit Langote <amitlangote09@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Erik Rijkers <er@xs4all.nl>, Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>, 
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://www.postgresql.org/message-id/CACJufxHwNWRNJG26HdgrFNo4M5bd%3D2-36qpy_bYE-JrCrJmaHQ%40mail.gmail.com>
Precedence: bulk

two cosmetic minor issues.

+/*
+ * JsonCoercion
+ * Information about coercing a SQL/JSON value to the specified
+ * type at runtime
+ *
+ * A node of this type is created if the parser cannot find a cast expression
+ * using coerce_type() or OMIT QUOTES is specified for JSON_QUERY.  If the
+ * latter, 'expr' may contain the cast expression; if not, the quote-stripped
+ * scalar string will be coerced by calling the target type's input function.
+ * See ExecEvalJsonCoercion.
+ */
+typedef struct JsonCoercion
+{
+ NodeTag type;
+
+ Oid targettype;
+ int32 targettypmod;
+ bool omit_quotes; /* OMIT QUOTES specified for JSON_QUERY? */
+ Node   *cast_expr; /* coercion cast expression or NULL */
+ Oid collation;
+} JsonCoercion;

comment:  'expr' may contain the cast expression;
here "exr" should be "cast_expr"?
"a SQL/JSON" should be " an SQL/JSON"?