Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFdUh-00B5cT-De for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 17:02:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFdUf-003YZd-Pv for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 17:02:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFdUf-003YZV-G6 for pgsql-hackers@lists.postgresql.org; Tue, 19 Dec 2023 17:02:57 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rFdUc-00BCVz-Sv for pgsql-hackers@lists.postgresql.org; Tue, 19 Dec 2023 17:02:56 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50e24e92432so4572136e87.2 for ; Tue, 19 Dec 2023 09:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=instructure.com; s=google; t=1703005373; x=1703610173; darn=lists.postgresql.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=mxZH0B2jg/WAxC0+9ZhqCHpehUXxvIUjn4L6SjB/6tA=; b=ikQ6dtSHKkaMZ98Njpi9ZnK2B9XFty3SXEDMga76in1BOLtkEe3jpYMBfWAlvOhrLE VPSQuwbBUnSJvmTaBTd2QI961T2VlXa+o0o5HzbWC3w/AugKgNcV6aGCAlfkgli2znk8 myPx4Fb5uJ4fXWXoAlgUqqJwck6ROPbMUfVvM9RRuuZc6LaxHNBqMDi7mBWmZic4lOOh X/49AiATmznA8rrnj5BKPF2Pv8/YB0FZne6GPvlee4a/8OTU5r3GROl1CeyWwOZKtw+V foh4ScIT1Q+8OmdoFrU9W5UZFovjiKgtBIWpWp0WwuE2hRCRU9XDDWtWb0W7DbNC79dH NlCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703005373; x=1703610173; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mxZH0B2jg/WAxC0+9ZhqCHpehUXxvIUjn4L6SjB/6tA=; b=WqHM22d3BQ8CZUVbOE0pW7Tl/w6s/+/s4Z3jeIuYp2kzejAL+KeeC8IJRpGDEmcci0 ZxlAW1XHPBlmCUPLzCvAXaDr9TAYUSCEBN51I6PMMbRbXXoqFrzKme1ShUcn/yAiJjn5 uP4QHYgDEEYWQvBNmkkOA5YHhYTkMK9Po8Wbp/11QNmoSnwdBrHRtUotnNAZ4HtkcizH 8eoWSlxmEPROLreHKI/5ASAvdOJhICusH/5SxYGbZ4s+Cf8VdAvFT6LzKJX82+53vxRr VTgBFrC81843Ac03i7Zq/49uhRK+7jIASRo8GYXFxB6CFreojNWPlz1oPxwainBxGcOS y9VA== X-Gm-Message-State: AOJu0Yw0ZC7iEJvk3jLY2IcCVF0RuTerL8woGY9l5SDkCccwUN3J8Agy 2cESVD5z9D4TaZM14gJJbk9qoznsxZm3sAgDcjGoSYsUsRXIrBULHaY= X-Google-Smtp-Source: AGHT+IENxvr311QU1czapP12umEXeSf1XMeVVBgoKeg/Il3L+8Yh6i5/bp1fLoYxiArbWAg9ZE2n5uEQwbwabMpNo84= X-Received: by 2002:ac2:4251:0:b0:50e:1b4e:cbdd with SMTP id m17-20020ac24251000000b0050e1b4ecbddmr3381072lfl.114.1703005372830; Tue, 19 Dec 2023 09:02:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jacob Burroughs Date: Tue, 19 Dec 2023 11:02:41 -0600 Message-ID: Subject: Re: libpq compression (part 3) To: pgsql-hackers@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > I believe this patch series is ready for detailed review/testing, with one caveat: as can be seen here https://cirrus-ci.com/build/6732518292979712 , the build is passing on all platforms and all tests except for the primary SSL test on Windows. One correction: I apparently missed a kerberos timeout failure on freebsd with compression enabled (being color blind the checkmark and still running colors are awfully similar, and I misread what I saw). I haven't yet successfully reproduced that one, so I may or may not need some pointers to sort it out, but I think whatever it is the fix will be small enough that the patch overall is still reviewable.