Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vhhEA-004Pqc-2N for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Jan 2026 04:50:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vhhE8-00BZyl-1H for pgsql-hackers@arkaria.postgresql.org; Mon, 19 Jan 2026 04:50:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vhhE7-00BZyd-2z for pgsql-hackers@lists.postgresql.org; Mon, 19 Jan 2026 04:50:56 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vhhE5-001BJX-1Z for pgsql-hackers@lists.postgresql.org; Mon, 19 Jan 2026 04:50:55 +0000 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-43277900fb4so2190258f8f.1 for ; Sun, 18 Jan 2026 20:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768798253; x=1769403053; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=43UY/9IaKC8L297yGUO6+GUvAO760+B/kG/9Ok+mwwY=; b=bmHaz842IWoYo5/ZWLtotc636E+QdV1ssVZY5tLYIfIeBAUj5ysSs54sMFVA6geyp7 2ZnvwMjIJPH0LQ4gFrVM4lobft90olW64Pg6iTdNucyW3uPnWiNcAdkU6PH1qnYlKmjf FhWJV9QyD2y5Rw6jMLPBjwtrZn3i08IuWD3UqKqE/flvt7qiWsDy8f7G5b9ncSk6zNx3 qAWP5zg/G6K4MtooC8oxKoO0d9wfzTmPs1KOXQTIfohX2gdkIXL1DdrO/pBmGRBdv5mC y1bGFk3xwqhERxQiH/zCug7Bm+k/Ld9o/2290325y23WRddpK9ZElq4ba7tO4sDr+1S6 yjFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768798253; x=1769403053; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=43UY/9IaKC8L297yGUO6+GUvAO760+B/kG/9Ok+mwwY=; b=wzI4sInBGZq/9s7n9O2qk3oy5dW/qkSm1+1KADOpA2hgYeeBgtGSEk5emIiIGRjfmA gHB/CjqHfmRHvUXwbSjnnH7loyNSR3dR8b6fSEWbJw6j8acYqS7x6Tu6B/jVsOI2L0FH omNM1bYeZ+vbzn+9oc+mqyY95ap0ATRjQwcIPtsGDYV2XNKynFYQoRoGjS87JJZ42oL7 XlILVqSlFdJtWc5WzXPd6Sa6Ny8jAUSpBAem5C8I33QImsRNC2kNkhboGahnjnlXHHEW 2oZsf4IXTsLrWlAvDMQ81R4p73QYruzQw4f9hIPzcgGdb9hWVx2jSmFXOCKBEerQ84nO RLyA== X-Gm-Message-State: AOJu0YwpodHdjFPBLg3xV+C3bf8yI72dVA9eJmhKu8Dj6DwfP56t6XAO mJ1UnileYiHP+Q67IRvNx9Lx9dfqw8tre41yDiIsGRUhsCbV1bVwF9m/6NZ5zK9SQdn+vRx6f5W IU8IyoaubP7k04nlBW1oJqCuDO7fWCjo= X-Gm-Gg: AY/fxX4paY9GSBX9dOkpP/0e+eGZhoiNh8DkEFAArod97pBFXCuIB+D8Axs75qPKK2i HXpTKG9sQ+crJaekYQxkMsWThKZUctY4cfnnwYP6a+vz/xFyh+59OBEVv6tfK/TR1AGf8iahlcS b/Bvbvc5k9L7F6pIR/tlAoFZDpGl69XbWsTT54bvE3JY99VYYdb1tNZXoGlxAr2DW7CSbV17+n6 r8S7IuXiwB8oWDaZ8Onk15ULcmr+3d27a0zTDrvu41ybhexGFpLwjA8GKe4Y9CRMsFBUq837xrF mJ4fPIjK8lOXTC/NIZQF37Xnvw== X-Received: by 2002:a05:6000:4312:b0:430:f593:aa34 with SMTP id ffacd0b85a97d-434d75c15a7mr19866518f8f.17.1768798252598; Sun, 18 Jan 2026 20:50:52 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Gollamudi Date: Sun, 18 Jan 2026 20:50:41 -0800 X-Gm-Features: AZwV_Qg8vqKtYpu0LX_kWmA8psxuRCUZE8aZ2rXSbhafuxCnTmDUyaU5DsB93r4 Message-ID: Subject: Re: Minor refactor of the code in ExecScanExtended() To: cca5507 Cc: pgsql-hackers Content-Type: multipart/alternative; boundary="0000000000008689500648b66fb5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000008689500648b66fb5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jan 18, 2026 at 7:31=E2=80=AFPM cca5507 wrote: > Hi, > > The current code: > > if (!qual && !projInfo) > { > ResetExprContext(econtext); > return ExecScanFetch(node, epqstate, accessMtd, recheckMtd); > } > > ResetExprContext(econtext); > > The following format might be simpler: > > ResetExprContext(econtext); > > if (!qual && !projInfo) > return ExecScanFetch(node, epqstate, accessMtd, recheckMtd); > > Attach a patch to do this. > > -- > Regards, > ChangAo Chen > > Hi, +1, seems like a simple refactor. Tests are passing locally for me! - Adi Gollamudi --0000000000008689500648b66fb5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Jan 18, 2026 at 7:31=E2=80=AFPM c= ca5507 <cca5507@qq.com> wrote:<= /div>
Hi,

The current code:

=E2=80=82=E2=80= =82=E2=80=82=E2=80=82=E2=80=82=E2=80=82if (!qual && !projInfo)
=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82{
=E2=80=82=E2=80=82=E2=80=82=E2=80=82= =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82Res= etExprContext(econtext);
=E2=80=82=E2=80=82= =E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82=E2=80=82return ExecScanFetch(node, epqstate, accessMtd, recheckMtd);=
=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80= =82=E2=80=82}

=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82ResetExprContext(= econtext);

The following format might be simpler:

<= /div>
=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82= =E2=80=82ResetExprContext(econtext);

=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2= =80=82if (!qual && !projInfo)
=E2=80= =82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82=E2=80=82= =E2=80=82=E2=80=82=E2=80=82return ExecScanFetch(node, epqstate, accessMtd, = recheckMtd);

Attach a patch to do this.

--
Regards,
ChangAo Chen

Hi,=C2=A0

+1, seems like a simple ref= actor.=C2=A0
Tests are passing locally for me!

- Adi Gollamudi=C2=A0
--0000000000008689500648b66fb5--