Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vjm6J-004FaK-1K for pgsql-hackers@arkaria.postgresql.org; Sat, 24 Jan 2026 22:27:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vjm6G-003dBV-1I for pgsql-hackers@arkaria.postgresql.org; Sat, 24 Jan 2026 22:27:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vjm6G-003dBM-0K for pgsql-hackers@lists.postgresql.org; Sat, 24 Jan 2026 22:27:24 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1vjm6D-0028Rs-2L for pgsql-hackers@postgresql.org; Sat, 24 Jan 2026 22:27:23 +0000 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-435a517be33so2005328f8f.0 for ; Sat, 24 Jan 2026 14:27:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769293636; cv=none; d=google.com; s=arc-20240605; b=DoniUjHsGzZR+xzbQIrmtF3oRX3rRNnzXcfklGxCM2cd83F9VXkTbApIfRJkmXNbBw Am5DpAHe45jrsP4IU4qq4vlzcMUi1xz/LxeyVFQ0Gig3uFToy0z5GtaYqC/s6ZcpjQla eitUWzUjvff4A+BeRIgn9VlK+KViZ4334o5cgv4DjMaVDK7j4kL2VmKRpJhqeIYyWoSg uf0HPmkrVfxh8lpftauttSdFkwm/IOrpVk67K39ZvSGZ5gmXFCc3RS5Dj+WT9ssiS3LK /FzGLEFBNWDVJSxZ/FPOSnGwnK/r2p5u+3OUH5nZ5JQ24kxCXM8EcfmaJdLTBaYEkkxU ii5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature; bh=iyBa1aq06pDQLGIha72nrpDk9APcSF5PdF1OAKcuhOc=; fh=q4zplcgEPnUZ6BQVnKTG1XqOMRY2cGcfndKkxPQ+j4o=; b=bUPjKLSXMG7mdL1hUOqQ8J09E/m3T5tJxWZgxic5ttnby46qfVKM8OLkVLJ8jlNnhe 3yagnkTEkuV6UeFM1r7ODlGk5pycll/A//7xDneZaJWJ7UZOK6Tm4IwQHpOeYwlQ4S2/ 81VkHDGAGNEwposM0UbKoO4AVr2UUnKBClA9Gd9TDbOEs5v4q6BJsaUlwsOLora/J1/C yhHXzJ8S/zRXOOxKHOzDJVSE3yzLYB7DGyvtljYmW6YwbwSg1K/fzVADc8jURMM9nTZd ItgwfCDdvqco/9EkFCuUL2XVyTLu2uNGvBIMsLa5ge5kxrXGlJTOs8mWBZ4nHdpIcfXd dmEw==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769293636; x=1769898436; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iyBa1aq06pDQLGIha72nrpDk9APcSF5PdF1OAKcuhOc=; b=e1dKGrTxNkkm3qGT7FfbiEDJ0Gb8fFm6jVp2WOAUp4dpP2bPZsrJYsuYawiLzBnpCZ JyXgdM0qCrdiXCIzR72QLd5a4YvzN2ZXOmSiAUQe3NZfW5YEB5qroUGh7flG1tpxxHiW G62GTGx9Exn4i6W7zRNGvO1Y7viXY5v1txgoJC9QroXxjc0JBT0N6yUB+fkNBDHOnT9T O5FTrbjonjjVMXU2xutNxZuyrbCLWCMDydGJ2rf9WvWUQzV9bPZirFJdHWJSmRPueZcp YWgYHb7mP5MonJlZQd4RyPxqv9lv3cdb85NHw7vdJgWRHLaNXyUfCXwPyp3buT75Hvey YMlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769293636; x=1769898436; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iyBa1aq06pDQLGIha72nrpDk9APcSF5PdF1OAKcuhOc=; b=XPeXmovB9UiFb8rh9RDq/HT+oWfzbQJU3DuEyrTD8oHNVI6f4tGgrTuN94UCRz8x3b /pLQxMYw64uDhxstw7NZMD61qsL1MOZ5wg9jLueLv+yZ4PKkLgy2pi8nr8WU7UqvKh1k yI9AuzM8UeG+N39nuvkV17DqriIPxpusuW9H1catGgQm3rP42Tn/oX/F/8OKKd+4Ex55 U5KTLwMGnRcBZE8u4xVuBwHM7c//3iuoilsT4RzEnei8gvmS2v3d8E7FHZYXQqMvqvS4 jBp+0Wdyo/5am4s4K/uzVVw0JRJGxRB6ncH8Xkyp5CdggPd9DmuMe7ztVXH5UoolBcYo qyDQ== X-Gm-Message-State: AOJu0YzbIeGfDuDgUaoWpVoWaL0GIO4Kxy9LSmKz4mHp8HctjsOJxAhi 3ioGgjnohkRCY0luHqcEU0vcre1eHIvplskxNUab5aT4+bCCcGx4Bebulnv/LZrECbjDIE6xfJH WC9U9DfFhVyKZoN6ByzU14JO15m83xJI6PA== X-Gm-Gg: AZuq6aJGP7BZWm8Vl9eZSV7Zu5oxJsgwifu9gbEM3s1uVmpZvaNzgB4Q7ihKd+cdGAj QuLoumCFnb0qzd02kUgXzRd2Sqm4xgARejiDm/20AafGrv4EPVGKb3xjjWKypK1LzWEHVzyJAx7 DkVUIiVdwu1jji1frYRScXsx0fb8pPVSj55M4NyuJFJd2KNuVt+J1JZ/DzNshzWRIp9t62qw2su nuEQIoX9/4uShW5WxK6f4Z18o99YIQ62KF9kwhBZa/Xvs3DzkIN3zaID0MpWbFOR4kkt3WE4Q== X-Received: by 2002:a05:6000:250a:b0:430:fd84:317a with SMTP id ffacd0b85a97d-435b1604eeemr13051642f8f.38.1769293635769; Sat, 24 Jan 2026 14:27:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Gollamudi Date: Sat, 24 Jan 2026 14:27:04 -0800 X-Gm-Features: AZwV_Qh2bJZOmXiH9mU8sctgfyl4qgXB9K2rWcfmVBsuQXR1FY5yfKGTUPZcHXc Message-ID: Subject: Re: [PATCH] Refactor *_abbrev_convert() functions To: Aleksander Alekseev Cc: PostgreSQL Development Content-Type: multipart/alternative; boundary="000000000000a9d8e4064929c677" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000a9d8e4064929c677 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2026 at 4:34=E2=80=AFAM Aleksander Alekseev < aleksander@tigerdata.com> wrote: > Hi, > > Now when all Datums are 64-bit values we can simplify the code by > using murmurhash64(). This refactoring was previously suggested by > John Naylor [1]. > > [1]: > https://postgr.es/m/CANWCAZbMyrijdR0xc-4SqpNJBHMEwRZccBK4fa0aquNpq2Uj7w%4= 0mail.gmail.com > > -- > Best regards, > Aleksander Alekseev > Hi, I reviewed this change and the surrounding code and this seems good! All tests pass locally for me. Hopefully this gets picked up soon. Regards, Adi Gollamudi --000000000000a9d8e4064929c677 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jan 13, 2026 at 4:34=E2=80=AFAM A= leksander Alekseev <aleksand= er@tigerdata.com> wrote:
Hi,

Now when all Datums are 64-bit values we can simplify the code by
using murmurhash64(). This refactoring was previously suggested by
John Naylor [1].

[1]: https:/= /postgr.es/m/CANWCAZbMyrijdR0xc-4SqpNJBHMEwRZccBK4fa0aquNpq2Uj7w%40mail.gma= il.com

--
Best regards,
Aleksander Alekseev

Hi,=C2=A0

I reviewed this change and the surrounding code and this se= ems good!
All tests pass locally for me. Hopefully this gets pick= ed up soon.

Regards,=C2=A0
Adi Gollamudi=
--000000000000a9d8e4064929c677--