MIME-Version: 1.0
References: 
 <CAD-rTHmBR8SW-p7Nc97HT-CEGr85WihdeTsrnLEiRGeK19nWAw@mail.gmail.com>
In-Reply-To: 
 <CAD-rTHmBR8SW-p7Nc97HT-CEGr85WihdeTsrnLEiRGeK19nWAw@mail.gmail.com>
From: Xianbin Zhu <xianbin.aaronzhu@gmail.com>
Date: Sun, 29 Mar 2026 15:05:11 +0800
Message-ID: 
 <CAD-rTHmcFSsG8N14G8BZeGSgY94v=N0NC-CHfnZegfYzEYnNQw@mail.gmail.com>
Subject: [PATCH v1] psql: complete ALTER ROLE ... IN DATABASE ... RESET
To: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000aa42f8064e245bc5"
Archived-At: 
 <https://www.postgresql.org/message-id/CAD-rTHmcFSsG8N14G8BZeGSgY94v%3DN0NC-CHfnZegfYzEYnNQw%40mail.gmail.com>
Precedence: bulk

--000000000000aa42f8064e245bc5
Content-Type: multipart/alternative; boundary="000000000000aa42f7064e245bc3"

--000000000000aa42f7064e245bc3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi hackers,

As discussed, here's a patch to add psql tab-completion support for:

ALTER ROLE/USER <name> IN DATABASE <db> RESET ...

Changes:
- Add completion path for "... IN DATABASE <db> RESET"
- Offer GUC names and ALL after RESET
- Add tab-completion test coverage in src/bin/psql/t/010_tab_completion.pl

Testing:
- make -j8
- make check (all tests passed in my environment)

Patch attached.

Thanks,
xianbinzhu

On Sun, Mar 29, 2026 at 2:50=E2=80=AFPM Xianbin Zhu <xianbin.aaronzhu@gmail=
.com>
wrote:

> Hi hackers,
>
> I'd like to work on a small psql tab-completion improvement.
>
> Problem:
> psql currently has a missing completion path for:
> ALTER ROLE <role> IN DATABASE <db> RESET ...
>
> There is an in-code TODO marker for this case in
> src/bin/psql/tab-complete.in.c.
>
> Proposal:
> - Add completion support after "... IN DATABASE <db> RESET"
> - Reuse existing completion behavior/style used by ALTER ROLE ... RESET
> - Add regression coverage in src/bin/psql/t/010_tab_completion.pl
>
> Non-goals:
> - No backend behavior changes
> - No SQL grammar changes
>
> If this direction looks good, I can send a patch.
>
> Thanks,
> xianbinzhu
>

--000000000000aa42f7064e245bc3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi hackers,<br><br>As discussed, here&#39=
;s a patch to add psql tab-completion support for:<br><br>ALTER ROLE/USER &=
lt;name&gt; IN DATABASE &lt;db&gt; RESET ...<br><br>Changes:<br>- Add compl=
etion path for &quot;... IN DATABASE &lt;db&gt; RESET&quot;<br>- Offer GUC =
names and ALL after RESET<br>- Add tab-completion test coverage in src/bin/=
psql/t/<a href=3D"http://010_tab_completion.pl">010_tab_completion.pl</a><b=
r><br>Testing:<br>- make -j8<br>- make check (all tests passed in my enviro=
nment)<br><br>Patch attached.<br><br>Thanks,<br>xianbinzhu</div><br><div cl=
ass=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_a=
ttr">On Sun, Mar 29, 2026 at 2:50=E2=80=AFPM Xianbin Zhu &lt;<a href=3D"mai=
lto:xianbin.aaronzhu@gmail.com">xianbin.aaronzhu@gmail.com</a>&gt; wrote:<b=
r></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex=
;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">=
Hi hackers,<br><br>I&#39;d like to work on a small psql tab-completion impr=
ovement.<br><br>Problem:<br>psql currently has a missing completion path fo=
r:<br>ALTER ROLE &lt;role&gt; IN DATABASE &lt;db&gt; RESET ...<br><br>There=
 is an in-code TODO marker for this case in src/bin/psql/tab-complete.in.c.=
<br><br>Proposal:<br>- Add completion support after &quot;... IN DATABASE &=
lt;db&gt; RESET&quot;<br>- Reuse existing completion behavior/style used by=
 ALTER ROLE ... RESET<br>- Add regression coverage in src/bin/psql/t/<a hre=
f=3D"http://010_tab_completion.pl" target=3D"_blank">010_tab_completion.pl<=
/a><br><br>Non-goals:<br>- No backend behavior changes<br>- No SQL grammar =
changes<br><br>If this direction looks good, I can send a patch.<br><br>Tha=
nks,<br>xianbinzhu</div>
</blockquote></div></div>

--000000000000aa42f7064e245bc3--

--000000000000aa42f8064e245bc5
Content-Type: application/octet-stream;
	name="0001-psql-complete-ALTER-ROLE-.-IN-DATABASE-.-RESET.patch"
Content-Disposition: attachment;
	filename="0001-psql-complete-ALTER-ROLE-.-IN-DATABASE-.-RESET.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnbexbqm0>
X-Attachment-Id: f_mnbexbqm0

RnJvbSA2YjgwNjY4NzgzZGNhNDE1OTMyYjFkODY3NGM5ZTVmYTdjNmEzNTQ3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiB4aWFuYmluemh1IDx4aWFuYmluLmFhcm9uemh1QGdtYWlsLmNv
bT4KRGF0ZTogU3VuLCAyOSBNYXIgMjAyNiAxNDo1NTo0OCArMDgwMApTdWJqZWN0OiBbUEFUQ0hd
IHBzcWw6IGNvbXBsZXRlIEFMVEVSIFJPTEUgLi4uIElOIERBVEFCQVNFIC4uLiBSRVNFVAoKU2ln
bmVkLW9mZi1ieTogeGlhbmJpbnpodSA8eGlhbmJpbi5hYXJvbnpodUBnbWFpbC5jb20+Ci0tLQog
c3JjL2Jpbi9wc3FsL3QvMDEwX3RhYl9jb21wbGV0aW9uLnBsIHwgMTIgKysrKysrKysrKysrCiBz
cmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmluLmMgICAgICAgfCAgNCArKystCiAyIGZpbGVzIGNo
YW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMv
YmluL3BzcWwvdC8wMTBfdGFiX2NvbXBsZXRpb24ucGwgYi9zcmMvYmluL3BzcWwvdC8wMTBfdGFi
X2NvbXBsZXRpb24ucGwKaW5kZXggMWQyZTVmNWI5MmEuLjVlN2I5NTZhMDEyIDEwMDY0NAotLS0g
YS9zcmMvYmluL3BzcWwvdC8wMTBfdGFiX2NvbXBsZXRpb24ucGwKKysrIGIvc3JjL2Jpbi9wc3Fs
L3QvMDEwX3RhYl9jb21wbGV0aW9uLnBsCkBAIC00NCw2ICs0NCw3IEBAICRub2RlLT5zYWZlX3Bz
cWwoJ3Bvc3RncmVzJywKIAkgIC4gIkNSRUFURSBUQUJMRSBteXRhYjI0NiAoZjEgaW50LCBmMiB0
ZXh0KTtcbiIKIAkgIC4gIkNSRUFURSBUQUJMRSBcIm1peGVkTmFtZVwiIChmMSBpbnQsIGYyIHRl
eHQpO1xuIgogCSAgLiAiQ1JFQVRFIFRZUEUgZW51bTEgQVMgRU5VTSAoJ2ZvbycsICdiYXInLCAn
YmF6JywgJ0JMQUNLJyk7XG4iCisJICAuICJDUkVBVEUgUk9MRSB0YWJjb21wX3JvbGU7XG4iCiAJ
ICAuICJDUkVBVEUgUFVCTElDQVRJT04gc29tZV9wdWJsaWNhdGlvbjtcbiIpOwogCiAjIEluIGEg
VlBBVEggYnVpbGQsIHdlJ2xsIGJlIHN0YXJ0ZWQgaW4gdGhlIHNvdXJjZSBkaXJlY3RvcnksIGJ1
dCB3ZSB3YW50CkBAIC0yMjgsNiArMjI5LDE3IEBAIGNoZWNrX2NvbXBsZXRpb24oCiAKIGNsZWFy
X3F1ZXJ5KCk7CiAKK2NoZWNrX2NvbXBsZXRpb24oCisJIkFMVEVSIFJPTEUgdGFiY29tcF9yb2xl
IElOIERBVEFCQVNFIHBvc3RcdCIsCisJcXIvcG9zdGdyZXMgLywKKwkiY29tcGxldGUgZGF0YWJh
c2UgbmFtZSBmb3IgQUxURVIgUk9MRSAuLi4gSU4gREFUQUJBU0UiKTsKK2NoZWNrX2NvbXBsZXRp
b24oCisJIlJFU0VUIGNsaWVcdCIsCisJcXIvY2xpZW50X2VuY29kaW5nIC8sCisJImNvbXBsZXRl
IEdVQyBmb3IgQUxURVIgUk9MRSAuLi4gSU4gREFUQUJBU0UgLi4uIFJFU0VUIik7CisKK2NsZWFy
X3F1ZXJ5KCk7CisKICMgY2hlY2sgdmFyaWFudCB3aGVyZSB3ZSdyZSBjb21wbGV0aW5nIGEgcXVh
bGlmaWVkIG5hbWUgZnJvbSBhIHJlZm5hbWUKICMgKHRoaXMgb25lIGFsc28gY2hlY2tzIHN1Y2Nl
c3NmdWwgY29tcGxldGlvbiBpbiBhIG11bHRpbGluZSBjb21tYW5kKQogY2hlY2tfY29tcGxldGlv
bigKZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYyBiL3NyYy9iaW4v
cHNxbC90YWItY29tcGxldGUuaW4uYwppbmRleCA1MjNkM2YzOWZjNS4uMzM3MjhlZGE1NWMgMTAw
NjQ0Ci0tLSBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuaW4uYworKysgYi9zcmMvYmluL3Bz
cWwvdGFiLWNvbXBsZXRlLmluLmMKQEAgLTI1NzUsNyArMjU3NSw5IEBAIG1hdGNoX3ByZXZpb3Vz
X3dvcmRzKGludCBwYXR0ZXJuX2lkLAogCS8qIEFMVEVSIFVTRVIsUk9MRSA8bmFtZT4gSU4gREFU
QUJBU0UgPGRibmFtZT4gU0VUICovCiAJZWxzZSBpZiAoTWF0Y2hlcygiQUxURVIiLCAiVVNFUnxS
T0xFIiwgTWF0Y2hBbnksICJJTiIsICJEQVRBQkFTRSIsIE1hdGNoQW55LCAiU0VUIikpCiAJCUNP
TVBMRVRFX1dJVEhfUVVFUlkoUXVlcnlfZm9yX2xpc3Rfb2Zfc2V0X3ZhcnMpOwotCS8qIFhYWCBt
aXNzaW5nIHN1cHBvcnQgZm9yIEFMVEVSIFJPTEUgPG5hbWU+IElOIERBVEFCQVNFIDxkYm5hbWU+
IFJFU0VUICovCisJLyogQUxURVIgVVNFUixST0xFIDxuYW1lPiBJTiBEQVRBQkFTRSA8ZGJuYW1l
PiBSRVNFVCAqLworCWVsc2UgaWYgKE1hdGNoZXMoIkFMVEVSIiwgIlVTRVJ8Uk9MRSIsIE1hdGNo
QW55LCAiSU4iLCAiREFUQUJBU0UiLCBNYXRjaEFueSwgIlJFU0VUIikpCisJCUNPTVBMRVRFX1dJ
VEhfUVVFUllfUExVUyhRdWVyeV9mb3JfbGlzdF9vZl9zZXRfdmFycywgIkFMTCIpOwogCS8qIEFM
VEVSIFVTRVIsUk9MRSA8bmFtZT4gUkVTRVQgKi8KIAllbHNlIGlmIChNYXRjaGVzKCJBTFRFUiIs
ICJVU0VSfFJPTEUiLCBNYXRjaEFueSwgIlJFU0VUIikpCiAJewoKYmFzZS1jb21taXQ6IDEwZTRk
OGFhZjQ2ZmI0NmI4Yjc4ZTAyNjU2MGI2OGFmODRhNjQ5NWIKLS0gCjIuNTAuMSAoQXBwbGUgR2l0
LTE1NSkKCg==
--000000000000aa42f8064e245bc5--