MIME-Version: 1.0
References: 
 <CAKSyusJWdWcUKVd3qJXcEaQxJewGymQWV_r3-mc=Knrqo0AZ_g@mail.gmail.com>
 <CAD21AoB4-jPS4CfhMcX72+8L=qGV2Q_9354yqKGj-d6ZgfkE4Q@mail.gmail.com>
 <CAKSyus+UkjbWmoTHUUo6EKB+nzePQ9w8OQXUy92K6Kwp3cZMdQ@mail.gmail.com>
In-Reply-To: 
 <CAKSyus+UkjbWmoTHUUo6EKB+nzePQ9w8OQXUy92K6Kwp3cZMdQ@mail.gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
Date: Wed, 25 Mar 2026 09:33:03 -0700
Message-ID: 
 <CAD21AoA04oupXaK+o3d50Tj5M_zr19ZfvXY=z98tWh8AxWtPKw@mail.gmail.com>
Subject: Re: Add tab completion for SERVER and CONNECTION keywords in psql
To: Yamaguchi Atsuo <acrobatcoder@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAD21AoA04oupXaK%2Bo3d50Tj5M_zr19ZfvXY%3Dz98tWh8AxWtPKw%40mail.gmail.com>
Precedence: bulk

On Wed, Mar 25, 2026 at 8:44=E2=80=AFAM Yamaguchi Atsuo <acrobatcoder@gmail=
.com> wrote:
>
> Hi,
>
> On Mon, Mar 23, 2026 at 1:14=E2=80=AFPM Masahiko Sawada <sawada.mshk@gmai=
l.com> wrote:
>>
>> Hi,
>>
>> On Sun, Mar 22, 2026 at 1:30=E2=80=AFPM Yamaguchi Atsuo <acrobatcoder@gm=
ail.com> wrote:
>> >
>> > Hi,
>> >
>> > This patch adds missing tab completion support in psql for:
>> >
>> > - SERVER keyword after ALTER/CREATE SUBSCRIPTION <name>
>> > - CONNECTION keyword after ALTER/CREATE FOREIGN DATA WRAPPER <name>
>> >
>> > Currently, typing "ALTER SUBSCRIPTION sub1 SERVER" and pressing Tab
>> > does not complete server names, even though the SERVER keyword itself
>> > is already suggested. Similarly, CONNECTION is not suggested as a
>> > completion candidate for FOREIGN DATA WRAPPER commands, despite being
>> > a valid option.
>> >
>> > The patch is generated against the current master branch.
>>
>> It's a fix for an oversight of commit 8185bb5347 rather than proposing
>> a new tab-completion. Good catch. Regarding the patch, I have one
>> comment:
>>
>>     /* ALTER FOREIGN DATA WRAPPER <name> */
>>     else if (Matches("ALTER", "FOREIGN", "DATA", "WRAPPER", MatchAny))
>>         COMPLETE_WITH("HANDLER", "VALIDATOR", "NO",
>> -                     "OPTIONS", "OWNER TO", "RENAME TO");
>> +                     "OPTIONS", "OWNER TO", "RENAME TO", "CONNECTION");
>>
>> I think it's better to maintain the keywords in the list in alphabetical=
 order.
>>
>> Regards,
>>
>> --
>> Masahiko Sawada
>> Amazon Web Services: https://aws.amazon.com
>
>
>  Thank you for the review. I have updated the code to maintain the keywor=
ds in alphabetical order.

Thank you for updating the patch! Pushed.

Regards,

--=20
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com